- Issue created by @msn5158
- ๐ช๐ธSpain pcambra Asturies
Wow, many thanks for this @sahana _n, I've added some feedback to your changes.
- ๐ฎ๐ณIndia Sahana _N
Hi @pcambra
Thanks for the review
Can you please share the link for examples of FA icons? So I can implement it.Thank you!!
- ๐ช๐ธSpain pcambra Asturies
Hi,
What I mean is that we can leverage the class names from FA and allow to add any class, i.e.
https://fontawesome.com/v4/examples/ - ๐ช๐ธSpain pcambra Asturies
This is looking good @sahana_n, we could add a link in the settings form help for the icon class pointing to FA so people can see what options are available maybe?
- ๐ฎ๐ณIndia Sahana _N
Hi @pcambra
Thanks for the review. Can you please suggest one link to add to the settings form as a help text? Or shall I add the link that u provided me for the example?
Thank you!!
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
prem suthar โ made their first commit to this issueโs fork.
- ๐ช๐ธSpain pcambra Asturies
This is derailing pretty fast, could you please double check the changes you're doing, @prem suthar?
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@pcambra
Got it, I'll review the changes and make sure everything is on track.Let me know if there's anything specific you'd like me to focus on .
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Can you please review and let me know for any other changes ?
- ๐ช๐ธSpain pcambra Asturies
This has issues related to translation, please if you do more changes in here, make sure you test the multilingual text for "Likes"
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@pcambra
Here, I only need to add the t() function to static strings, correct?so it should be like this $config->get('like_text', t('Likes));
am i right ? here