🇮🇳India @Sahana _N

Hi

I tried to reproduce the issue issue is replaceable in 11. x.

And I created the MR for 11. x and tests are passed.

RTBC++

Please let me know if I missed anything happy to take suggestions.

sahana _n → made their first commit to this issue’s fork.

Hi @smustgrave ,

Thanks for the review.

I updated the MR. The test coverage for the provider's name is already covered.
Path: core/modules/media/tests/src/Functional/ResourceFetcherTest.php

Please let me know for other concerns. I am happy to take suggestions.

Thank you!!

Hi

I tried to fix the text cases ContentTranslationAddTranslationTest is working fine now.

On the Run of the test case, I got an Error

sahana.n@drupal-11-web:/var/www/html$ vendor/bin/phpunit --configuration phpunit.xml  core/modules/content_translation/tests/src/Functional/ContentTranslationAddTranslationTest.php
PHPUnit 10.5.20 by Sebastian Bergmann and contributors.
Runtime:       PHP 8.3.8
Configuration: /var/www/html/phpunit.xml

F                                                                   1 / 1 (100%)

Time: 00:01.862, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\content_translation\Functional\ContentTranslationAddTranslationTest::testWithOlderSourceTranslation
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save" not found.

/var/www/html/core/tests/Drupal/Tests/WebAssert.php:158
/var/www/html/core/tests/Drupal/Tests/UiHelperTrait.php:78
/var/www/html/core/modules/content_translation/tests/src/Functional/ContentTranslationAddTranslationTest.php:93

FAILURES!
Tests: 1, Assertions: 2, Failures: 1.

ContentTranslationAddTranslationTest Extends the ContentTranslationPendingRevisionTestBase
And here node save was not happening.
I referred to other test cases of how node save happens and fixed it with the submit form.

Now ContentTranslationAddTranslationTest is executing properly.

I am happy to take suggestions if the fix is not appropriate. Please let me know.

Thank you !!

sahana _n → made their first commit to this issue’s fork.

Hi,

I created an MR Please review I tested the test cases, and now the test cases are working fine.

I would greatly appreciate your suggestions for improvement. Please let me know.

Thank you!!

sahana _n → made their first commit to this issue’s fork.

Hi

I tried to reproduce the issue in Drupal 11. x but the issue is not reproducible in Drupal 11. x.

I attached the screen recording, please review it.

Please let me know if I made any mistakes.

Thanks!!

Hi,

I applied the patch successfully and created the custom 'EntityReferenceSelection' plugin.

If the 'plugin_id' is "mymodule_node_type_selection:test", I did not specify any group name, so it is dynamically set to "mymodule_node_type_selection".

If the 'plugin_id' is “mymodule_node_type_selection”, the group name matches the 'plugin_id'.

So RTBC ++

I would greatly appreciate any suggestions or if there’s anything I might have missed in testing.

Thank you!

I Uptaed MR Please review.

I am happy to take suggestions for improvements. Please let me know.
Thank you!!

sahana _n → made their first commit to this issue’s fork.

Updated the MR with tests please review it.
Thanks!!

Hi,

I am to reproduce the issue in 11.x I created an MR please review it.

Here, the “Back to content edit” URL redirects to the default language edit URL. I updated that

I attached the screenshot for reference.

I am happy to accept more suggestions for improvement.

Thank you!!

sahana _n → made their first commit to this issue’s fork.

Hi,
Created an MR for 11. x.

Hi,
I can reproduce the issue in Drupal 10.3.x, when I attempt to view the page with a file reference to a file with NULL as the mimetype I got this error TypeError: Drupal\file\IconMimeTypes::getIconClass(): Argument #1 ($mimeType) must be of type string, null given, called in /var/www/html/core/modules/file/file.module on line 774 in Drupal\file\IconMimeTypes::getIconClass() (line 21 of core/modules/file/src/IconMimeTypes.php).

I tested the same scenario by applying the patch provided in comment #3 (update this comment number). The patch is applied cleanly and the error was cleared. So, I created MR with the same code changes.

I am attaching before & after screenshots for reference.

This issue is also reproducible in 11.x and was able to fix the issue with the same code changes.

I'll be happy to create MR for 11.x also if required. Please suggest how we can proceed further.

sahana _n → made their first commit to this issue’s fork.

Hi,

I tried to reproduce the issue in Drupal 11. x and successfully the issue is reproduced.

Reproducing steps
1. Install Drupal Core 11.x
2. Created the custom form with the file element.
3. On submission called Ajax callback.

I created an MR please review it.
If there are any inaccuracies, I would greatly appreciate your suggestions for improvement.
Thanks!!

sahana _n → made their first commit to this issue’s fork.

Hi,

I have updated the MR as suggested in the above comment Please review it.
I would greatly appreciate your suggestions for improvement. Please let me know.
I have added the screen records.

Thank you!!

sahana _n → made their first commit to this issue’s fork.

Hi

It looks much better. The patch is applied cleanly and I even searched in the Drupal code base for $variables[‘page]. I did not find it. So for me, it looks good.

RTBC ++

Hi,

Even I liked the second option and I updated the MR Please review.
I verified that in Drupal version 11.x.

I would greatly appreciate your suggestions for improvement. Please let me know.

Thank you!!

Hi,
I tested the MR patch in Drupal 10.4 Please review.
If I missed anything, please let me know. I would greatly appreciate any guidance.
Thank you!!

sahana _n → made their first commit to this issue’s fork.

Hi,

1. I rerolled the patch.
2. I modified the module and created the config file. (system.action.action_name.yml)

I was able to see the action in the dropdown.
If I missed anything, please let me know. I would greatly appreciate any guidance.

Hi Prashant.c

I created an MR Please review it.
If there are any inaccuracies, I would greatly appreciate your suggestions for improvement.

Thank you!!

sahana _n → made their first commit to this issue’s fork.

Hi Kanchan Bhogade
Thanks for the review,
I updated the MR, and I removed bullet points please review.

I created an MR Please review it.

Sahana _N → made their first commit to this issue’s fork.

the_g_bomb → credited Sahana _N → .

I created an MR Please review it.

Sahana _N → made their first commit to this issue’s fork.

I created an MR please review it!!

I created an MR please review it.

Sahana _N → made their first commit to this issue’s fork.

I created an MR please review it.

Sahana _N → made their first commit to this issue’s fork.

Hi Diwakar07,

I added a commit Please review.

I created an MR please review it. Please suggest to me if needs any improvements.

Sahana _N → made their first commit to this issue’s fork.

I created an MR please review it.

I applied the patch, and the patch is working fine.
Now we can't see the Wrong title on configuration pages.
+RTBC

I Reviewed the patch the patch is applied cleanly.
Now we can see the Read More button properly.
+RTCB

Hi,

I created an MR for version 3.0.2, which is compatible with D10. Please review.

Sahana _N → made their first commit to this issue’s fork.

The patch is not working.

Hi @abhishek_gupta1 can you please provide steps to reproduce the issue.

I created an MR Please review it.

Sahana _N → made their first commit to this issue’s fork.

I created an MR please review it.

Sahana _N → made their first commit to this issue’s fork.

I created a patch please review it.

Sahana _N → made their first commit to this issue’s fork.

Hi @penyaskito,
Can you please provide more details in the issue summary?

Thanks !!

Hi @r_cheh
I implemented the "Feedback based on the Score" Please review the MR!!

If you have any suggestions please let me know will work on that..

Thank you

Sahana _N → made their first commit to this issue’s fork.

I created the MR please review it.

Sahana _N → made their first commit to this issue’s fork.

I created an MR please review it.

Sahana _N → made their first commit to this issue’s fork.

Please review the MR.

Sahana _N → made their first commit to this issue’s fork.

Sahana _N → made their first commit to this issue’s fork.

Created a MR please review.

Sahana _N → made their first commit to this issue’s fork.

Created a MR Please review.

Sahana _N → made their first commit to this issue’s fork.

Hi @r_cheh

I reviewed the MR and When I clicked on the linked or Facebook button it was not sharing anything so for that I added js in the config and tested it in my system, and it is working fine so I added the commit.

Please review!!

Thank you!!

I Modified the js file as suggested in the description.
Please review.

Sahana _N → made their first commit to this issue’s fork.

Hi r_cheh

I tried applying the patch in my system I installed the module quiz_maker it's giving an error

can you please check this one?

Thank you !!

Please review the MR.

Hi @r_cheh

I hope you're doing well!!

I planned to build this feature in the module, and for that, I planned to use 2 modules.
Those are AddToAny and Metadata modules.
So we need to add dependencies I planned to create a submodule within the module.

can you please give me confirmation? or If you have any other thoughts or suggestions please suggest me I will follow that.

Thank you!

penyaskito → credited Sahana _N → .

Updated the MR please review.

Hi @bobi-mel

Thanks for the review. Sure I will add a separate configuration form for customization.

In the form for each option do I need to add a separate input field?

Thank you!!

Please Review my MR.

Please review the patch.

Sahana _N → made their first commit to this issue’s fork.

Please review MR !!

Sahana _N → created an issue.

Please review MR.

Please review MR.

Sahana _N → created an issue.