- ๐ณ๐ฟNew Zealand quietone
Tested on Drupal 11.x, umami install. I was able to reproduce the problem.
- ๐ฎ๐ณIndia Sahana _N
sahana _n โ made their first commit to this issueโs fork.
- Merge request !9425Previewing translatable nodes can lead to data loss issue fixed. โ (Open) created by Sahana _N
- Status changed to Needs review
10 months ago 11:38am 5 September 2024 - ๐ฎ๐ณIndia Sahana _N
Hi,
I am to reproduce the issue in 11.x I created an MR please review it.
Here, the โBack to content editโ URL redirects to the default language edit URL. I updated that
I attached the screenshot for reference.
I am happy to accept more suggestions for improvement.
Thank you!!
- Status changed to Needs work
10 months ago 1:15pm 5 September 2024 - ๐บ๐ธUnited States smustgrave
Was previously tagged for tests which are still needed
Issue summary is also incomplete.
- Status changed to Needs review
10 months ago 1:57pm 9 September 2024 - ๐ฎ๐ณIndia Sahana _N
Updated the MR with tests please review it.
Thanks!! - Status changed to Needs work
10 months ago 2:00pm 9 September 2024 - ๐บ๐ธUnited States smustgrave
Please see all tags before moving to review, only delays things more.
- First commit to issue fork.
- Merge request !12398Issue #2907091: Previewing translatable nodes can lead to data loss โ (Open) created by acbramley
- ๐ฆ๐บAustralia acbramley
I've started a new branch here because the existing MR did not fix the issue for me and was quite out of date.
The issue is that the temp store uses the node UUID as the key, and is loaded verbatim regardless of language.
Changing the language on the back link won't fix that, in fact the back link already contains the correct langcode in my testing.
- ๐ฆ๐บAustralia acbramley
acbramley โ changed the visibility of the branch 11.x to hidden.
- ๐ฆ๐บAustralia acbramley
acbramley โ changed the visibility of the branch 2907091-previewing-translatable-nodes to hidden.
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
acbramley โ credited larowlan โ .
- ๐ฆ๐บAustralia acbramley
Crediting @larowlan for helping debug the language prefix issue with toUrl().
This is ready for a review, I'll create a CR once we agree this is a decent solution.
- ๐ฌ๐งUnited Kingdom oily Greater London
Nitty rewording of one code comment. Run test-only test.
- ๐ฌ๐งUnited Kingdom oily Greater London
Added further suggestion to review. My review is based on my understanding that the sequence in the test is as follows:
- Edit same node in two tabs, one is english translation, the other spanish
- Change the title in one of the tabs eg english translation
- Preview the spanish version of the node in other tab
- Check whether the spanish version title has been changed to the new title in the english version
- ๐ฌ๐งUnited Kingdom oily Greater London
Test-only test fails as it should. Tests are green.
- ๐ฌ๐งUnited Kingdom oily Greater London
Edit test comment for greater detail/ clarity.
- ๐ฆ๐บAustralia acbramley
Hi @oily
Thank you for trying to improve the documentation but it now exceeds the 80 character line length and I don't think the extra words actually clarify it any better. "a node" implies it is a single node, and we are not opening separate browser tabs as that's not possible. We are simulating a similar scenario to what happens in a browser by previewing 2 translations in a row and then going back to the edit form of the first translation. IMO this is all explained clearly in the current doc block and inline comments.
- ๐ฌ๐งUnited Kingdom oily Greater London
@acbramley Okay 'opening separate browser tabs' might be I was thinking of a nightwatch test. I'll have another review of the latest. My suggestions were nitty.