- Issue created by @tobiasb
- Merge request !9088Issue #3466040: Dialog button/inputs not visible when open details element → (Open) created by tobiasb
- Status changed to Needs review
7 months ago 5:03pm 5 August 2024 - Assigned to tobiasb
- Status changed to Active
7 months ago 5:49pm 5 August 2024 - Status changed to Closed: cannot reproduce
7 months ago 5:58pm 5 August 2024 - 🇩🇪Germany tobiasb Berlin
Is a gin thing 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review .
- Issue was unassigned.
- 🇩🇪Germany tobiasb Berlin
This a core bug. Retested with D11 and details element in views dialog and translations dialog.
- Assigned to tobiasb
- Status changed to Active
7 months ago 10:44am 6 August 2024 - Issue was unassigned.
- Status changed to Needs review
7 months ago 11:16am 6 August 2024 - 🇩🇪Germany tobiasb Berlin
As you can see in the videos, the top is recalculated with the patch.
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- Status changed to RTBC
7 months ago 9:17pm 7 August 2024 - 🇺🇸United States smustgrave
Seems like a straight forward change and javascript failure was random (re-ran tests)
- Status changed to Needs work
6 months ago 1:37pm 23 August 2024 - 🇫🇷France nod_ Lille
This is very bad, especially in the views ui interface.
- Open
/admin/structure/views/view/content - click on
Content: Content type (Content type) - Open/close the details until things get out of hands
The change was made in a place that's not appropriate. The details-aria file is only for accessibility concerns, this is a straight up positioning bug so it needs to live most likely in dialog.position.js.
Also the change did not fix the issue for me.
- Open
- Status changed to Needs review
6 months ago 11:39am 30 August 2024 - 🇮🇳India Sahana _N
Hi,
I have updated the MR as suggested in the above comment Please review it.
I would greatly appreciate your suggestions for improvement. Please let me know.
I have added the screen records.Thank you!!
- Status changed to Needs work
6 months ago 5:22pm 6 September 2024 - 🇺🇸United States smustgrave
Since #16 maybe we should have a test case for this/
- 🇧🇪Belgium klaasvw
I'm not sure if this current MR is addressing the actual problem.
When trying to reproduce the problem it can only be reproduced in the following situation:
- The initial modal content height is less than the viewport height
- After initial load, an element is added or opened inside the modal, resulting in modal content height that is larger than the viewport height
So this only occurs when your browser window is high enough.
The easiest way to reproduce this is using views_ui. Many modals are smaller than the viewport initially but contain many details elements which can be toggled.
The
setResizemethod indialog.position.jsis responsible for this. It sets the modal height toautowhen the situation above occurs, making it possible for the modal height to be larger than the viewport height. - First commit to issue fork.
- 🇺🇸United States smustgrave
Think we should have a simple test case, I prematurely RTBC in #15 and @nod_ in #16 how this broke things.