Attached is a patch for 10.3.x
I'm not sure if this current MR is addressing the actual problem.
When trying to reproduce the problem it can only be reproduced in the following situation:
- The initial modal content height is less than the viewport height
- After initial load, an element is added or opened inside the modal, resulting in modal content height that is larger than the viewport height
So this only occurs when your browser window is high enough.
The easiest way to reproduce this is using views_ui. Many modals are smaller than the viewport initially but contain many details elements which can be toggled.
The setResize method in dialog.position.js is responsible for this. It sets the modal height to auto when the situation above occurs, making it possible for the modal height to be larger than the viewport height.
Looks like it is already fixed in https://www.drupal.org/project/image_effects/issues/3494550 🐛 TypeError in using Textoverlay Active
I've pushed a MR again 2.0.x containing the changes from #5.
This version will only add the setting if one of the ace_editor libraries is loaded.
Also note that not only the Ace basePath is set but also the theme-, worker- and modePath.
Fixed an error when the default URL is used.
The MR and the attached patch add a new service that helps in generating the draft, iframe and published URLs.
Note that there's an assumption that the entity is a node, which was already originally the case. The MR doesn't address that, so maybe something for a follow-up issue.
Also note that you may have to add the code below to you composer.json config when applying the patch through composer. Because the info yml file also has a change it conflicts with the d.o versioning.
"config":
...
"preferred-install": {
"drupal/decoupled_preview_iframe": "source",
"*": "auto"
},
...
The real problem is indeed that cloudinary_sdk_init() is not executed if a module like dynamic_page_cache is enabled, or drush is used.
There are two reasons for that:
- dynamic_page_cache has priority 27 when subscribing to KernelEvents::REQUEST, which is higher than cloudindary
- drush doesn't use the KernelEvents::REQUEST event
I'm going create an MR for 3.0.x that fixes these issues.
Here's a patch that takes the first approach. In my opinion this is better because it's also possible that the drupal JS settings are changed in between multiple ajax updates.
The MR and attached patch removes the override.
I haven't found another way to prevent having the click submit twice though. Contributions are welcome!
Updated the MR and added a patch that also caches admin API calls from the cloudinary_stream_wrapper module. Also implements a fix from 🐛 Cloudinary Stream Wrapper caches items in the database (Database Storage) but never actually checks if an item is inside the storage Active so the db storage is not bypassed.
Because ✨ Avoid overloading admin API Active addresses similar issues and covers additional areas where cloudinary data can be loaded from the database / cache instead of the API I have incorporated the changes introduced in the initial patch in ✨ Avoid overloading admin API Active .
Closing this in favor of ✨ Avoid overloading admin API Active
klaasvw → changed the visibility of the branch 3479652-avoid-overloading-admin to hidden.
The following patch applies the asset caching like the previous patch but also caches Admin API calls in the cache bin. Becasue Cloudinary has a 500 to 2000 requests / hour limit on the admin API and this module calls the API multiple times for every asset it loads the calls add up quickly.
The MR addresses the issue by applying Date.toLocaleDateString to the date string.
breidert → credited klaasvw → .
The attached batches changes the column type to varchar.
The attached patch is a start for fixing the above issues. Feedback and improvements are definitely welcome!
Updated patch that checks if the assets exists (see 🐛 Handle deleted assets Active )
The MR and attached patch addresses the issue.
Attached patch and the MR make the strings translatable.
The MR and attached patch remove the directory validation from the drush simple-oauth:generate-keys command.
klaasvw → created an issue.
The MR and patch attached fixes the bug by checking the field type for both forms. It also refactors the code to use hook_form_FORM_ID_alter to prevent code duplication, and fixes the coding standards warnings.
PR and patch attached to fix the issue.
Hi everyone,
First of all thanks for all the hard work done so far!
I've created an MR with the following changes:
- Re-roll of #19 again the latest 4.x dev
- Support for layout_builder_browser
I haven't been able to test this with layout_builder_iframe_modal.
Patch attached.
Setting the z-index too high will make the balloon overlap any dialog that is opened from the balloon (e.g. when using the linkit_media_library module).
klaasvw → made their first commit to this issue’s fork.
Attached is a patch that addresses these issues:
- The patch introduced earlier
- Keep the file extension in the public_id
- Fall back to the homepage URL if the asset cannot be fetch from cloudinary when generating an external URL
There are multiple problems related to this issue:
* The meta data is never loaded from storage (which is addressed by the previous patch)
* The meta data is never fetched if the asset's public_id contains a file extension
* Because the meta data is always re-fetched a fatal error is thrown if the original file is not found via the Cloudinary admin api: Uncaught InvalidArgumentException: A path was passed when a fully qualified domain was expected
* Pages containing multiple cloudinary assets (e.g. the file admin view, entities with a lot of cloudinary media entities, etc) get a big performance impact because the cloudinary_stream_wrapper module calls the cloudinary api for every asset that is displayed.
The following change will fetch the asset meta data and use the bytes property from cloudinary as the filesize property.
There's also an opportunity to reduce API hits and improve performance by caching the various CloudinaryAssetHelper calls. For example, when calling CloudinaryAssetHelper::loadAssetByPublicId multiple times Drupal is hitting the Cloudinary admin API more than is needed. Could be optimized by storing the assets in memory using a map in the CloudinaryAssetHelper service instance. I didn't implement this for now because it's not required for this change, but might be worth creating a new issue for this.
Please ignore my previous PR, somehow the 2.1.x branch was merged into it.
The latest PR + this patch fixes the issue in 3.0.x
Pushed a new MR that rerolls the above fix for the 3.0.x version.
The PR and the attached patch replaces MediaLibraryUiBuilderInterface with MediaLibraryUiBuilder.
klaasvw → made their first commit to this issue’s fork.
The attached patch wraps the return value in a markup render array element.
klaasvw → created an issue.
matthiasm11 → credited klaasvw → .
If it helps anything, I can vouch for matthiasm11's skills as a developer, having been colleagues for over 9 years. I don't have any recent open source projects available to vouch for my own skills though, but the most representative one is https://www.drupal.org/project/lissa_kickstart → .
Forgot fixing the TranslationLanguageRenderer; new patched attached.
This patch is compatible with drupal core 9.5.x using the patch from https://www.drupal.org/project/drupal/issues/2457999#comment-14853680 🐛 Cannot use relationship for rendered entity on Views Fixed