Attached is a patch that addresses these issues:
- The patch introduced earlier
- Keep the file extension in the public_id
- Fall back to the homepage URL if the asset cannot be fetch from cloudinary when generating an external URL
There are multiple problems related to this issue:
* The meta data is never loaded from storage (which is addressed by the previous patch)
* The meta data is never fetched if the asset's public_id contains a file extension
* Because the meta data is always re-fetched a fatal error is thrown if the original file is not found via the Cloudinary admin api: Uncaught InvalidArgumentException: A path was passed when a fully qualified domain was expected
* Pages containing multiple cloudinary assets (e.g. the file admin view, entities with a lot of cloudinary media entities, etc) get a big performance impact because the cloudinary_stream_wrapper module calls the cloudinary api for every asset that is displayed.
The following change will fetch the asset meta data and use the bytes property from cloudinary as the filesize property.
There's also an opportunity to reduce API hits and improve performance by caching the various CloudinaryAssetHelper calls. For example, when calling CloudinaryAssetHelper::loadAssetByPublicId multiple times Drupal is hitting the Cloudinary admin API more than is needed. Could be optimized by storing the assets in memory using a map in the CloudinaryAssetHelper service instance. I didn't implement this for now because it's not required for this change, but might be worth creating a new issue for this.
Please ignore my previous PR, somehow the 2.1.x branch was merged into it.
The latest PR + this patch fixes the issue in 3.0.x
Pushed a new MR that rerolls the above fix for the 3.0.x version.
The PR and the attached patch replaces MediaLibraryUiBuilderInterface with MediaLibraryUiBuilder.
klaasvw → made their first commit to this issue’s fork.
The attached patch wraps the return value in a markup render array element.
klaasvw → created an issue.
matthiasm11 → credited klaasvw → .
If it helps anything, I can vouch for matthiasm11's skills as a developer, having been colleagues for over 9 years. I don't have any recent open source projects available to vouch for my own skills though, but the most representative one is https://www.drupal.org/project/lissa_kickstart → .
Forgot fixing the TranslationLanguageRenderer; new patched attached.
This patch is compatible with drupal core 9.5.x using the patch from https://www.drupal.org/project/drupal/issues/2457999#comment-14853680 🐛 Cannot use relationship for rendered entity on Views Fixed