TypeError in using Textoverlay

I have created the patch please review it .

Why is the patch different from the diff of the merge request?
The patch covers 2 issues while the MR covers just one.
The MR works for me for the issue that is specified in the title but maybe there is a second issue in the file that is covered by the patch too that I can't test.

Thanks all!

Please do not post patch files: this project only accepts MRs.

Automated tests are failing, so this issue needs work to solve the failures.

@ericvl, there is no need of typecasting at line 69 & 70 as per patch #4. Variables $c1, $c2 are simply defined for iteration of the for() loop.
@mondrake, MR !64 is created to fix the addressed issue.
Thank you.

@priti Then it is OK for me, thanks

Tests are failing.

I tested the issue just by manually adding the two (int) casts in the file and checked of the issue still existed. And the test did well. What I don't understand is how the junit tests could fail after the patch in the MR was applied?
If this test fails now it should have been failed at release of the 4.0.0 version.
Strange...
Anyway, the two casts are the solution to this issue.

Hello eveyone,

I was able to detect the real cause of the problem.
The real cause is a bug in the TextToWrapper.php file in the image_effects\src\Plugin\ImageToolkit\Operation\gd\TextToWrapper.php folder. The problem I've mentioned in the title I had it with PHP 8.2. Due that PHP 8.3 is more strict it generated an error in the assert(is_int()) function in the function translate() in image_effects\src\Component\PositionedRectangle.php.

In the file TextToWrapper.php on line 174 one should replace the line
$x_offset = round($x_delta / 2);
with
$x_offset = (int) round($x_delta / 2);
The round() function creates a non-integer and is detected in the assert(is_innt()).

Is someone able to change this in the merge branch? I am not capable to.
This is the only change that should be done. The previous changes may be deleted.

Thank you.

Please review

Thanks for the modification.
This modification solves the issue now but the test fails again. I think, this has nothing to do with the modification but with the test itself. Some files could not be downloaded in intialisation of the test.
So I've put it on again on "needs work".
If the test is ok, it may be put in RTBC.

Rebased, all tests green now

Merged, thanks

Automatically closed - issue fixed for 2 weeks with no activity.