- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- ๐จ๐ฆCanada pierre paul lefebvre
pierrepaul โ made their first commit to this issueโs fork.
- Merge request !2refs #3430231: update unittests for drupal 11. Bump core version to 11. Remove... โ (Open) created by pierre paul lefebvre
- ๐บ๐ธUnited States m.stenta
m.stenta โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States m.stenta
I'm reviewing this now...
I see that "Bot run #11-137198" has already been merged into 8.x-1.x: https://git.drupalcode.org/project/entity_reference_validators/-/commit/...
@pierrepaul's MR makes two more changes:
- All references to
</code> are replaced with
. See relevant core change record: https://www.drupal.org/node/3401941 โ - Support is added for
^11
and dropped for^8 || ^9
.
With those changes, I'm able to include
entity_reference_validators
via Composer.Tests are passing when I run them locally. Now let's see if we can get them to pass on Drupal.org GitLab...
I rebased @pierrepaul's commit onto 8.x-1.x, and committed two changes to
.gitlab-ci.yml
:- Remove
_TARGET_PHP: "8.1"
. I think we should be testing against the default. - Replace
_TARGET_CORE: "10.0.7"
withOPT_IN_TEST_CURRENT: 1
andOPT_IN_TEST_PREVIOUS_MAJOR: 1
so we can test against Drupal 10 and 11.
.
- All references to
- ๐บ๐ธUnited States m.stenta
I would like to propose that we create a new
2.x
branch for these changes, since support is being dropped for older Drupal core versions, and move forward with a2.0.0
semantic versioning release, without the-beta
designation.What do you think @alexpott @pcambra?
- ๐บ๐ธUnited States m.stenta
Tests pass!
There was one minor PHP CodeSniffer warning, so I pushed a commit to fix that too. :-)
I'd say this is ready for merge! Setting to RTBC...
@alexpott @pcambra please see my suggestion re: a new
2.x
branch and2.0.0
release above! Curious what you think about that.