Contrib.social

Automated Drupal 11 compatibility fixes for entity_reference_validators

Open on Drupal.org →
Created on 17 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !1Automated Project Update Bot fixes → (Merged) created by project update bot
  • Pipeline finished with Success
    about 1 year ago
    Total: 141s
    #121501
  • Comment about 1 year ago →
    project update bot

    This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Pipeline finished with Success
    about 1 year ago
    Total: 140s
    #137598
  • Comment 6 months ago →
    🇨🇦Canada pierre paul lefebvre

    pierrepaul → made their first commit to this issue’s fork.

  • Merge request !2refs #3430231: update unittests for drupal 11. Bump core version to 11. Remove... → (Open) created by pierre paul lefebvre
  • Pipeline finished with Failed
    2 months ago
    Total: 8678215s
    #330624
  • Comment 25 days ago →
    🇺🇸United States m.stenta

    m.stenta → made their first commit to this issue’s fork.

  • Comment 25 days ago →
    🇺🇸United States m.stenta

    I'm reviewing this now...

    I see that "Bot run #11-137198" has already been merged into 8.x-1.x: https://git.drupalcode.org/project/entity_reference_validators/-/commit/...

    @pierrepaul's MR makes two more changes:

    1. All references to </code> are replaced with . See relevant core change record: https://www.drupal.org/node/3401941 →
    2. Support is added for ^11 and dropped for ^8 || ^9.

    With those changes, I'm able to include entity_reference_validators via Composer.

    Tests are passing when I run them locally. Now let's see if we can get them to pass on Drupal.org GitLab...

    I rebased @pierrepaul's commit onto 8.x-1.x, and committed two changes to .gitlab-ci.yml:

    1. Remove _TARGET_PHP: "8.1". I think we should be testing against the default.
    2. Replace _TARGET_CORE: "10.0.7" with OPT_IN_TEST_CURRENT: 1 and OPT_IN_TEST_PREVIOUS_MAJOR: 1 so we can test against Drupal 10 and 11.

      3. .

  • Comment 25 days ago →
    🇺🇸United States m.stenta

    I would like to propose that we create a new 2.x branch for these changes, since support is being dropped for older Drupal core versions, and move forward with a 2.0.0 semantic versioning release, without the -beta designation.

    What do you think @alexpott @pcambra?

  • Pipeline finished with Success
    25 days ago
    Total: 153s
    #461730
  • Comment 25 days ago →
    🇺🇸United States m.stenta

    Tests pass!

    There was one minor PHP CodeSniffer warning, so I pushed a commit to fix that too. :-)

    I'd say this is ready for merge! Setting to RTBC...

    @alexpott @pcambra please see my suggestion re: a new 2.x branch and 2.0.0 release above! Curious what you think about that.

  • Pipeline finished with Success
    25 days ago
    Total: 153s
    #461734
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024