Support TLS for Predis

Created on 5 October 2018, over 6 years ago
Updated 21 March 2023, about 2 years ago

Hi there,

I need to use a tls connection for redis, and there is no way to set this schema in the settings.php file.

Furthermore, Predis Client, from redis contribute module, does not offer the possibility to pass a password either.

✨ Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Merge request !1Issue #3004561: Support TLS for Predis β†’ (Open) created by eelkeblok
  • First commit to issue fork.
  • πŸ‡¨πŸ‡΄Colombia jidrone

    I completely agree with @eelkeblok, if the issue already provide a MR is not needed/good to add patch and even worse without an interdiff.

    The only difference I see between last patch and the MR is the following, which should not be responsibility of this issue.

    +++ b/src/ClientFactory.php
    @@ -27,6 +32,11 @@ class ClientFactory {
    +  /**
    +   * Redis default scheme: will not authenticate.
    +   */
    +  const REDIS_DEFAULT_SCHEME = 'tcp';
    

    That being said, I tested the patch from the MR and it is working fine, so I just re-rolled, moved the new parameter to the end of some config arrays and fixed some CS.

  • Status changed to RTBC almost 2 years ago
  • πŸ‡¬πŸ‡§United Kingdom Alina Basarabeanu

    The patch from #37 fixed the issue in Drupal Version 9.5.10 and redis 1.7.0.
    Can this be merged into the next stable release?
    Thank you

  • Status changed to Needs work 10 months ago
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    Needs a rebase.

  • πŸ‡¬πŸ‡§United Kingdom mark-mackenzie-nexus

    Please can the patch at comment #37 please be added to a production release. It is necessary to allow the module to work with Azure Cache for Redis. Tested successfully from Azure App Service with Drupal 10.3.

  • πŸ‡ΊπŸ‡ΈUnited States mitokens

    Thanks for the fix. I can confirm the patch at #37 works for me in an Azure hosted environment with Predis. I would be very interested in seeing it merged so I don't have to manually track this issue anymore.

  • Status changed to Needs review about 1 month ago
  • πŸ‡¬πŸ‡§United Kingdom somersoft

    @berdir I have merged the 8.x-1.9 tag which is at 8.x-1.v HEAD into the 3004561-support-tls-for branch.

  • πŸ‡ΊπŸ‡ΈUnited States amy_farrell

    The patch at #37 ✨ Support TLS for Predis Needs review works for me using AWS Elasticache-Redis with Drupal 10.4.5, drupal/redis 1.9.0, and predis 2.4.0.

  • πŸ‡¬πŸ‡§United Kingdom somersoft
  • Thank you @Eelke Blok for you MR.
    The diff let me solve a TLS issue on Drupal Predis.
    REgards

Production build 0.71.5 2024