- First commit to issue fork.
- π¨π΄Colombia jidrone
I completely agree with @eelkeblok, if the issue already provide a MR is not needed/good to add patch and even worse without an interdiff.
The only difference I see between last patch and the MR is the following, which should not be responsibility of this issue.
+++ b/src/ClientFactory.php @@ -27,6 +32,11 @@ class ClientFactory { + /** + * Redis default scheme: will not authenticate. + */ + const REDIS_DEFAULT_SCHEME = 'tcp';
That being said, I tested the patch from the MR and it is working fine, so I just re-rolled, moved the new parameter to the end of some config arrays and fixed some CS.
- Status changed to RTBC
about 2 years ago 3:47pm 14 August 2023 - π¬π§United Kingdom Alina Basarabeanu
The patch from #37 fixed the issue in Drupal Version 9.5.10 and redis 1.7.0.
Can this be merged into the next stable release?
Thank you - Status changed to Needs work
about 1 year ago 8:14pm 16 August 2024 - π¬π§United Kingdom mark-mackenzie-nexus
Please can the patch at comment #37 please be added to a production release. It is necessary to allow the module to work with Azure Cache for Redis. Tested successfully from Azure App Service with Drupal 10.3.
- Status changed to Needs review
4 months ago 1:18pm 26 April 2025 - π¬π§United Kingdom somersoft
@berdir I have merged the 8.x-1.9 tag which is at 8.x-1.v HEAD into the 3004561-support-tls-for branch.
- πΊπΈUnited States amy_farrell
The patch at #37 β¨ Support TLS for Predis Needs review works for me using AWS Elasticache-Redis with Drupal 10.4.5, drupal/redis 1.9.0, and predis 2.4.0.
Thank you @Eelke Blok for you MR.
The diff let me solve a TLS issue on Drupal Predis.
REgards- π¬π§United Kingdom somersoft
Incorporated the only change not present in π General support of TLS Active . That means client configuration can be changed and still use the same endpoint.
- π¬π§United Kingdom somersoft
As per my comment β¨ Cache bin handling in multiple Redis DBs Needs review I have created a patch from the MR from all the commits up to d6d6e884 which is the last one at this time.
- π¨πSwitzerland berdir Switzerland
Development on Redis 2.x has officially started. New features to 8.x-1.x will no longer be considered. This will need to be redone on top of the 2.x branch.
See π Introduce Adapters instead of different cache/queue/lock classes per backend Active and https://www.drupal.org/node/3541244 β . It should be far easier to add additional features to the client factories now.
- π¬π§United Kingdom somersoft
Functionality rerolled for the 2.x branch @ 3e7f55117835519f90574036851b072fab334070.
There is no change from the patch for 1.x on how to add the support for TLS.
SHA512 for uploaded files
2227be91116ba4ffb681c39bb3c5a39e55a66b13ee11c8f9f6329ca4890e88473d3b1a832e036b2beb89e8442f035fe8c24d189fef89feb915eea40f972a793f redis-support_tls_on_predis-3004561-52.patch