🇬🇧United Kingdom @somersoft

smustgrave → credited somersoft → .

batigolix → credited somersoft → .

Quick Status Report

Using this baseline.

• All tests now pass and have no phpcs or phpstan errors.
• There are no stylelint errors.
• eslint errors reduced from 125 to 11. Refactoring is now needed to further reduce this number.
• phpstan errors reduced from 219 to 184. Work is ongoing to reduce this further. There is signs of unfinished work in migrating the code from D7.
• phpcs errors reduced from 473 to 241. Work is on going to reduce this number further.

somersoft → created an issue.

somersoft → created an issue.

There are changes to do with solving the issue and also to reduce the number of warnings and errors produced during the running of the Github CI.

somersoft → made their first commit to this issue’s fork.

Add the related Course Credit issue to give visibility on the D10 status of that project/package that provides a class for this project/package.

There is now a check to see if a certificate is published when generating the list of valid certificates.

The following is from composer.json and shows the commit the patch can be applied to. It is currently the last commit to 4.x branch.

    require: {
        "drupal/certificate": "dev-4.x#<strong>eba7efb019fb9d6bf4566304b1d61043bb491dc3</strong>"
    }

https://git.drupalcode.org/project/certificate/-/commit/eba7efb019fb9d6bf4566304b1d61043bb491dc3
updated at February 2, 2023 at 5:38:41 PM GMT .

All three commits, up to 1ba851f74ca1f541d7bcc6ba2d7b08d96bcd748d, on the 4.0.x branch are also present in this branch.

Create a Drupal instance with this module enabled and username validation enable.
Go through the registration process.
Here is where the password validation happens but the passed in account entity has not yet set the username field.
It may be that the enabled Email registration module is having affect.

Just PHPCS and PHPSTAN failing on GitLab CI
Example json to add the diff link to composer(.patches).json

"patches": {
    "drupal/certificate": {
        "Automated Drupal 10 compatibility fixes - https://www.drupal.org/project/certificate/issues/3414060": "https://git.drupalcode.org/project/certificate/-/merge_requests/3.diff"
    }
}

somersoft → made their first commit to this issue’s fork.

Updated the patch for redis 1.7
Here is the list of patches from composer.patches.json

    "drupal/redis": {
      "Currently Drush Cr or Cache Clear UI does not flush Redis cache - https://www.drupal.org/project/redis/issues/2765895": "https://www.drupal.org/files/issues/redis-n2765895-16.patch",
      "Support TLS for Predis - https://www.drupal.org/project/redis/issues/3004561": "https://www.drupal.org/files/issues/2021-11-19/redis-support_tls_on_predis-3004561-37.patch",
      "Implement initial RedisCluster client integration - https://www.drupal.org/project/redis/issues/2900947": "https://www.drupal.org/files/issues/2024-01-15/2900947-60.patch",
      "Cache bin handling in multiple Redis DBs - https://www.drupal.org/project/redis/issues/2395255": "https://www.drupal.org/files/issues/2024-02-01/redis-Cache_bin_handling_in_multiple_Redis_DBs-2395255-5.patch"
    },

Updated the patch so that

1. The controller now uses the 'memcache.settings' service to obtain configuration information.
2. the class \Drupal\memcache\Driver\DriverBase also uses the 'memcache.settings' service to obtain configuration information after checking the information from the configFactory.

From https://git.drupalcode.org/project/ckeditor_selectall/-/blob/8.x-1.x/src... (25th March 2019)

namespace Drupal\ckeditor_selectall\Plugin\CKEditorPlugin;

also from https://git.drupalcode.org/project/ckeditorselectall/-/blob/1.0.x/ckedit... (25th July 2023)

namespace Drupal\ckeditor_selectall\Plugin\CKEditorPlugin;

Perhaps there could be some community monitoring of namespaces.

somersoft → created an issue.

The above Project Update Bot has prompted running rector over the code and it has been updated in the related issue https://git.drupalcode.org/issue/course_relationships-3220941.

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.2.6
2. palantirnet/drupal-rector: 0.19.2

@viren18febS
The change only for the specific case mention. I was looking for a more generic solution to cope with all cases.
Thank you for the patch, I will use that until the generic solution is available. and a modified version of it for the other instance.
The another peice of information that could be helpful is that $variables['directory'] is set to the custom theme directory and not the base theme govuk_theme that it extends.

somersoft → created an issue.

somersoft → changed the visibility of the branch 2.0.x to hidden.

Please review again.

As the oauth2_server.info.yml file needs updating so that it runs with Drupal 10 Framework a fork was made of the code base and updated to be Drupal 10 compatible.
The #26 patch has been added to this code base and also a fix for #28 comment.
The default CI pipeline template has been added and all the tests pass.

Example entry for composer.json

    "repositories": {
        "oauth2_server": {
            "type": "package",
            "package": {
                "name": "drupal/oauth2_server",
                "version": "dev-custom",
                "type": "drupal-module",
                "source": {
                    "url": "https://git.drupalcode.org/issue/oauth2_server-3288840",
                    "type": "git",
                    "reference": "8ed68d27336dcbea0041b0c5e25f92888c6e3ac1"
                }
            }
        }
    }
   "require": {
        "drupal/oauth2_server": "dev-custom"
    }

somersoft → made their first commit to this issue’s fork.

somersoft → made their first commit to this issue’s fork.

somersoft → created an issue.

somersoft → created an issue.

#3 patch rerolled for 4.0.x

+1

Was the email sent as a during the running of the cron functionality?
If so perhaps further investigation is needed there to see if drush cron is being passed the correct parameters. See https://www.drush.org/12.x/commands/core_cron/ for more information on this.

Updated to 0.18.1 today and the patch needed to be rerolled.
Ran

vendor/bin/rector --dry-run --config=./tests/rector/rector.php process web/modules/contrib/metatag

and it produced this error

[ERROR] Could not process "/var/www/web/modules/contrib/metatag/tests/fixtures/d8_metatag_v1.php" file, due to:
"System error: "Rector\Core\Rector\AbstractRector::getName(): Argument #1 ($node) must be of type
PhpParser\Node, null given, called in
vendor/palantirnet/drupal-rector/src/Drupal8/Rector/Deprecation/EntityManagerRector.php155"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line: 190

I think this is the line at fault 141

$config['uuid'] = (new Uuid())->generate();

drupal/metatag version: 1.26.0
palantirnet/drupal-rector version: 0.18.1
rector/rector version: 0.18.10

Patch attached.

somersoft → created an issue.

somersoft → created an issue.

Example JSON to use the 'plain diff' link from the issue fork to patch the quiz package in a composer.json file with the "cweagans/composer-patches" package installed.

"patches": {
    "drupal/quiz": {
      "Quiz result migration in D8 from D7 - 3181926": "https://git.drupalcode.org/project/quiz/-/merge_requests/9.diff"
    }
}

Updated for D10

somersoft → created an issue.

Merge request created for 2.x branch.

is this a clone of https://www.drupal.org/project/rules/issues/3257978 → ?

@AvO WebWorks Thank you for your help with creating a D9/10 version of this package.

All the changes are in the branch 3220941-any-plan-for in that respository as per Creating issue forks → .
Please do continue to review the changes and feel free to request push access to that repository to updated that branch with any further changes.

I think PHP will not load a code file if any of the use classes are not present. This is one of the reasons why the modules course_relationships_credit and course_relationships_uc were created.

Rerolled #31 as the executeWithState() was not protected.

Found that the block disappeared using #88 patch with D9.5.x.
Updated the patch file to restore it.

Add related packages D9 status issues.

@roshni27 These changes are also now present in code fork https://git.drupalcode.org/issue/course_relationships-3220941 for the associated issue.

+1 for being enable to add workflow to different entity types, especially if they are custom entity types.

Thank you for working on this issue.

May I suggest that you continue creating a series of good.* files, like the new tests/Drupal/good/good.module, which should never genrate warnings nor errors for the rules that coder is checking. That way if there is something breaks, like this then the test will fail and flag that there is an issue.

It also provides examples of good code style for all.

I see that in https://github.com/jonathan1055/coder/tree/8.3.x/tests/Drupal/good there are some files.

somersoft → created an issue.

Corrected the mistake as the information was not being passed into the header.

@djdevin
In the issue branch a fair amount of work has been done and the four tests for course_relationships module pass :)

The interaction with the course_uc → and course_credit → modules have been placed into their own modules so that tests for course_relationships can run if the other modules are not enabled or present.

All files pass PHPCS and Drupal rector.

Not sure about src/Form/CourseRelationshipsBuildForm.php whether it should be in course_relationships or course_relationships_uc module as there are bits which called function from UberCart and Course UberCart modules.

somersoft → made their first commit to this issue’s fork.

This patch enables the ability to use a multiple Redis services and configure which cache bin use which service based upon the cache bin name.
The Redis report has been greatly modified to report information per service. It also lists which cache bins have been configured to use each service.
The patch has been used with AWS services in production.
It is fully backward compatible. for single service use and there are no changes to limit the configuration options.
Documentation has also been updated to indicate how to add and configure multiple services.

Can I suggest that
```json
"name": "drupal/core",
```
is replaced with
```json
"name": "drupal/forum",
```
?

Correct patch for the tag 7.x-1.11.

Add style-src-elem as well.

Further review of the code indicated that more changes had to be done.

Here the patch for 7.x-1.x

This updated patch is for 7.x-1.11 release.

Thanks for Patch: https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/....

Worked with D9.5.8

somersoft → created an issue.

Re rolled #20 for seckit 2.0.1

Test are failing because of D9 - The getVocabularyId() method had been deprecated 🐛 D9 - The getVocabularyId() method had been deprecated Needs work .

It was found that in some cases comparing $context_values failed with a PHP Error indicating it was out of stack space when there was large objects in the context. Now a hashes are compare.

The patch can be applied to 8.x-3.0-alpha7 released 3 December 2021 . The patch cannot apply to the -dev as it has moved on.