- Issue created by @pcambra
- πΊπΈUnited States Chris Burge
A number of tests are failing with the following output:
Test code or tested code printed unexpected output:
Deprecated: Optional parameter $key_value_factory declared before required parameter $module_handler is implicitly treated as a required parameter in /builds/issue/oembed_providers-3528538/src/OEmbed/ProviderRepositoryDecorator.php on line 116
Deprecated: Optional parameter $logger_factory declared before required parameter $module_handler is implicitly treated as a required parameter in /builds/issue/oembed_providers-3528538/src/OEmbed/ProviderRepositoryDecorator.php on line 116
The
ProviderRepository
constructor change in D10, and the$key_value_factory
and$logger_factory
parameters are no longer optional: __construct() in D10 vs __construct() in D9.D9 is no longer supported by this module, so all we need to do is make the parameters required:
public function __construct(ProviderRepositoryInterface $decorated, EntityTypeManagerInterface $entity_type_manager, ClientInterface $http_client, ConfigFactoryInterface $config_factory, TimeInterface $time, $key_value_factory, LoggerChannelFactoryInterface $logger_factory, ModuleHandlerInterface $module_handler, $max_age = 604800) {
- First commit to issue fork.
- π―π΅Japan liuyuanchao
> D9 is no longer supported by this module, so all we need to do is make the parameters required:
You are right, I change the parameters not nullable, the phpunit passed.
And by the way, fix phpcs and phpstan warnings.
Please review.