🇩🇰Denmark @osman

SirClickalot please try upgrading to 4.0.2.

On my local, it fixed the issue you reported.

Oh sorry about this experience.

To be honest, 4.x version was intended for Drupal 10 and 11, and keep 8.x-3.x for Drupal 8 and 9.

I released the 4.x a little too soon than I actually wanted.

The functionality is still identical in 4.x and 8.x-3.x.

If you are on Drupal 8 or 9, please downgrade 8.x-3.x, if you are on Drupal 10 or 11, stay on 4.x branch.

I'll check on the issue you shared, and keep you posted.

btw, what is your browser name and version?

Fixed in 8.x-3.16 release.

osman → created an issue.

osman → made their first commit to this issue’s fork.

* Drupal 8
* PHP 7.4
* PHPCS 3.10.1 (stable)

Before:

osman@drupal8-web:/var/www/html$ ./vendor/bin/phpcs -s -p --standard=Drupal web/modules/lazy/
..E..E.... 10 / 10 (100%)



FILE: /var/www/html/web/modules/lazy/js/lazy.js
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 27 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" (Generic.PHP.UpperCaseConstant.Found)
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/lazy/src/Form/LazyForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\ModuleHandlerInterface.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

Time: 294ms; Memory: 8MB

After:

osman@drupal8-web:/var/www/html$ ./vendor/bin/phpcs -s -p --standard=Drupal web/modules/lazy/
.......... 10 / 10 (100%)


Time: 984ms; Memory: 8MB

Thanks, but this issue was addressed in the dev branch about 10 months ago. I created a release of it today. Please try 8.x-3.13

Hi Rahit,

Are you positive you're running PHPCS with `Drupal`, and `DrupalPractice` coding-standards loaded? AFAIK, JavaScript boolean values should be lowercase, but for PHP it should be uppercase.

You can check the installed standards via `phpcs -i`

Because this is what I get:

osman@drupal-web:/var/www/html$ vendor/bin/phpcs web/modules/contrib/lazy

FILE: /var/www/html/web/modules/contrib/lazy/lazy.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FormatterInterface.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/lazy/src/Form/LazyForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\ModuleHandlerInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Time: 203ms; Memory: 10MB

osman@drupal-web:/var/www/html$ vendor/bin/phpcs -i
The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard

Hey @pureh2o,

This module uses the bLazy library for the Drupal 7 version. In fact, the library changes to lazysizes later in 8.x-2.x branch.

See project page for that note:
https://www.drupal.org/project/lazy#breaking-changes-since-2-x →

And for the installation, when in doubt, always refer to the documentation comes with the version :)

https://git.drupalcode.org/project/lazy/-/blob/7.x-1.x/README.md

Oversight on my end.

My apologies to the community.

Drupal 10 compatible 8.x-3.12 is now available.

Thanks Hristo, and everyone : )

Sorry, the patch in previous comment was against 10.x branch.

This is now against 11.x branch.

Hi, I'm the owner/maintainer of previously mentioned CKEditor List Style → module. Sorry for joining at a later stage.

I am very much looking forward to move this functionality to the core. And it is almost there.

Please find the attached re-roll of the patch with some CSS additions, and try it on a Firefox browser.

Here is why: https://caniuse.com/mdn-css_selectors_attribute_case_sensitive_modifier

And at this point I also would like to ask why we insist using the type attribute for the OL and UL elements?

Currently at least, the CKEditor uses following type attribute values for all available list styles:

ul[type="disc"]     // Disc
ul[type="circle"]   // Circle
ul[type="square"]   // Square

ol[type="1"]        // Decimal
ol[type="i"]        // Lower-Roman
ol[type="I"]        // Upper-Roman  
ol[type="a"]        // Lower-Latin
ol[type="A"]        // Upper-Latin

However, the ordered-lists are having a problem with these assignments, at least in my experience.

The values are the same, just lower and upper cases, however, by default, the CSS attribute selectors are case-insensitive.

I didn't find any discussions around this in drupal.org, i hope I'm not spamming this thread with this : )