Drupal Coding Standard Issue

Created on 11 August 2023, 11 months ago
Updated 17 May 2024, about 1 month ago

Problem/Motivation

FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/lazy/js/lazy.js
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 27 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
    |       |     found "true"
--------------------------------------------------------------------------------



📌 Task
Status

RTBC

Version

3.0

Component

Code

Created by

🇮🇳India Rohit Rana

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Rohit Rana
  • Issue was unassigned.
  • Status changed to Needs review 11 months ago
  • Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7
    last update 11 months ago
    Waiting for branch to pass
  • 🇺🇸United States osman San Francisco, CA

    Hi Rahit,

    Are you positive you're running PHPCS with `Drupal`, and `DrupalPractice` coding-standards loaded? AFAIK, JavaScript boolean values should be lowercase, but for PHP it should be uppercase.

    You can check the installed standards via `phpcs -i`

    Because this is what I get:

    osman@drupal-web:/var/www/html$ vendor/bin/phpcs web/modules/contrib/lazy
    
    FILE: /var/www/html/web/modules/contrib/lazy/lazy.module
    ------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------
     9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FormatterInterface.
    ------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/modules/contrib/lazy/src/Form/LazyForm.php
    ---------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------------------------
     17 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\ModuleHandlerInterface.
    ---------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 203ms; Memory: 10MB
    
    osman@drupal-web:/var/www/html$ vendor/bin/phpcs -i
    The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard
    
    
  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • 🇦🇺Australia VladimirAus Brisbane, Australia
  • Pipeline finished with Failed
    about 1 month ago
    #174807
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    about 1 month ago
    Total: 148s
    #174817
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    about 1 month ago
    Total: 144s
    #174821
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    about 1 month ago
    Total: 192s
    #174829
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Success
    about 1 month ago
    #174836
  • Status changed to RTBC about 1 month ago
  • 🇦🇺Australia jannakha Brisbane!

    all green!

Production build 0.69.0 2024