- Issue created by @thomas.frobieter
- First commit to issue fork.
- 🇩🇪Germany lrwebks Porta Westfalica
Case closed: We were only calling
setIcon($icon)
as the default case, but we always have to call it. Why? OtherwisegetIcon()
inMiconIconize
returnsnull
and because therender()
function checks for that, it just returns and skips all of our set parameters!Another success for debugging.
- 🇩🇪Germany Anybody Porta Westfalica
The root cause here is bad function naming!
https://git.drupalcode.org/project/micon/-/blame/2.x/src/MiconIconize.ph...setIcon() vs. setIconAfter() vs. setIconBefore()
All pretend to do similar things, but do very different things... The latter should be named setIconPositionAfter() and setIconPositionBefore(). Then it would be self-explaining, why this fix is needed...
So RTBC, but the naming should also be fixed in a follow-up to be self-explaining.
- 🇩🇪Germany Anybody Porta Westfalica
Follow-up for @LRWebks: 🐛 Rename setIconAfter() & setIconBefore() Active
Should be able to resolve this quickly.
Automatically closed - issue fixed for 2 weeks with no activity.