- Issue created by @vasyok
- Assigned to thomas.frobieter
- π©πͺGermany Anybody Porta Westfalica
Thanks for raising this. It's not a bug, but there's missing information in the README.md that needs to be added to show images from a Drupal view in a Photoswipe Gallery.
If not adding a
photoswipe-gallery
wrapper class in the view around, the photoswipe images won't be shown as gallery, but as single pictures. That's expected, but we should document how to group them into a gallery by adding the requiredphotoswipe-gallery
class.@thomas.frobieter could you elaborate on that in a MR for the README.md? There's already a views subheading, which I think we should extend with the info where the class can / should be put.
I think it would be in the image field or in the views style?
Don't think we'll ever be able to add a UI for that while keeping the required flexibility.
- π©πͺGermany Anybody Porta Westfalica
TL;DR: Add the class
photoswipe-gallery
on the view or another dom element around the images you want to group into a gallery. thomas.frobieter β made their first commit to this issueβs fork.
- Merge request !111Issue #3401194: Photoswipe images in views are not shown as gallery β (Open) created by thomas.frobieter
- Status changed to Needs review
over 1 year ago 11:03am 13 November 2023 - Status changed to Needs work
over 1 year ago 11:08am 13 November 2023 - π©πͺGermany Anybody Porta Westfalica
@thomas.frobieter nice! If possible could you please:
- Use code style for the class snippets
- Eventually add a code example if someone advanced wants to do it code-wise in a template?
- But more important, I think: Additionally to the general explanation, perhaps add the steps a user has to take in the Views UI to add these classes (for less advanced users)Perhaps @LRWebks can help you with details?
This has low priority, but I think we should help newbies as good as possible.Perhaps we should generally review the README and check if it explains the general concepts good enough for users starting with PS?
BTW. when using a single image field with the photoswipe formatter, I think these will be grouped, but not for cases where you'd like to have a gallery across fields or view results?
- π©πͺGermany Anybody Porta Westfalica
PS: Of course, community help with the documentation is highly appreciated.
- Issue was unassigned.
Well, I think it's good enough. I won't invest more time into this topic.
- π©πͺGermany Anybody Porta Westfalica
Tagging for community help to add the steps to be taken in the View UI to add the classes there. @thomas.frobieter added the required general steps / themer steps.
Here is the required information to add classes to views:
https://www.drupal.org/docs/8/core/modules/views/customize-the-output-st... β
- πΊπ¦Ukraine vasyok
Thanx, @Anybody, you right!
I add class "photoswipe-gallery" to view field - and galleries worked!
- First commit to issue fork.
- π©π°Denmark ressa Copenhagen
This is required to make the module work in Views, otherwise the user will click an image, and nothing happens ...
In my opinion, this is a pretty big deal, since the user will think that the module doesn't work, and potentially waste significant time searching, to try to find a solution ...
In that sense, the Views instructions in the README has a major problem, so increasing the Priority.
I have added link to the Views documentation, and hope this MR can get committed ASAP, to help new users avoid wasting time needlessly :) Thanks!