- Issue created by @roromedia
- First commit to issue fork.
- Merge request !433Issue #3427966: Webform Dialog Modal triggered with a link doesn't work on touch device β (Merged) created by jrockowitz
- Status changed to Needs review
about 1 year ago 9:57am 5 April 2024 3:15 1:39 Running- last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass - Status changed to Fixed
about 1 year ago 1:33pm 5 April 2024 -
jrockowitz β
committed 9752e1bf on 6.2.x
Issue #3427966: Webform Dialog Modal triggered with a link doesn't work...
-
jrockowitz β
committed 9752e1bf on 6.2.x
Automatically closed - issue fixed for 2 weeks with no activity.
- π©πͺGermany Anybody Porta Westfalica
Sorry, but I have to disagree this was a good idea. Touch events are special, yes, but at least it should at least have been
touchend
instead oftouchstart
.
Usingtouchend
ensures the event fires when the user lifts their finger, reducing accidental triggers.Still, I think it should not be needed at all in modern browsers, according to this answer: https://stackoverflow.com/a/11398089/10031165
Should we reopen this or create a follow-up?
Which browser and device did you use @roromedia?
Maybe @roromedia could provide the affected browser? If I remind corretly, this where a Safari bug, not sure if click is still problematic in iOS Safari.
- π¦πΉAustria roromedia Linz
The bug occurred on iOS (when tested I used the latest stable version and versions below as well) iPads with Safari as standard browser.
Thanks @roromedia.
So I changed the task title accordingly.
Just came across this problematic behaviour again on Android. Extremely annoying when simple scrolling triggers the webform dialog.
We should try if a simple cursor: pointer; solves the problem with the click event on Safari, see:
https://stackoverflow.com/questions/24077725/mobile-safari-sometimes-doe...I've tested with 'pointerup' instead 'click touchstart' and it seems to work well on all devices and browsers.
But someone should try this on a real Iphone, I only have the Simulator.
So should we re-open this issue or create a new one?
- π©πͺGermany Anybody Porta Westfalica
@jrockowitz could you reopen this one to fix it? Or would you prefer a follow-up?
- π©πͺGermany anruether Bonn
@thomas.frobieter On an Iphone SE2 18.3.2, Safari:
- 'pointerup' does not trigger the modal but opens the link
- 'touchend click' does open the modal when the finger is lifted, which does not really improve the situation much
I'll attach a patch that reverts this issues patch, because we rather use a link for some safari users, instead of interfering with everybody's scrolling.