- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: As just discussed, we could alternatively implement that module as dependency or optional dependency instead of our custom upload fields. Please take a look if that makes sense.
If not, we should add a warning on the settings page, if both modules are enabled. Also in the status report.
- 🇩🇪Germany Grevil
I'll need to take a deeper look into responsive_favicon to understand it better. At least the on the module page linked favicon generator: https://realfavicongenerator.net/ generates a manifest.json (.webmanifest). We have to see if it is actually used inside the module. If so, we should make a check on each website we have our manifest.json added, to overwrite the favicon manifest.json.
- 🇩🇪Germany Grevil
As discussed, we finalized on removing the responsive favicon webmanifest from the html_head entirely and let the user know about this in the status report.
- 🇩🇪Germany Grevil
BUT, unfortunately, this isn't simply possible right now, as responsive favicons just puts everything together in the head and doesn't split the different links:
function responsive_favicons_page_attachments(array &$page) { $tags = responsive_favicons_load_all_icons(); if (!empty($tags['found'])) { $html = [ '#tag' => 'meta', '#attributes' => [ 'name' => 'favicon-generator', 'content' => 'Drupal responsive_favicons + realfavicongenerator.net', ], // This seems like the only way to inject raw HTML into the head section // of Drupal 8. // @todo find a way to make this better. '#prefix' => Markup::create(implode(PHP_EOL, $tags['found']) . PHP_EOL), '#suffix' => '', ]; $page['#attached']['html_head'][] = [$html, 'responsive_favicons']; } }
Furthermore, they are no very 'best practice' like put in the 'prefix' of the meta tag.
- Status changed to Postponed
over 1 year ago 10:05am 23 August 2023 - 🇩🇪Germany Grevil
Let's fix 📌 Split Icon links in their own meta tag definition Needs review first, and then we can properly tackle this issue.
- last update
over 1 year ago 9 pass - @grevil opened merge request.
- 🇩🇪Germany Grevil
Alright, together with the MR used in 📌 Split Icon links in their own meta tag definition Needs review , this works great! Unfortunately, 'html_head' entries can not be keyed by string, so this complex for each if case is needed. Please review and set to POSTPONED afterward.
- Status changed to Needs review
over 1 year ago 1:09pm 23 August 2023 - Assigned to Anybody
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 5:07pm 6 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Awesome work! Haven't tried this yet, but reviewed the code. Please solve the comments, afterwards we should finally check it works as expected and merge it.
- last update
over 1 year ago 9 pass - Status changed to Postponed
over 1 year ago 2:00pm 7 September 2023 - 🇩🇪Germany Grevil
All done, let's wait for 📌 Split Icon links in their own meta tag definition Needs review to resolve and create a follow-up issue for a warning in the meantime as mentioned in https://www.drupal.org/project/responsive_favicons/issues/3382829#commen... 📌 Split Icon links in their own meta tag definition Needs review .
POSTPONED on 📌 Split Icon links in their own meta tag definition Needs review .
- 🇩🇪Germany Grevil
Here is the follow-up issue: 📌 Warn about possible conflict with responsive_favicons module Fixed .
- last update
over 1 year ago 9 pass - 🇩🇪Germany Anybody Porta Westfalica
Should be minor now we have the warning in place!