- Issue created by @drunken monkey
- 🇬🇧United Kingdom catch
Drupal core supports OOP hooks now, so is there any reason to do this?
- 🇦🇹Austria drunken monkey Vienna, Austria
That’s a very good point, thanks. I opened 🌱 Decide between events and OOP hooks Active to discuss this for the Search API module, this module should then probably just follow suite to remain consistent at least within the Search API ecosystem.
- 🇦🇹Austria drunken monkey Vienna, Austria
The Search API issue is closed now and the decision was to stick with events there for now.
However, the main argument was to not change anything hastily, so it’s still arguable whether that means that this module should follow suit.
We’ll either keep everything as-is and be consistent with Drupal Core or drop that consistency to be consistent with Search API and the wider PHP ecosystem instead. Not sure that is worth the effort and hassle.I guess I’m just gonna leave this up for discussion for now, in case anyone else has an opinion here, and see if I ever decide to actually implement this change.