- Issue created by @drunken monkey
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
With perhaps the added thought that we already moved from hooks to events, so moving back might be a bit annoying to anyone who already converted their hook implementations.
I think this is a big argument to keep moving ahead in the direction we already established.
Unless there is a particular advantage or disadvantage to using events over OOP hooks I'd stick with what is there for a bit and see how the community shakes out (both other php projects and drupal itself). It seems like there's some waffling going on.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I think we should stick with events.
- heddn Nicaragua
Events are fine. Hooks are fine for what they are, but events seem less hacky.
- 🇩🇰Denmark xen
Well, let me submit the opposing viewpoint then: I think search_api should use OO hooks. Reasoning, in no particular order:
* Drupal Core has decided this is how we do things in Drupal land.
* search_api is a prominent project, and its codebase is read by many an aspiring developer, I think it ought to show the proper path.
* The ergonomics of OO hooks is, IMO, better.
* OO hooks is AFAIK based on events anyway.
