Contrib.social

Consider the removal of global theme settings

Open on Drupal.org →
Created on 17 March 2010, over 15 years ago
Updated 2 May 2025, about 2 months ago

While fixing a small D7 problem in #741242: Cleanup left over set-to-global-defaults description → , I got carried away and wrote down a couple of other usability issues regarding the theme settings pages, which in fact deserved their own (this) issue. I came to the conclusion that global theme settings can be removed.

At the moment, it isn't clear to the user how the global settings relate to the theme-specific settings. Theme-specific settings are following the global settings 'automagically' until the first time you save the settings form for a specific theme. On that moment, that theme stops following the global settings and starts storing it's own settings. I think the theme settings forms are suffering from a couple of problems:
1) The user doesn't know when he is breaking the invisible link with the global settings.
2) The theme even starts using its own settings (instead of global) if the form is submitted without changes.
3) On the theme-specific form, you can't see if you're looking at default values (loaded from the global settings) or at theme-specific settings.
4) There is no way to switch back to global settings (that choice was made in #518750: Rethink the system settings form → ).
5) It is not clear if global settings are overridden per-setting (which is not the case) or for the theme as a whole (which is what happens).

Global theme settings have probably served a purpose at some point, but currently, I don't see the need for global theme settings at all. You enable a theme, configure the settings and you're good to go. I only do that once or twice on each site I build. The global settings are making an educated guess as long as I haven't adjusted the theme-specific settings. That's not a huge time saver, especially now that the "Display author and date information" settings have been moved elsewhere. As far as I'm concerned, default values can simply be hard-coded in variable_get calls, just like you would do with settings for your average module.

I'd like to read your opinions. Are there good use cases for global theme settings? If so, let's improve the 5 points above. If not, let's remove global theme settings.

📌 Task
Status

Active

Version

11.0 🔥

Component

system.module

Created by

🇳🇱Netherlands marcvangend Amsterdam

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇦🇺Australia mstrelan

    I agree that global theme settings are confusing. For most sites, a lot of the settings aren't really applicable anyway. For most sites I've worked on there are no user pictures, nor are there comments. It also doesn't make sense for "User verification status in comments" to be configurable per-theme (or in global theme settings). This should be comment.module settings. I don't know any site that would set the shortcut icon (favicon) per theme either, it's always global.

    My suggestion would:

    1. Remove "User pictures in posts" and "User pictures in comments" from global settings. They can stay in themes that support them.
    2. Move "User verification status in comments" to /admin/config/people/accounts as a form alter in comment.module
    3. Move "Shortcut icon" to /admin/config/system/site-information

    Then we can remove global theme settings.

  • Comment 24 days ago →
    🇺🇸United States w01f

    I'm not sure about removing "user pictures" entirely, as I have quite a few sites where user (or avatar) pictures are included for both their authored content, profile pages, comments, etc.

    But the current implementations are done using a new media entity image field for users, so this would need some major rework to be modern anyway.

  • Comment 24 days ago →
    🇦🇺Australia mstrelan

    I'm not talking about removing user pictures entirely, I said remove the setting from "global theme settings". It should be per theme, if it's something the theme can handle.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024