Contrib.social

getProcessPlugins() normalises the process array twice

Open on Drupal.org →
Created on 15 July 2024, 6 months ago
Updated 2 August 2024, 5 months ago

Problem/Motivation

If Migration::getProcessPlugins() is called with no parameter, it does this:

    if (!isset($process)) {
      $process = $this->getProcess();
    }

Migration::getProcess() calls getProcessNormalized(), so $process is now a normalised array.

However, getProcessPlugins() then does this:

      foreach ($this->getProcessNormalized($process) as $property => $configurations) {

This means that getProcessNormalized() has been needlessly called a second time.

Steps to reproduce

Proposed resolution

Only call getProcessNormalized() if $process was passed in.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Fixed

Version

10.3 ✨

Component
Migration  →

Last updated about 13 hours ago

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024