Claro: role=button on status report items

I have removed the role="button". attached patch for same.

I will review this patch.

Verified the patch #2 and reviewed it. The patch works fine and I have added the before and after screenshots for reference.
ready for RTBC.

Created MR for the issue for convenience.

Agree it should be removed there but wonder if it should be added to the summary as that does accordion functionality.

@Gauravvvv Thanks for the Work. Applied patch #2 cleanly. Removed role=button on a status report page.

Added role=button to summary as that does accordion functionality.

Verified patch #11 and reviewed it. The patch works fine and I have added the screenshots for reference.
ready for RTBC.

Removing credit for creating an MR when there was already a patch.
Removing credit for rebasing the MR

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/summary#techni... there are no permitted roles for a summary element and button is implied, so this change is not correct

+++ b/core/themes/claro/templates/status-report-grouped.html.twig
@@ -22,7 +22,7 @@
-      <summary id="{{ group.type }}" class="claro-details__summary claro-details__summary--system-status-report">{{ group.title }}</summary>
+      <summary id="{{ group.type }}" class="claro-details__summary claro-details__summary--system-status-report" role="button">{{ group.title }}</summary>

Addressed #15, attached interdiff for same. please review

The last submitted patch, 16: 3350384-16.patch, failed testing. View results →

Re #15 Drupal always applies role="button" to summary elements. See #1848684: Add ARIA role to DETAILS → . However, it's important that along with role="button" the summary element should get a certain combination of aria attributes. Namely, aria-controls, aria-expanded, aria-pressed. Those are needed to make the details/summary element behave like a disclosure widget. Otherwise the summary would become a simple button and screen readers will not announce the state of the element. Which would make thins much worse.

Here are some details.
https://www.scottohara.me/blog/2022/09/12/details-summary.html#consisten...

Given that #1848684: Add ARIA role to DETAILS → was discussed ten years ago we might need to rethink the whole approach. This might be no longer needed at all.

Hi everyone,

I've attempted to rebase the MR !3731 to the 11.x branch, but unfortunately, a large number of unrelated commits also showed up in the MR. I tried to revert my changes a few times, but I couldn't fully restore it to the original state. As a result, multiple comments and commits are added here as I tried to clean things up.

I apologize for the mess. Could someone please help me restore the MR to its previous state? Any assistance to get this back on track would be greatly appreciated.

Thanks!

I've addressed #18 in this patch. Please review.