#Needs accessibility review

It took two tries, but I added the assertions for the button text, before and after toggling.

Unless I totally misunderstand the nth-child selector, my mistake was to look for the second item in the admin menu after installing the Standard profile. That is Structure. I am not sure which profile the Nightwatch tests use, but it seems that the second item is Configuration.

Back to NR.

Added a child issue 📌 Search and categories target="_blank" in core Active for

4. For categories 1 and 2, a single child issue should be filed to ensure all the links warn the user that a new window will be opened.

Fixed a minor typo in the issue summary.

Wanted to double-check because removing "Extend" and "Collapse" was a big part of the original issue: Was the intent to keep "Extend" and "Collapse" in the names for stable9?

That is my understanding.

Any changes to the stable9 theme have the potential to break custom themes based on it, and perhaps cause automated tests to fail. We normally think in terms of the CSS in the theme, but I think it applies to JS, too.

I am removing the tag for an a11y review, thanks to @cwilcox808's comments.

I am setting the status to NW for additional test coverage (Comments #43, #44). I will try to get that done soon, but I have a 1-week vacation coming up. If I do not find time in the next two days, then it will be at least another week before I do it.

Actually two assertions, to show that the name stays constant with the toggling (i.e., to show that we fixed that problem also).

I'd love to have an assertion for the (accessible) name of the button because the choice was very deliberate.

After a little discussion on Slack, a few days ago, with @nod_, we agreed that the stable9 theme should not be changed. It already has its own version of toolbar.icons.theme.css.

Wanted to double-check because removing "Extend" and "Collapse" was a big part of the original issue: Was the intent to keep "Extend" and "Collapse" in the names for stable9?

I've checked the latest changes on a test install and they look good to me.

The functionality is usable with the keyboard, so not likely to be 2.1.1. Assuming this is a bug in the implementation and not a bug in JAWS, the most appropriate criterion is probably 4.1.2.

I am updating the snippets in the issue summary to add the `visually-hidden` CSS class.