- Status changed to Needs work
about 2 years ago 10:59pm 15 February 2023 - 🇺🇸United States smustgrave
Not sure how often accessibility meets.
But there are two proposed solutions can it be highlighted which was chosen please.
- 🇺🇸United States themarkahrens
One potential challenge with this would be when not all content is translated across all languages. For example, if on a US site you had 17 pages of articles but on the CA site there were only 5, what would the appropriate hreflang tags be on
?page=17
of the US site? - Status changed to Needs review
over 1 year ago 4:47pm 11 September 2023 - 🇺🇸United States mfb San Francisco
@mytungsten That is also a challenge outside of this issue, as if a site uses the built-in language switcher block, then they will get switch links that include such query arguments.
@smustgrave As far as which proposed solution was chosen, option B seemed like a good idea to me for cache efficiency reasons, but there is no patch for option B as of yet. So I'd say this issue probably needs both review to determine a solution, and a new patch/MR to be developed.
- Status changed to Needs work
over 1 year ago 1:55pm 13 September 2023 - 🇺🇸United States smustgrave
Reading the 2 options like the idea of using lazy builder too. Moving to NW for that patch.
- 🇪🇸Spain paucala
Hi everyone, I have update to the last version of core (10.2.3) and it seems that the patch does'nt apply anymore. Any idea?
- Status changed to Needs review
4 months ago 9:07am 5 December 2024 - 🇮🇳India _pratik_ Banglore
#27 seems working for 10.2.10 . Need to check if it pass test cases.
- First commit to issue fork.
- Merge request !104763226887-Hreflang on non-canonical content changes → (Open) created by Unnamed author
- 🇮🇳India ramprassad
ramprassad → changed the visibility of the branch 3226887-hreflang to hidden.
- 🇮🇳India ramprassad
Created a MR(10476) with the changes for 11.x. Please check
- 🇺🇸United States mfb San Francisco
Hmm, the MR seems to include numerous unrelated changes/fixes? If we decide to go with "Option A" then we would need a cleaner MR (basically just the patch). But in #25 we discussed that we could potentially instead go with "Option B": re-architect hreflang tags to use a lazy builder to add query string to the hreflang links. We don't have a merge request for "Option B" yet.