ramprassad → changed the visibility of the branch 3499213-wrong-return-type to hidden.
ramprassad → made their first commit to this issue’s fork.
@smustgrave, I have made the necessary changes, please check.
ramprassad → made their first commit to this issue’s fork.
Unassigned and raised the MR
The entity:name token refers to the label() only in taxonomy term and vocabulary entities. The same token returns title for node, subject for comment and the account name for user. So I think it makes sense to use the name for taxonomy and vocabulary. This change would require the test in the token module to be updated as well for which I may need to create a new issue.
ramprassad → changed the visibility of the branch 3496939-taxonomy-token-entityname to hidden.
ramprassad → made their first commit to this issue’s fork.
Tested this in drupal 11.2-dev with php 8.3.12. This seems to work fine with the code provided in the steps. I also tried the way as below and I could see the node getting saved without issues
$node = \Drupal::entityTypeManager()->getStorage('node')->load(7);
$node->set('field_decimal1', (string) "13.5");
$node->save();
@smustgrave, I have addressed the comments on the MR, please check.
@smustgrave, I have removed some unwanted user dependencies in the tests, but this will be required for few tests as revision_uid field will be included for revisionable Path alias. Updated the issue summary and the MR. Please check.
ramprassad → made their first commit to this issue’s fork.
There is no option to set the name as not translatable as this is a core field in taxonomy. If you do not want the name as translatable, you need to remove the translation in the Vocabulary edit page in which case the vocabulary itself will not be translatable.
ramprassad → made their first commit to this issue’s fork.
Unassigning and submitting for review
I have created an MR. Path alias is now made revisionable and revisions get created for the updates made. Please check
This does not seem to be a drupal issue as file_put_contents with the direct path as mentioned in #19 also doesn't work.
ramprassad → made their first commit to this issue’s fork.
@kim,@smustgrave: The merge conflicts from the 11.x rebase on this MR has been resolved and I fixed few CI issues related to the 11.x changes in this MR. I had updated the CR related to this change as well. Please check
I have created a MR as a fix to this issue. Please check
ramprassad → created an issue.
@Kim, I have changed the method name to getDownloadHeaders().
Moving this to review, please check.
@Kim, I have updated the MR with the changes and created a change record for this change https://www.drupal.org/node/3494172 → . All tests pass.
@Kim, Sure I will update my changes for the MR in sometime and provide an update
ramprassad → made their first commit to this issue’s fork.
ramprassad → made their first commit to this issue’s fork.
Unassigned and changed status to Needs review
I have updated the MR with additional event listener for change and fixed the Pipeline issues. Please check
ramprassad → changed the visibility of the branch drupal-3325363-11.x to hidden.
ramprassad → made their first commit to this issue’s fork.
ramprassad → made their first commit to this issue’s fork.
Unassigning as the MR is raised
@saurav-drupal-dev Yes this is how its supposed to be for now. By default "Show add more" button will not be checked and we are waiting on the community's decision(pls see #56 to #60). If it has to be enabled, I can update the config as well.
I have created an MR 10488 for the changes related to this functionality. Please check
ramprassad → made their first commit to this issue’s fork.
I tried and could not reproduce this issue. As cilefen mentions in the above comment, "Y-m-d H:i:s" is not one of the available formats. I tried creating a custom date format in 10.3.8 with "Y-m-d H:i:s" and then changed to "Y-m-d". After upgrading to 10.3.10, I still see the date format as "Y-m-d".
Created a MR(10476) with the changes for 11.x. Please check
ramprassad → changed the visibility of the branch 3226887-hreflang to hidden.
ramprassad → made their first commit to this issue’s fork.
ramprassad → made their first commit to this issue’s fork.
I have committed the changes to fix the MR, now the failing tests are fixed. Please check
ramprassad → made their first commit to this issue’s fork.
+1 for this functionality to be added in core. Tested this and it works fine, it switches to autocomplete when list in the select box exceeds the limit
ramprassad → made their first commit to this issue’s fork.
ramprassad → made their first commit to this issue’s fork.
@smustgrave I have updated the current MR and closed the other one. Please check
ramprassad → changed the visibility of the branch 1156338-fixed-maximum-number-1 to hidden.
@smustgrave I have created a new MR (10400) with an update hook in file.install which updates the add_more:false in the form display config for the applicable bundles where these multivalued fields are available. This includes the changes in the previous MR.
My opinion would be to have add_more:true, to have this feature enabled by default to give a good user experience to content authors. Please review and suggest.
ramprassad → made their first commit to this issue’s fork.
@smustgrave I have created a merge request for 11.x compatibility (MR10351), please check. There is a JSLint issue reported, will check and post further updates. The additional MR created is closed.
ramprassad → made their first commit to this issue’s fork.
@Wim,
The content editors are populating the content with the initial markup <ul id="divisionitemlist" class="text0">​</ul> and the <li>s will be generated using the script available in the content as mentioned in #5. This has worked fine for them in CKE4, so they expect this to work in CKE5 in D10.
I checked with the standalone CKE5 and this works fine as in https://ckeditor.com/docs/ckeditor5/latest/features/source-editing.html, the 'ul' doesn't get stripped when we use the GeneralHtmlSupport plugin along with htmlSupport: {allow: [{name: /.*/,attributes: true,classes: true,styles: true}]. But in Drupal 10.1.7 it is getting stripped for some reason, I'm still checking on this. Any ideas or thoughts?
Regards,
Ramprassad
Any suggestions on this issue?
Its not working in https://ckeditor.com/ckeditor-5/demo/html-support/ - here as well it is removing the entire 'ul' tag as in Drupal's CKE5. But I could see this working in https://ckeditor.com/docs/ckeditor5/latest/features/source-editing.html. It just replaces with intead of removing 'ul'which is fine (pls see attached screenshot cke5souceediting.png)
This is in FullHTML text format(updated the description), so all tags are getting allowed. If we use with li like this <ul id="divisionitemlist" class="text0"><li>​</li></ul>, it is gettin allowed but the
@Wim
There is a related issue I have created based on one of the reported issues in our project. Can you please check? https://www.drupal.org/project/drupal/issues/3408656 🐛 CKeditor 5 removes tag altogether when no is provided Active
Regards,
Ramprassad
ramprassad → created an issue.
There is a patch available for this now in this issue https://www.drupal.org/project/drupal/issues/3364884 🐛 JavaScript operators in Needs work . This worked for me!
Updated the patch #15 to include the updated library version for aggregation for 10.1.x
Merge request #21 is the valid one.
Merge request #22 was mistakenly raised with the intent to merge to 1.1.x but the branch was not available.
Adding the updated patch based on the recent DieterHolvoet's comment above and opened merge request. This can go the version 1.1.x as well.
Regards,
Ramprassad
ramprassad → created an issue.
ramprassad → created an issue.
I'm also facing this issue in drupal 10.1.3 with ckeditor 5. This patch works fine, so created a patch so it can be applied.
ramprassad → created an issue.