- πΊπ¦Ukraine rybchynski
1. Fixed test issues -- (Updated `ImageStyleListBuilder.php`);
2. Added test case to `ImageAdminStylesTest.php`; - Status changed to Needs review
about 1 year ago 6:23am 30 April 2023 - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 6:22pm 30 April 2023 - πΊπΈUnited States smustgrave
For the new service a change record will be needed.
Also D10 is not using es6 so
+ * DO NOT EDIT THIS FILE.
+ * See the following change record for more information,
+ * https://www.drupal.org/node/2815083 β
+ * @preserve
+ */Doesn't apply.
Also patch seems to contain a ton of reformatting in the tests that seems out of scope for this issue and should be reverted.
- πΊπ¦Ukraine rybchynski
Thank you @smustgrave
I'm currently creating change record for the issue.
- πΊπ¦Ukraine rybchynski
A link to the change record: Added filter for the image styles on the image style list page β
Please review. - πΊπ¦Ukraine rybchynski
- Removed useless comment regarding ES6 from the js file.
- Reverted formatting code changes from the test file.
- π³πΏNew Zealand DanielVeza Brisbane, AU
+++ b/core/modules/image/tests/src/Functional/ImageAdminStylesTest.php @@ -298,6 +298,15 @@ class ImageAdminStylesTest extends ImageFieldTestBase { + // Test if search image style form exists. + $this->drupalGet($admin_path); + $image_styles = ImageStyle::loadMultiple(); + $xpath = '//input[@placeholder="Filter by style name"]'; + if (count($image_styles) > 1) { + $this->assertSession() + ->elementExists('xpath', $xpath); + } +
It could be good to move this to a dedicated FunctionalJavascript test and test that the actual filtering works. ModuleFilterTest might be a good example to use
- last update
about 1 year ago Custom Commands Failed