- Issue created by @mcaddz
- Assigned to isalmanhaider
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @isalmanhaider opened merge request.
- 🇵🇰Pakistan isalmanhaider
@mcaddz can you confirm if the pathauto module is enabled or not?
- 🇦🇺Australia mcaddz
@isalmanhaider no this just relates to the core path_alias module.
- 🇦🇺Australia queenvictoria
Hi there @mcaddz and @isalmanhaider. I've just figured out how to add some of these features to path_alias myself but would like to test/extend/progress your work instead. If I look at the git repo I can't see how to create a patch for your work against D9.5. It looks like you probably were working against 10.1. Is there a way to create a patch that I can bring in to my composer.json?
- 🇦🇺Australia mcaddz
@queenvictoria it doesn't look like there's any commits in MR 4026 yet.
You might need to rebase your changes against core 9.5.x and upload a patch file here to add to composer.patches.json.
- 🇦🇺Australia queenvictoria
Thanks @mcaddz.
Attached is my patch against 9.5.
Should I go ahead and make an MR as well?
- 🇦🇺Australia mcaddz
@queenvictoria yes absolutely :)
You could either push to 4026 or create a new 11.x issue fork. Will need tests though.
- last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 9:31am 25 October 2023 23:30 22:11 Running- Status changed to Needs work
about 1 year ago 1:26pm 25 October 2023 - 🇸🇰Slovakia poker10
Thanks for working on this. I think this still needs tests (as per IS and #10).
- 🇦🇺Australia acbramley
Something worth pointing out here that our client just found is that the Url ViewsField plugin doesn't handle alias/paths properly when
display_as_link
is set.This is because it always prepends a
/
to the path. In the case of path_alias entities, they already have a/
. This results in double slashes and breaks the url entirely. We should ensure we have test coverage around this and probably just add anltrim
to the plugin.