🇵🇰Pakistan @isalmanhaider

+1

Hi @ apaderno, I'm willing to contribute and co-maintain this.

isalmanhaider → created an issue.

+1

This issue applies to both Drupal 10 and 11. Patch #2 resolves it on both versions.

However, since the book module is a contrib module in Drupal 11 and removed from core, for D10 you raised a MR to core.
For Drupal 11, please raise a MR as a fix to the book module as well.

+1

#2 worked! Tested on Drupal 11.0-dev, PHP 8.3.

Good catch and a must-have fix.

By default, it pulls low resolution (480 × 360 pixels) and stores as original style.
After applying the patch, it pulls high resolution (1280 × 720 pixels) and stores as original style.

Could you please provide more details and exact steps to reproduce the error?

Explanation:

In Drupal 11, the FieldItemInterface includes two methods: defaultFieldSettings() and defaultStorageSettings(). These methods define default settings for field items at different levels:

- defaultFieldSettings(): Specifies default settings at the field level.
- defaultStorageSettings(): Specifies default settings at the storage level.

Issue:

The methods are expected to return settings with unique names. This is crucial because other parts of the core, like BaseFieldDefinition, merge these arrays. Overlapping names can lead to conflicts or unexpected behavior.

Solution:

Document in both methods that setting names must be distinct to avoid such issues.

+1

Tested on Drupal 7.100 with PHP 8.1. The proposed fix is appropriate and tackles the issue effectively.

@nicoleannevella,

Could you please confirm if you have the Config Ignore module installed, and whether the `core.menu.static_menu_link_overrides` configuration is excluded in its settings? This could be a reason for the import issue.

+1
@grimreaper, I support the proposed resolution to parse version information from Composer when not available in .info.yml.

This change will improve consistency and prevent errors on the status report page, ensuring that version information is reliably available. Leveraging Composer for this purpose aligns with best practices in dependency management and enhances the overall reliability of the system.

I understand the need for consistent logging and tracking in migrations. However, since `MigrateSkipRowException` is planned for deprecation, it would be better to implement a custom solution for this functionality rather than incorporating it into the core.

I agree, both "canceled" and "cancelled" are present in the Drupal codebase, which introduces inconsistency.

This issue indeed needs a fix to align with the American English standard set by Drupal’s style guide and to maintain consistency across the codebase. The community should agree on this change, implement it, and update relevant documentation.

isalmanhaider → created an issue.

@keshav-patel

Drupal 10.2.5
PHP 8.2

isalmanhaider → created an issue.

#38 worked both on local and acquia!
this was a real blocker for us in upgrading to D10

isalmanhaider → created an issue.

@vensires - Thanks it worked for me on Drupal 10.2.3

+1

Thoroughly reviewed and tested; the proposed solution effectively resolves theme suggestions for custom block view modes. Endorsed for community acceptance.

I agree that this issue remains pertinent, especially considering the structure used by CKEditor in Drupal core.

Adopting a similar format for the "allowed_html" setting, as demonstrated in core/profiles/standard/config/install/editor.editor.basic_html.yml, would not only ensure consistency with CKEditor's configuration but also improve clarity and manageability for developers and site administrators.

Such alignment could greatly enhance user experience and reduce configuration errors.

isalmanhaider → created an issue.

Getting the same error

InvalidArgumentException: The state '' does not exist in workflow. in Drupal\workflows\Plugin\WorkflowTypeBase->getState() (line 155 of core/modules/workflows/src/Plugin/WorkflowTypeBase.php).

Steps to reproduce:

under "this workflow applies to" select article, basic page or any content type at /admin/config/workflow/workflows/manage/editorial
then visit node/add/article or node/add/pager you will get WSOD with the following error

Drupal 10.1.4
PHP 8.2.6
content_moderation: 10.1.4
workbench_moderation: 8.x-1.7

Received the same on

- Drupal 10.1.4
- workbench_moderation: 8.x-1.7
- PHP: 8.2.6

Error: Call to undefined method Drupal\content_moderation\Entity\Handler\NodeModerationHandler::onBundleModerationConfigurationFormSubmit() in Drupal\workbench_moderation\Form\BundleModerationConfigurationForm->submitForm() (line 189 of modules/contrib/workbench_moderation/src/Form/BundleModerationConfigurationForm.php).

I attempted solution #9, but it wasn't successful. This might be due to the issue being reopened because of PHP 8.x's strict type-checking. Now, using `count()` and `->loadHTML()` on null results in a "Empty string supplied as input" TypeError.

However, I've attached a patch that resolved the issue on:

- Drupal 7.98
- PHP 8.1.19
- ckeditor_link_file version "7.x-1.3"

Patch #4 makes sense.

Thanks @nitin_lama I appreciate your contribution
However, could you please review the modified README.md - I didn't get the line breaks.

Patch #3 worked on Drupal 10.0.9 with PHP 8.1

+1 RTBC

isalmanhaider → created an issue.

isalmanhaider → created an issue.

I encountered no issues while attempting to replicate the problem on the following setup:

- Drupal 10.1.0-dev
- PHP 8.1
- Gin theme version 8.x-3.x

I enabled Gin theme for both the Admin UI and the entire site. However, during my testing, I found that the icons behaved correctly and did not exhibit any hover-related issues as described in the reported problem.

Screenshot

isalmanhaider → made their first commit to this issue’s fork.

1+ RTBC

You can mark it as fixed.

Perfect, the links are working now!

To keep the README.md and project page description in sync, you can utilize the functionality provided on the project edit page. There, you'll find an option that allows you to "Copy README.md or README.txt file to the description." Simply select this option, and you'll have the ability to choose the desired branch for updating the project description. This way, you can easily ensure that the project page description reflects the content of your README.md file.

isalmanhaider → created an issue. See original summary → .

isalmanhaider → created an issue.

isalmanhaider → created an issue.

This patch includes the following fixes:

• The class name in `_form` should include the leading backslash (`\`) before the namespace (`\Drupal\`).
• For `_entity_type`, it's recommended to use `_entity_type` instead of `entity_type_id`.
• The path for `entity.website_feedback.delete_multiple_form` has been modified to be unique, avoiding conflicts with the `website_feedback.multiple_delete_confirm` route.

isalmanhaider → created an issue.

isalmanhaider → made their first commit to this issue’s fork.

I have evaluated Merge Request 35 on Drupal 10 with PHP 8.1, and it's functioning as expected.
Excellent job, @idiaz.roncero.

+1 RTBC

It appears that I'm unable to recreate the error you've described with the configuration of Drupal 9.5.9 and PHP 8.1.
I've attached a screenshots for reference.

Would you be able to provide more details or steps to reproduce the issue? This would help me in troubleshooting and identifying a solution.

Meanwhile, you could try clearing the cache using Drush, or switch to a different theme temporarily to see if the issue persists. The error may be linked to the 'cca_theme' contributed theme.

isalmanhaider → created an issue.

Did you guys tried using drush up module_name?

Please review this patch

Tested on Drupal 10.1.0-beta1
PHP 8.1.13

The attached screenshot demonstrate flawless working on the above mentioned version of Drupal core and PHP.

In the context of src/Plugin/Validation/Constraint/NodeTitleConstraintValidator.php

As a best practice, helper functions like _node_title_validation_search_excludes_in_title should be moved to a class as a method or placed in a ".module" file if needed across multiple classes or files. In this case, it would be better to move this helper function to the class and access it with $this->_node_title_validation_search_excludes_in_title.

Make sure to rename it to a non-private method.

@AlfTheCat

Could you please provide the HTML code sample?
I would like to try replicating it on my local environment in order to identify and resolve the issue.

Resolved
Screenshot and patch attached

isalmanhaider → created an issue.

Thanks @jay-jangid for the commit.

isalmanhaider → made their first commit to this issue’s fork.

@mcaddz can you confirm if the pathauto module is enabled or not?

@giordy

Can you please confirm the version of Drupal you are referring to? Based on the provided information, there seems to be a discrepancy between the mentioned Drupal version 7 and the selected version 3.0.8, which is applicable for Drupal 9.3 or higher and Drupal 10.

It would be helpful to clarify the Drupal version to ensure accurate assistance. Thank you.

try git apply 3356785-dropdown-menu-style-1.patch

+RTBC

A slight fix.

Resolution

Problem #1 - 3rd level item i.e book in this case isn't displayed (not part of markup at all)

Resolution: First from the block configuration at admin/structure/block/manage/ajans_main_menu for block `Main Navigation` change Number of levels to display to 3 or more (in this case 2 won't work because book is at 3rd level.

Problem # 2 - Styling the nested menu to react on hover.
Resolution: Moreover to style the nested menu, her's the CSS code patch. I will raise a PR as well.