- Issue created by @urvashi_vora
- Status changed to Needs work
over 1 year ago 8:03pm 14 June 2023 - š®š¹Italy apaderno Brescia, š®š¹
+/** + * @file + * Hook implementation for the Entity Count Analyzer module. + */
It is Hook implementations, even in the case the module actually implements a single hook.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:18am 15 June 2023 - š®š³India ashutosh ahirwal India
Providing Updated patch with fixes.
Found status need work after #5.
Used command and argument is:-
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/entity_count_analyzer - šµš°Pakistan isalmanhaider
Patch #4 makes sense.
Thanks @nitin_lama I appreciate your contribution
However, could you please review the modified README.md - I didn't get the line breaks. - š®š³India nitin_lama India
Hey @isalmanhaider, I've reviewed the modified README.md file. There are no line break errors as of now but I believe that README.md file still needs follow the README.md template ā format. Therefore providing the updated patch with the updated README.md changes. Please review. Thanks.
Hi @nitin_lama,
Applied the patch you provided, it was applied successfully, confirmed no errors remaining the line break in README.md file was implemented. Please see below and the attached screenshot.
entity_count_analyzer git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-15/coding-standards-fixed-8.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 9638 100 9638 0 0 26648 0 --:--:-- --:--:-- --:--:-- 27225 patching file README.md patching file entity_count_analyzer.info.yml patching file entity_count_analyzer.links.task.yml patching file entity_count_analyzer.module patching file entity_count_analyzer.routing.yml patching file src/Controller/EntityCountAnalyzerController.php ā entity_count_analyzer git:(1.0.x) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_count_analyzer ā contrib git:(main) ā
Will now move this to RTBC
Thanks,
Jake- Status changed to Needs work
5 months ago 8:57am 19 July 2024 - š®š¹Italy apaderno Brescia, š®š¹
Let's create a merge request, now that patches are no longer tested.
- Status changed to Needs review
5 months ago 9:08am 19 July 2024 -
isalmanhaider ā
committed e34ecf65 on 1.0.x authored by
apaderno ā
Issue #3366756: Fix the issues reported by phpcs
-
isalmanhaider ā
committed e34ecf65 on 1.0.x authored by
apaderno ā