Fix the issues reported by phpcs

Created on 14 June 2023, over 1 year ago
Updated 19 July 2024, 4 months ago
šŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
    +/**
    + * @file
    + * Hook implementation for the Entity Count Analyzer module.
    + */

    It is Hook implementations, even in the case the module actually implements a single hook.

  • Assigned to nitin_lama
  • šŸ‡®šŸ‡³India nitin_lama India

    Addressed #2. Updated patch.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India Ashutosh Ahirwal India

    Providing Updated patch with fixes.
    Found status need work after #5.
    Used command and argument is:-
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/entity_count_analyzer

  • šŸ‡µšŸ‡°Pakistan isalmanhaider

    Patch #4 makes sense.

    Thanks @nitin_lama I appreciate your contribution
    However, could you please review the modified README.md - I didn't get the line breaks.

  • šŸ‡®šŸ‡³India nitin_lama India

    Hey @isalmanhaider, I've reviewed the modified README.md file. There are no line break errors as of now but I believe that README.md file still needs follow the README.md template ā†’ format. Therefore providing the updated patch with the updated README.md changes. Please review. Thanks.

  • Hi @nitin_lama,

    Applied the patch you provided, it was applied successfully, confirmed no errors remaining the line break in README.md file was implemented. Please see below and the attached screenshot.

    entity_count_analyzer git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-15/coding-standards-fixed-8.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  9638  100  9638    0     0  26648      0 --:--:-- --:--:-- --:--:-- 27225
    patching file README.md
    patching file entity_count_analyzer.info.yml
    patching file entity_count_analyzer.links.task.yml
    patching file entity_count_analyzer.module
    patching file entity_count_analyzer.routing.yml
    patching file src/Controller/EntityCountAnalyzerController.php
    āžœ  entity_count_analyzer git:(1.0.x) āœ— cd ..
    āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_count_analyzer
    āžœ  contrib git:(main) āœ—

    Will now move this to RTBC

    Thanks,
    Jake

  • Status changed to Needs work 4 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Let's create a merge request, now that patches are no longer tested.

  • Pipeline finished with Success
    4 months ago
    Total: 129s
    #228690
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs review 4 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    4 months ago
    Total: 158s
    #228707
Production build 0.71.5 2024