Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 9 May 2024, 8 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇮🇳India Vishal Choudhary Dharmshala

    Hi, Team I have Updated the Node Title Validation Module Compatible with Drupal 10. and I have added a patch file and Screenshots. Please check and Review the code.

  • First commit to issue fork.
  • Comment over 1 year ago →
    🇮🇳India Vishal Choudhary Dharmshala

    I have removed the White space Trailing in the fille and added a new patch.

  • @dineshkumarbollu opened merge request.
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi

    The patch #6 applied cleanly and found zero errors.

    Thanks.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India omkar_yewale Mumbai

    Hi @Vishal Choudhary @dineshkumarbollu,

    The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.
    https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-abo... →
    we should restrict the version by replacing core_version_requirement: ^8.8 || ^9 || ^10

  • Assigned to apatel0325
  • Comment over 1 year ago →
    🇮🇳India apatel0325
  • @apatel0325 opened merge request.
  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇳India apatel0325
  • Comment over 1 year ago →
    KaushikV
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India abhinavk

    I am not able to apply Patch #6 to 8.x-1.x-dev. So I have created new patch with same changes and some drupal-check error fixes. Also, made core version changes.

    Please review this new patch.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Build Successful
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India omkar_yewale Mumbai

    On Drupal 10, patch #14 has been applied successfully and is working fine.
    Marking RTBC.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India omkar_yewale Mumbai

    By mistake, moved to RTBC, maintainers can decide.
    thanks.

  • Comment over 1 year ago →
    🇵🇰Pakistan isalmanhaider

    In the context of src/Plugin/Validation/Constraint/NodeTitleConstraintValidator.php

    As a best practice, helper functions like _node_title_validation_search_excludes_in_title should be moved to a class as a method or placed in a ".module" file if needed across multiple classes or files. In this case, it would be better to move this helper function to the class and access it with $this->_node_title_validation_search_excludes_in_title.

    Make sure to rename it to a non-private method.

  • Comment over 1 year ago →
    🇵🇰Pakistan isalmanhaider

    Please review this patch

    Tested on Drupal 10.1.0-beta1
    PHP 8.1.13

    The attached screenshot demonstrate flawless working on the above mentioned version of Drupal core and PHP.

  • @isalmanhaider opened merge request.
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India rahul1707

    I have tested MR !7 on D10.0.8 and D9.5.7, functionality is working fine for me. Upgrade status is showing D10 compatible with no issue found.

    Moving this to RTBC.

  • Comment over 1 year ago →
    🇺🇸United States johnlutz

    Hi isalmanhaider. We have 8.x-1.22 version running locally and we are preparing to update to drupal 10 on our project. We tried your MR !7 but when I try to run drush updb I get an error:

    > [warning] Post update function node_title_validation_post_update_8001 not found in file node_title_validation.post_update.php
    > [error] Update failed: node_title_validation_post_update_8001
    [error] Update aborted by: node_title_validation_post_update_8001
    [error] Finished performing updates.

    From what I am reading, a hook_post_update_name function should reside in a module.post_update.php file, not in the module.install file. And also what I am reading is that function is not meant to replace hook_update_N functions but meant to run after them. It seems that the node_title_validation_update_8001 function that was previously there should just remain the same. Maybe I am missing something tho.

    Thanks

  • @johnlutz opened merge request.
  • Comment over 1 year ago →
    🇺🇸United States johnlutz

    I have opened a new mr with that change to revert back to hook_update_N

    Please check

  • Comment over 1 year ago →
    🇮🇩Indonesia drupalnesia

    My clients need to update their site ASAP to Drupal 10. That's why I create a fork of this amazing module here:
    - Node Title Check →

  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    🇯🇴Jordan m.abdulqader
  • Comment 8 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024