abhinavk → created an issue.
abhinavk → made their first commit to this issue’s fork.
abhinavk → created an issue.
abhinavk → created an issue.
MR!3 makes module Drupal 11 compatible. Functionality works as expected in Drupal 10 and Drupal 11.
Moving to RTBC.
abhinavk → changed the visibility of the branch 3430681-d11_ready to hidden.
MR!10 makes module Drupal 11 compatible. Tested in Drupal 10 and Drupal 1, functionality works fine.
RTBC+1
Tested MR!6 in Drupal 10 and Drupal 11. This MR makes module D11 compatible and functionality works fine.
Moving to RTBC.
abhinavk → changed the visibility of the branch 3435424-d11_ready to active.
abhinavk → changed the visibility of the branch 3435424-d11_ready to hidden.
abhinavk → created an issue.
abhinavk → created an issue.
abhinavk → created an issue.
abhinavk → created an issue.
MR!6 Makes this module Drupal 11 compatible. Functionality works as expected on Drupal 10 and Drupal 11.
Marking as RTBC.
MR!4 Makes this module Drupal 11 compatible. Functionality works as expected on Drupal 10 and Drupal 11.
RTBC +1
abhinavk → changed the visibility of the branch 3451871-d11_readiness to hidden.
abhinavk → changed the visibility of the branch 3429024-d11_ready to hidden.
abhinavk → made their first commit to this issue’s fork.
abhinavk → changed the visibility of the branch 3451871-d11_ready to hidden.
abhinavk → made their first commit to this issue’s fork.
abhinavk → made their first commit to this issue’s fork.
abhinavk → made their first commit to this issue’s fork.
abhinavk → made their first commit to this issue’s fork.
Tested MR!2. It makes module D11 compatible. Functionality works as expected in Drupal 10 and Drupal 11.
Marking as RTBC.
Tested MR!8 in Drupal 10 and Drupal 11. It makes module is Drupal 11 compatible and functionality is also working as expected.
Marking as RTBC.
I have verified MR!6 on Drupal 10 and Drupal 11. This MR makes module Drupal 11 compatible and functionality is working as expected.
Marking as RTBC.
abhinavk → made their first commit to this issue’s fork.
I have tested module on Drupal 10 and Drupal 11. Module functionality is working as expected.
Moving to RTBC.
Created MR!5 with all the required changes to make the module compatible with Drupal 11.
Module is not compatible with CKEditor5 and will not work with it. I have tested module with CKEditor4 to check functionality and it works fine.
We need this module to be made CKEditor5 compatible to be useable.
abhinavk → made their first commit to this issue’s fork.
abhinavk → created an issue.
I have tested MR!2 on Drupal 10 and Drupal 11. Module is Drupal 11 compatible with this, and functionality works as expected.
Moving to RTBC.
abhinavk → changed the visibility of the branch 3434075-d11_ready to hidden.
abhinavk → made their first commit to this issue’s fork.
Asset optimizer is deprecated. I have added fix based on below change log.
Change log:
https://www.drupal.org/node/2888767 →
MR!23 Makes module Drupal 11 compatible.
For me using Xampp on windows, some h5p content types like true/false and fill in the blanks does not work (display) on node page after above fix. (Without this fix page breaks on Drupal 11).
If I disable Aggregate JS & CSS
, then everything works fine.
Please suggest a solution for this or a better fix if anybody find it.
I have added some fixes for issues I encountered on Drupal 11 in MR!23.
Category for Field type does not work with @Translation. Fixed it.
Change log:
https://www.drupal.org/node/3375748 →
abhinavk → made their first commit to this issue’s fork.
I have fixed some errors I got in Update status scan. Also added some other fixes in MR!29.
Category for Field type does not work with @Translation. Fix it.
Change log:
https://www.drupal.org/node/3375748 →
File validators are changed as of D10.2.
Change log:
https://www.drupal.org/node/3363700 →
For the config export error, there is already an issue for it. The patch in that issue will work even with this MR.
Issue link:
https://www.drupal.org/project/video/issues/3314510
🐛
Entity type 'Drupal\video_transcode\Entity\Preset' is missing 'config_export' definition in its annotation
RTBC
Using Patch from this issue and MR!29, this module is Drupal 11 compatible. Please review it.
abhinavk → made their first commit to this issue’s fork.
MR!15 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1
abhinavk → created an issue.
abhinavk → made their first commit to this issue’s fork.
abhinavk → made their first commit to this issue’s fork.
abhinavk → made their first commit to this issue’s fork.
abhinavk → made their first commit to this issue’s fork.
Adding MR !25 as patch.
Updated Patch.
I have used patch #6 and I am getting below fatal error:
Error: Class "Drupal\views_bootstrap\Plugin\views\style\Html" not found in Drupal\views_bootstrap\Plugin\views\style\ViewsBootstrapGrid->getCustomClass() (line 108 of modules\contrib\views_bootstrap\src\Plugin\views\style\ViewsBootstrapGrid.php).
I have added fix for this in my patch.
I have created this patch for above issue.
AbhinavK → created an issue.
I have created patch from MR!5 which works with 11.0.x version (easy_install_d10_11.0.x.patch).
I have also added fix for error mentioned in #27 in MR!7 and created patch (easy_install_d10_8.x-10.x.patch) for same. This patch works with 8.x-10.x version.
Please review both and use as required.
I have fixed core/jquery.ui issue and created new patch, please review this patch.
I have created this patch which makes this theme Drupal 10 compatible.
Please review it.
AbhinavK → created an issue.
I have tested Patch #6 in Drupal 10.0.9 and it makes module compatible. Functionality is also working fine for me.
Moving to RTBC.
I tested Patch #4, it makes module D10 compatible but there is 1 error in upgrade_status.
Call to deprecated method toInt() of class Drupal\Component\Utility\Bytes. Deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Use Drupal\Component\Utility\Bytes::toNumber() instead
I have fixed this error and uploading new patch.
I have tested Patch #2 in Drupal 9.5.9 and Drupal 10.0.9. It is working fine for me.
Moving to RTBC.
I have tested MR !1 in drupal 10.0.9. It is working fine for me.
Moving to RTBC.
I have tested Patch #4 in Drupal 9.5.9 and Drupal 10.0.9. It works fine for me.
Moving to RTBC.
Tested Patch #2 in drupal 9.5.9 and drupal 10.0.9. Functionality was not working in drupal 10 because of deprecated hook_form_alter.
Uploading a new patch with deprecation fix. Drupal-check shows no errors with ignorable false.
Tested Patch #2 on Drupal 10.0.9. It is working fine for me.
Moving to RTBC.
This is new Patch with fixes from Upgrade status. Please review this.
I have tested Patch #7 in Drupal 10.0.9. It works fine for me.
Moving to RTBC.
Created this new patch by fixing some errors. Drupal-check errors are ignorable.
Please review this patch.
Please ignore above Patch #4. Uploaded wrong patch by mistake.
Please review this Patch.
After applying Patch #3 there are still errors in upgrade status.
I have created this patch by fixing all Upgrade status error and it makes module drupal 10 compatible. There are 2 drupal-check errors which are ignorable, so not fixed it.
Please review this Patch.
Patch #2 is working fine for me on drupal 10.0.9 and functionality is working as expected.
Moving to RTBC.
Patch #3 makes module Drupal 10 compatible but there are some errors while testing functionality. I have fixed all the errors I have found and created new patch.
Please review the patch.
Also uploading Drupal-check errors which are all ignorable.
I am not able to apply Patch #2, so I have created a new patch. Also removed duplicate entry in .links.menu.yml file which was preventing settings page option to show up on configuration page.
Please review this new patch.
Patch #2 makes the module Drupal 10 compatible. I checked in Drupal 10.0.9 and php 8.1 and functionality works as expected.
Moving to RTBC.
Patch #7 works fine for me in Drupal 10.0.9 and php 8.1. Functionality also works as expected.
Setting to RTBC.
Patch #5 works fine for me in Drupal 10.0.9 and php 8.1. Functionality works as expected.
Moving to RTBC.
Patch #5 works fine for me in Drupal 10.0.9 and php 8.1. Functionality works as expected.
MR !6 makes module Drupal 10 compatible but there are some errors in Upgrade status.
I have created patch to fix these errors. Please review it.
I am not able to apply Patch #6 to 8.x-1.x-dev. So I have created new patch with same changes and some drupal-check error fixes. Also, made core version changes.
Please review this new patch.
After checking the upgrade status error, I noticed that stopPropagation() is called by $event which is object of Drupal\layout_builder\Event\SectionComponentBuildRenderArrayEvent Class and this class extends Drupal\Component\EventDispatcher\Event Class which Provides a forward-compatibility layer for the Symfony 5 event class.
The proposed fix is already done at core level through above class in Drupal 10. Also, this error does not show up in drupal-check for drupal 10.
So, in my opinion we can ignore this error. Please let me know if I am wrong. Thanks.
I have tested Patch #3. It works fine for me in Drupal 10.0.9 and functionality is also working fine.
Moving to RTBC.
I have created this patch which makes this module Drupal 10 compatible.
Uploading the patch. Please someone review it.
AbhinavK → created an issue.
Patch #2 works for me on Drupal 10.0.8.
RTBC +1.
Patch #5 works fine for me. It makes module D10 compatible for my Drupal 10.0.8. Functionality working as expected.
Setting as RTBC.
I have created this patch to make this module Drupal 10 compatible.
Please review this patch.
AbhinavK → created an issue.
I have tested patch #4 in Drupal 9.5.8 and Drupal 10.0.8. Everything works fine for me.
Setting to RTBC.
Patch #11 works fine for me in Drupal 10.0.8.
Setting to RTBC.
I have tested patch #2 in Drupal 10.0.8 and Drupal 9.5.8. This patch makes module D10 compatible and functionality is working as expected.
Changing status to RTBC.
I have fixed the console error in this new patch. Functionality should be working fine with this.
I have tested MR !4 in Drupal 10.0.8. It is working fine.
Can we get new version release for this.
RTBC +1
I have tested Patch #2 in drupal 9 and drupal 10.0.8 and php 8.1. This patch makes module D10 compatible and functionality is working as expected.
Moving to RTBC.
Patch #2 is working fine for me in Drupal 10.0.8 and php 8.1.
RTBC +1
I have created this patch which makes this module Drupal 10 compatible. Also fixed some drupal-check errors.
Please review this patch.
AbhinavK → created an issue.
I have checked MR !2 in Drupal 10.0.8 and it works fine for me.
RTBC +1.