🇮🇳India @abhinavk

abhinavk → made their first commit to this issue’s fork.

MR!15 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

abhinavk → created an issue.

abhinavk → made their first commit to this issue’s fork.

abhinavk → made their first commit to this issue’s fork.

abhinavk → made their first commit to this issue’s fork.

abhinavk → made their first commit to this issue’s fork.

Adding MR !25 as patch.

Updated Patch.

I have used patch #6 and I am getting below fatal error:

Error: Class "Drupal\views_bootstrap\Plugin\views\style\Html" not found in Drupal\views_bootstrap\Plugin\views\style\ViewsBootstrapGrid->getCustomClass() (line 108 of modules\contrib\views_bootstrap\src\Plugin\views\style\ViewsBootstrapGrid.php).

I have added fix for this in my patch.

I have created this patch for above issue.

AbhinavK → created an issue.

I have created patch from MR!5 which works with 11.0.x version (easy_install_d10_11.0.x.patch).

I have also added fix for error mentioned in #27 in MR!7 and created patch (easy_install_d10_8.x-10.x.patch) for same. This patch works with 8.x-10.x version.

Please review both and use as required.

I have fixed core/jquery.ui issue and created new patch, please review this patch.

I have created this patch which makes this theme Drupal 10 compatible.
Please review it.

AbhinavK → created an issue.

I have tested Patch #6 in Drupal 10.0.9 and it makes module compatible. Functionality is also working fine for me.
Moving to RTBC.

I tested Patch #4, it makes module D10 compatible but there is 1 error in upgrade_status.

Call to deprecated method toInt() of class Drupal\Component\Utility\Bytes. Deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Use Drupal\Component\Utility\Bytes::toNumber() instead

I have fixed this error and uploading new patch.

I have tested Patch #2 in Drupal 9.5.9 and Drupal 10.0.9. It is working fine for me.
Moving to RTBC.

I have tested MR !1 in drupal 10.0.9. It is working fine for me.
Moving to RTBC.

I have tested Patch #4 in Drupal 9.5.9 and Drupal 10.0.9. It works fine for me.
Moving to RTBC.

Tested Patch #2 in drupal 9.5.9 and drupal 10.0.9. Functionality was not working in drupal 10 because of deprecated hook_form_alter.

Uploading a new patch with deprecation fix. Drupal-check shows no errors with ignorable false.

Tested Patch #2 on Drupal 10.0.9. It is working fine for me.
Moving to RTBC.

This is new Patch with fixes from Upgrade status. Please review this.

I have tested Patch #7 in Drupal 10.0.9. It works fine for me.
Moving to RTBC.

Created this new patch by fixing some errors. Drupal-check errors are ignorable.
Please review this patch.

Please ignore above Patch #4. Uploaded wrong patch by mistake.

Please review this Patch.

After applying Patch #3 there are still errors in upgrade status.

I have created this patch by fixing all Upgrade status error and it makes module drupal 10 compatible. There are 2 drupal-check errors which are ignorable, so not fixed it.

Please review this Patch.

Patch #2 is working fine for me on drupal 10.0.9 and functionality is working as expected.
Moving to RTBC.

Patch #3 makes module Drupal 10 compatible but there are some errors while testing functionality. I have fixed all the errors I have found and created new patch.

Please review the patch.

Also uploading Drupal-check errors which are all ignorable.

I am not able to apply Patch #2, so I have created a new patch. Also removed duplicate entry in .links.menu.yml file which was preventing settings page option to show up on configuration page.

Please review this new patch.

Patch #2 makes the module Drupal 10 compatible. I checked in Drupal 10.0.9 and php 8.1 and functionality works as expected.

Moving to RTBC.

Patch #7 works fine for me in Drupal 10.0.9 and php 8.1. Functionality also works as expected.
Setting to RTBC.

Patch #5 works fine for me in Drupal 10.0.9 and php 8.1. Functionality works as expected.
Moving to RTBC.

Patch #5 works fine for me in Drupal 10.0.9 and php 8.1. Functionality works as expected.

MR !6 makes module Drupal 10 compatible but there are some errors in Upgrade status.

I have created patch to fix these errors. Please review it.

I am not able to apply Patch #6 to 8.x-1.x-dev. So I have created new patch with same changes and some drupal-check error fixes. Also, made core version changes.

Please review this new patch.

After checking the upgrade status error, I noticed that stopPropagation() is called by $event which is object of Drupal\layout_builder\Event\SectionComponentBuildRenderArrayEvent Class and this class extends Drupal\Component\EventDispatcher\Event Class which Provides a forward-compatibility layer for the Symfony 5 event class.

The proposed fix is already done at core level through above class in Drupal 10. Also, this error does not show up in drupal-check for drupal 10.

So, in my opinion we can ignore this error. Please let me know if I am wrong. Thanks.

I have tested Patch #3. It works fine for me in Drupal 10.0.9 and functionality is also working fine.

Moving to RTBC.

I have created this patch which makes this module Drupal 10 compatible.

Uploading the patch. Please someone review it.

AbhinavK → created an issue.

Patch #2 works for me on Drupal 10.0.8.

RTBC +1.

Patch #5 works fine for me. It makes module D10 compatible for my Drupal 10.0.8. Functionality working as expected.
Setting as RTBC.

I have created this patch to make this module Drupal 10 compatible.
Please review this patch.

AbhinavK → created an issue.

I have tested patch #4 in Drupal 9.5.8 and Drupal 10.0.8. Everything works fine for me.
Setting to RTBC.

Patch #11 works fine for me in Drupal 10.0.8.
Setting to RTBC.

I have tested patch #2 in Drupal 10.0.8 and Drupal 9.5.8. This patch makes module D10 compatible and functionality is working as expected.
Changing status to RTBC.

I have fixed the console error in this new patch. Functionality should be working fine with this.

I have tested MR !4 in Drupal 10.0.8. It is working fine.

Can we get new version release for this.
RTBC +1

I have tested Patch #2 in drupal 9 and drupal 10.0.8 and php 8.1. This patch makes module D10 compatible and functionality is working as expected.

Moving to RTBC.

Patch #2 is working fine for me in Drupal 10.0.8 and php 8.1.

RTBC +1

I have created this patch which makes this module Drupal 10 compatible. Also fixed some drupal-check errors.

Please review this patch.

AbhinavK → created an issue.

I have checked MR !2 in Drupal 10.0.8 and it works fine for me.

RTBC +1.

I was not able to apply Patch #2, so I made the changes manually and tested patch. Everything is working fine for me in Drupal 9.5.8 and Drupal 10.0.8 and php 8.1.

I am uploading new patch with same changes as above patch, in case anyone else face same issue as me.

RTBC +1.

I checked patch #10 in Drupal 10.0.8. Using this patch I got an error while viewing the webform with added node element.

TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given.

I have fixed this error and 1 drupal check error.

Uploading a new patch, please review it.

I tested patch #6 in drupal 10.0.8 and it looks good to me. Module is made d10 compatible with this patch.

Moving this to RTBC.

Console error issue is already fixed in this issue Support D10 and implement a subscriber for VendorStreamWrapperEvents::COLLECT_SAFE_LIST_REGEX_PATTERNS 📌 Support D10 and implement a subscriber for VendorStreamWrapperEvents::COLLECT_SAFE_LIST_REGEX_PATTERNS RTBC . This also mekes module D10 compatible. Please refer this issue.

I have tested MR !7 in drupal 10.0.8 & drupal 9.5.7 and php 8.1. Everything is working fine for me and I have encountered no issues.

Moving it to RTBC.

This is the correct patch please ignore above patch.

Here is the patch that makes this module d10 compatible. Please review this.

I have tested Patch #4 and it is working fine in drupal 10.0.8, drupal 9.5.7 and php 8.1.

Moving this to RTBC.

I have tested patch #3 in drupal 10.0.8 and it works fine for me.

Moving it to RTBC.

Here is the new patch with test failure fix and code sniffer fixes.

I checked the patch #3 and it works fine. I just some errors while running drupal-check which are not ignorable, so adding fixes for them in new patch.
Also attaching drupal-check file.

While making this module Drupal 10 compatible, I encountered following errors and add solution in the patch:

-Errors in Upgrade status.
-Drupal check errors which were not ignorable. Added drupal-check file.
-Errors faced while testing functionality and running test cases. Mostly related to accessCheck.

Attaching Patch and drupal check file.

AbhinavK → created an issue.

I have applied patch at #4 in Drupal 10.0.3 and drupal 9.5.7 and php 8.1. The module gets d10 compatible and works fine.

Moving to RTBC.

As mentioned in #33, the combination of Patch #31 with MR !10 of The jquery.once changes for the module 📌 The jquery.once changes for the module Fixed and Patch #3 of Remove 'fivestar_preview' theme function 📌 Remove 'fivestar_preview' theme function Needs work makes the module Drupal 10 compatible.

So changing the status to RTBC.

Also uploading a combined patch of all the changes for anyone who needs it.

I checked MR !2 in my local and got Upgrade status error. I have resolved that error and also resolved most of drupal-check errors.

While running tests in local I found 1 issue related to prefix length which I have fixed.

I am uploading upgrade status error, drupal check errors and updated patch.

Please review the patch.

I have tested Patch #5 and it is working fine without any error in Drupal 10.0.3 and Drupal 9.5.7 and php 8.1.
Moving this to RTBC.

I have checked this MR !2 by taking issue branch in local for Drupal 10.0.3 and php 8.1. It works fine for me without any error.

Uploaded evidence and moving to RTBC.

I have created this patch which makes module Drupal 10 compatible. There are no upgrade status or drupal-check error after applying this patch for me.

Please review this patch.

AbhinavK → created an issue.

I have checked Patch #11 and it works fine in drupal 10.0.3 and drupal 9.5.7 with php 8.1.

Moving to RTBC.

I applied patch at #7 in d9 and got error in Upgrade status. Please resolve this.

I have fixed Upgrade status errors and also below drupal-check error and created patch for same.
Please review the patch.

drupal-check error:
$ drupal-check livechat
4/4 [============================] 100%

------ ----------------------------------------------------------------------------------
Line livechat.install
------ ----------------------------------------------------------------------------------
16 Method Drupal\Core\Config\Config::get() invoked with 2 parameters, 0-1 required.
------ ----------------------------------------------------------------------------------

[ERROR] Found 1 error

AbhinavK → created an issue.

I have tested Patch #4 and it works fine for me on drupal 10.0.3 and drupal 9.5.7 with php 8.1.

Moving to RTBC.

Checked Patch #3 in drupal 10.0.3 and php 8.1. Everything is fine.

RTBC +1

I tested patch #4 on drupal 9.5.7 and drupal 10.0.3 and php 8.1 and found below error in Upgrade_status.

Call to deprecated method getImplementations() of class Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in drupal:9.4.0 and is removed from drupal:10.0.0. Instead you should use ModuleHandlerInterface::invokeAllWith() for hook invocations or you should use ModuleHandlerInterface::hasImplementations() to determine if hooks implementations exist.

Also getting error when trying to access help page. (Attached image)

I have fixed these issues and some drupal-check errors as well in new patch.

Attached file with ignorable drupal-check errors.

I tested patch #2 and got below errors in drupal-check. Autocomplete gives error while checking in local, in local dblog, due these drupal-check errors. So I have fixed them.

$ drupal-check ckeditor_link_with_text
3/3 [============================] 100%

------ ---------------------------------------------------------------------------------------------------------------
Line src\Controller\AutocompleteController.php
------ ---------------------------------------------------------------------------------------------------------------
30 Property Drupal\ckeditor_link_with_text\Controller\AutocompleteController::$entityQuery has unknown class
Drupal\Core\Entity\Query\QueryFactory as its type.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
37 Property Drupal\ckeditor_link_with_text\Controller\AutocompleteController::$aliasManager has unknown class
Drupal\Core\Path\AliasManager as its type.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
47 PHPDoc tag @param for parameter $aliasManager with type Drupal\Core\Path\AliasManagerInterface is not subtype
of native type Drupal\Core\Path\AliasManager.
47 Parameter $aliasManager of method
Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
Drupal\Core\Path\AliasManager.
47 Parameter $aliasManager of method
Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
Drupal\Core\Path\AliasManagerInterface.
47 Parameter $entityQuery of method
Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
Drupal\Core\Entity\Query\QueryFactory.
47 Parameter $entityQuery of method
Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
Drupal\Core\Entity\Query\QueryFactory.
79 Call to method get() on an unknown class Drupal\Core\Entity\Query\QueryFactory.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
81 Function db_like not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
83 Function entity_load_multiple not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
85 Call to method getAliasByPath() on an unknown class Drupal\Core\Path\AliasManager.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ---------------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------
Line src\Form\LinkTextEditorDialog.php
------ ---------------------------------------------------------------
43 PHPDoc tag @param references unknown parameter: $file_storage
------ ---------------------------------------------------------------

[ERROR] Found 12 errors

I have tested Patch #2 in Drupal 10 (10.0.3) & Drupal 9 (9.5.7) and php 8.1, it is working fine without any error.

Patch #2 is not getting applied for me. I have checked with Patch #9, it is working fine without error for Drupal 9 (9.5.7) and Drupal 10 (10.0.3).

RTBC +1

Checked using Patch #7 and using method mentioned in #18. Works for me using both method separately on Drupal 10.0.3.

RTBC+1

Patch #4 works for me without any error in local with Drupal 9 (9.5.7) and Drupal 10 (10.0.3) and php 8.1.

Attaching images.

I have created a new patch which makes this module D10 compatible and is working fine for me in my local.

I have also run drupal-check for this and as the errors were ignorable, no fixes were added in this patch.
Adding file with drupal-check errors.

When I was Installing this module in Drupal 10.0.3, it shows incompatible with 10.0.3.

Attached image.

I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.

Moving this to RTBC.

I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.

Moving this to RTBC.

AbhinavK → created an issue.