Contrib.social

Automated Drupal 11 compatibility fixes for blockgroup

Open on Drupal.org →
Created on 16 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120835

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !4Automated Project Update Bot fixes → (Merged) created by project update bot
  • First commit to issue fork.
  • Comment 4 months ago →
    🇮🇳India abhinavk

    abhinavk → changed the visibility of the branch 3429024-d11_ready to hidden.

  • Comment 4 months ago →
    🇮🇳India abhinavk

    MR!4 Makes this module Drupal 11 compatible. Functionality works as expected on Drupal 10 and Drupal 11.

    RTBC +1

  • Comment 3 months ago →
    🇨🇦Canada mparker17 UTC-4

    +1 to RTBC: I have code-reviewed and manually tested the code in merge request !4 and I'm satisfied with it.

    Here's what I did to manually-test !4:

    1. Install ddev (I tested on version 1.24.1)
    2. Clone the module, issue fork, and branch:
      1. git clone --branch '2.x' https://git.drupalcode.org/project/blockgroup.git && cd blockgroup - clone the project
      2. git remote add blockgroup-3429024 https://git.drupalcode.org/issue/blockgroup-3429024.git && git fetch blockgroup-3429024 - add a remote for the issue fork
      3. git checkout -b 'project-update-bot-only' --track blockgroup-3429024/'project-update-bot-only' - switch to the branch for merge request !4
    3. Set up a test site for the module with the ddev/ddev-drupal-contrib plugin:
      1. ddev config --project-type=drupal --docroot=web --php-version=8.3 --corepack-enable --project-name=blockgroup
      2. ddev add-on get ddev/ddev-drupal-contrib && ddev start && ddev poser && ddev symlink-project - run the setup steps for the ddev/ddev-drupal-contrib addon
      3. Go to https://blockgroup.ddev.site/core/install.php in a browser. Confirm that I saw the Drupal 11.1.1 installer. Install the site with the "Standard" install profile
      4. Go to /admin/people/create and create a user with the Content editor role. I used the username test_editor
    4. Set up the module for testing:
      1. Go to /admin/modules; enable the blockgroup module and all its dependencies.
      2. Go to /admin/people/permissions and grant the Content editor role permissions to:
        • Block -> Administer blocks
        • Block Content -> Basic block: Create new content block
        • Block Content -> Basic block: Basic block: Edit content block
        • Block Content -> Access the Content blocks overview page
        • Block Content -> Administer block content
        • Block Group -> Administer blockgroups
      3. Go to /block/add. You see an Add content block form:
        • Set Block description to Block A title.
        • Set Body to Block A body.
        • Click Save.

        You see the message Basic block Block A title has been created.

      4. Go to /block/add. You see an Add content block form:
        • Set Block description = Block B title.
        • Set Body = Block B body.
        • Click Save.

        You see the message Basic block Block B title has been created.

    5. Test the basic module functions in Drupal 11:
      1. Log out of the administrator account, and log in as test_editor created earlier
      2. Go to /admin/structure/block_group_content/add. You see an Add group form. Set Label = Test blockgroup. Click Save. You see the message Created the Test blockgroup Block group content.
      3. Go to /admin/structure/block. You see a Block layout form. You see a region with the title Block group: Test blockgroup.
        1. Click Place block beside the Block group: Test blockgroup region title. You see a Place block modal.
        2. Click the Place block button in the Block A title row. You see a Configure block form. Ensure that Region = Block group: Test blockgroup. Click Save block.
        3. A Block A title Content block appears in the Block group: Test blockgroup region. If you scroll up, you see the message The block configuration has been saved.
        4. Click Place block beside the Block group: Test blockgroup region title. You see a Place block modal.
        5. Click the Place block button in the Block B title row. You see a Configure block form. Ensure that Region = Block group: Test blockgroup. Click Save block.
        6. A Block B title Content block appears in the Block group: Test blockgroup region. If you scroll up, you see the message The block configuration has been saved.
        7. Finally, scroll to the bottom of the form and click Save blocks. You see the message The block settings have been updated.
      4. Go to /user. You see a user/view page for test_editor. You do not see the text Test blockgroup anywhere on the page. You do not see the text Block A title anywhere on the page. You do not see the text Block A body anywhere on the page. You do not see the text Block B title anywhere on the page. You do not see the text Block B body anywhere on the page.
      5. Go to /admin/structure/block. You see a Block layout form. You see a region with the title Sidebar.
        1. Click Place block beside the Sidebar region title. You see a Place block modal.
        2. Click Place block in the Test blockgroup row. You see a Configure block form. Ensure that Region = Sidebar. Click Save block.
        3. A Test blockgroup Block Group block appears in the Sidebar region. If you scroll up, you see the message The block configuration has been saved.
        4. Finally, scroll to the bottom of the form and click Save blocks. You see the message The block settings have been updated.
      6. Go to /user. You see a user/view page for test_editor. You see the text Test blockgroup in the sidebar. You see the text Block A title below it. You see the text Block A body below it. You see the text Block B title below it. You see the text Block B body below it.
    6. Make sure there are no errors being logged:
      1. Log out of the test_editor user created earlier; and log in as the administrator again.
      2. Go to /admin/reports/dblog to ensure our setup/testing did not result in any error messages related to this module.
  • Comment 3 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-392907

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.6
    2. mglaman/phpstan-drupal: 1.3.2
    3. palantirnet/drupal-rector: 0.20.3
  • Comment 3 months ago →
    leymannx Berlin

    Merged, releasing now, leaving issue active for upcoming patches.

  • Comment 3 months ago →
    leymannx Berlin
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024