Drupal 10 compatibility fixes

Created on 23 May 2023, over 1 year ago
Updated 10 November 2023, about 1 year ago

Hello Maintainers,

I am creating this issue to make this module Drupal 10 compatible.

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia abhinavk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @abhinavk
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia abhinavk

    I have created this patch which makes this module Drupal 10 compatible.

    Uploading the patch. Please someone review it.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia jay jangid Jaipur

    Jay Jangid โ†’ made their first commit to this issueโ€™s fork.

  • Assigned to jay jangid
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia jay jangid Jaipur
  • @jay-jangid opened merge request.
  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia jay jangid Jaipur

    Apply patch #2 and Created MR.
    Thank you.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dineshkumarbollu

    Hi

    MR!1 ha still 1 D10 compatible issue.

    vendor/bin/drush upgrade_status:analyze layout_builder_block_language
    [notice] Processing /var/www/html/vbd9/web/modules/contrib/layout_builder_block_language-3362047.

    ================================================================================
    Layout Builder Custom Block Language, --
    Scanned on Tue, 05/23/2023 - 15:59

    FILE:
    web/modules/contrib/layout_builder_block_language-3362047/src/EventSubscriber/La
    youtBuilderComponentLanguageRenderArray.php

    STATUS LINE MESSAGE
    --------------------------------------------------------------------------------
    Check manually 82 Call to deprecated method stopPropagation() of class
    Symfony\Component\EventDispatcher\Event: since Symfony 4.3,
    use "Symfony\Contracts\EventDispatcher\Event" instead
    --------------------------------------------------------------------------------

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia abhinavk

    After checking the upgrade status error, I noticed that stopPropagation() is called by $event which is object of Drupal\layout_builder\Event\SectionComponentBuildRenderArrayEvent Class and this class extends Drupal\Component\EventDispatcher\Event Class which Provides a forward-compatibility layer for the Symfony 5 event class.

    The proposed fix is already done at core level through above class in Drupal 10. Also, this error does not show up in drupal-check for drupal 10.

    So, in my opinion we can ignore this error. Please let me know if I am wrong. Thanks.

  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia rahul1707

    Patch #2 works fine for me in D9.5.7 and D10.0.8 both and making this module D10 compatible.

    Moving this to RTBC for D10 stable release.

  • Status changed to Fixed about 1 year ago
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil divyesh19 Londrina, Paranรก, Brazil

    Committed and released new version. Thank you.

  • Status changed to Fixed about 1 year ago
Production build 0.71.5 2024