Automated Drupal 11 compatibility fixes for simple_recaptcha

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

kim.pepper → made their first commit to this issue’s fork.

I've tried to bump this along by adding a gitlabci build and fixing the phpcs and cspell errors. However, I'm not sure about the eslint warnings and the phpunit test fails.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.6
2. mglaman/phpstan-drupal: 1.3.1
3. palantirnet/drupal-rector: 0.20.3

The merge request is compatible enough to make it all work, but I see the js tests failing and the issue is following:

1) we switch to recaptcha iframe and click the checkbox, it seems that it somewhat has been clicked:
https://issue.pages.drupalcode.org/-/simple_recaptcha-3451320/-/jobs/374...
2) yet on the next screen we can see that checkbox is empty again:
https://issue.pages.drupalcode.org/-/simple_recaptcha-3451320/-/jobs/374...

The generated output of recaptcha checkbox is following:

<span class="recaptcha-checkbox goog-inline-block recaptcha-checkbox-unchecked rc-anchor-checkbox recaptcha-checkbox-clearOutline" role="checkbox" aria-checked="false" id="recaptcha-anchor" tabindex="0" dir="ltr" aria-labelledby="recaptcha-anchor-label">
	<div class="recaptcha-checkbox-border" role="presentation">
		
	</div>
	<div class="recaptcha-checkbox-borderAnimation" role="presentation">
		
	</div>
	<div class="recaptcha-checkbox-spinner" role="presentation">
		<div class="recaptcha-checkbox-spinner-overlay">
			
		</div>
	</div>
	<div class="recaptcha-checkbox-checkmark" role="presentation"></div>
</span>

And what seems to be missing here is:
1) Element class remains recaptcha-checkbox-unchecked while it should become recaptcha-checkbox-checked
2) Aria attribute aria-checked remains false , while it should be switched to true

It seems that final step of 3 failing js tests is not working with current markup/behavior of recaptcha widget things we can try:
1) Click on element with ID = recaptcha-anchor and not class = recaptcha-checkbox
2) optionally wait until aria-checked attribute has been really changed to true , and/or element class has been successfuly changed to recaptcha-checkbox-checked

Inspiration:
https://github.com/remarkablemark/remarkablemark.github.io/blob/master/_...
https://git.drupalcode.org/project/recaptcha/-/blob/8.x-3.x/tests/src/Fu...

ah the gitlab-ci.yml file is added via fork , so this test won't trigger the pipeline

It seems the Automated Drupal 11 compatibility bot force pushes over our MR.

I've created a new one.

The others can be closed by a project owner.

I was able to reproduce the test fail locally, but wasn't able to work out what the cause is.

There are a few eslint errors too which could clean up the javascript but I assume that can be done in a follow up.

For tests, it seems that switch to recaptcha iframe is working properly, the only thing we miss is clicking on right element, let's try to switch from .recaptcha-checkbox to #recaptcha-anchor element

Okey this will lead us to nowhere, even after validating that the click event is triggered, and adding 30s timeout, it keeps spinning and spinning:

going back from iframe to page content still shows empty checkbox:

This will lead us to nowhere and will take lot of time to investigate , since it is only 3 tests and all other tests are passing, I will create a separate issue for that ( it could be that we will have to completely change the idea for the checkbox itself, maybe it is not even possible to test it anymore ).

sandboxpl → closed merge request !21

sandboxpl → closed merge request !22

All right, I've created a follow up issue to check the recaptcha checkbox part of tests: https://www.drupal.org/project/simple_recaptcha/issues/3495253 📌 JavaScript tests - recaptcha checkbox does not work anymore Active
And new release for Drupal 11 compat is now available: https://www.drupal.org/project/simple_recaptcha/releases/8.x-1.0-beta9 →

Thanks everyone for all the help with this issue!

Thanks @sandboxpl!

Automatically closed - issue fixed for 2 weeks with no activity.