Automated Drupal 11 compatibility fixes for views_data_export

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.4
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

This works for me!

Opened https://git.drupalcode.org/project/views_data_export/-/merge_requests/45 and resolved issues with tests.

acbramley → changed the visibility of the branch project-update-bot-only to hidden.

MR45 works for me
RTBC+1

The patch does not appear to address all of the issues identified in the code audit.

[notice] Processing /srv/drupal/hudoig-d10/dev/code/hudoigd10/docroot/modules/contrib/views_data_export.

================================================================================
Views Data Export,  8.x-1.4
Scanned on Mon, 09/16/2024 - 13:38

FILE: modules/contrib/views_data_export/src/Plugin/views/display/DataExport.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         749  Fetching deprecated class constant EXISTS_REPLACE of        
                    interface Drupal\Core\File\FileSystemInterface. Deprecated  
                    in drupal:10.3.0 and is removed from drupal:12.0.0. Use     
                    Drupal\Core\File\FileExists::Replace instead.               
--------------------------------------------------------------------------------

FILE:
/srv/drupal/hudoig-d10/dev/code/hudoigd10/vendor/symfony/deprecation-contracts/f
unction.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.12: Getting node "filter" on a            
                    "Twig\Node\Expression\FilterExpression" class is deprecated.
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.12: Getting node "filter" on a            
                    "Twig\Node\Expression\FilterExpression" class is deprecated.
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.12: Getting node "filter" on a            
                    "Twig\Node\Expression\FilterExpression" class is deprecated.
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.12: Getting node "filter" on a            
                    "Twig\Node\Expression\FilterExpression" class is deprecated.
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.12: Getting node "filter" on a            
                    "Twig\Node\Expression\FilterExpression" class is deprecated.
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.12: Not passing an instance of            
                    "TwigFunction" when creating a "render_var" function of type
                    "Twig\Node\Expression\FunctionExpression" is deprecated.    
--------------------------------------------------------------------------------

FILE: modules/contrib/views_data_export/views_data_export.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Created patch properly addressing all incompatible classes and functions.
Now Drupal 11 compliant.

Tested in existing build and export functions as designed on D10 and D11.

Fixed in the MR, patches are dead so push fixes to the MR instead.

Successfully tested on Drupal 11 PHP 8.3.

I think it's ready for a 2.x release...

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.6
2. mglaman/phpstan-drupal: 1.3.1
3. palantirnet/drupal-rector: 0.20.3

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.6
2. mglaman/phpstan-drupal: 1.3.1
3. palantirnet/drupal-rector: 0.20.3

Upgrade_status also reports this:

File name Line Error
web/modules/contrib/views_data_export/src/Plugin/views/display/DataExport.php 838 Call to deprecated method setCellValueByColumnAndRow() of class PhpOffice\PhpSpreadsheet\Worksheet\Worksheet: 1.23.0 Use the setCellValue() method with a cell address such as 'C5' instead;, or passing in an array of [$columnIndex, $row] (e.g. [3, 5]), or a CellAddress object.

Thanks, @maxilein, MR!45 now incorporates that change.

Which merge request do we want to merge here?

@steven jones MR!53 does not incorporate the fix on MR!45. MR!45 is the one we should consider for merge.

Great.

Looking at the pipelines on your MR...they are failing because of trying to install with Drupal 11 at the moment.

Ideally we'd have a pipeline for each of our core versions we support, if d.o supports doing such a thing, anyone know?

I've added the automated test for Drupal 10, and now we can see that the Drupal 11 tests are failing because there's not a version of https://www.drupal.org/project/xls_serialization → that's compatible with Drupal 11 yet.

mably → changed the visibility of the branch 3459698-d11_ready to hidden.

rahul17 → made their first commit to this issue’s fork.

I have committed deprecation fixes in MR !53 and also verified functionality in Drupal 10.3 and Drupal 11. Found no error in upgrade status as well. Also verified PHP 8.3 compatibility. Everything looks good to me.

Changing status to needs review. Kindly review and merge changes.

mably → changed the visibility of the branch 3459698-d11_ready to active.

Thanks everyone for pushing this one along. @mably are you able to make a new release of Excel Serialization → module? Then we won't need the awkward workarounds to get the testing to pass.

Excel Serialization is now D11 compatible, 📌 Drupal 11 compatability Active got committed!

xls_serialization 8.x-1.6, compatible with Drupal 11, has been released!

https://www.drupal.org/project/xls_serialization/releases/8.x-1.6 →

steven jones → changed the visibility of the branch 3459698-d11_ready to hidden.

Thanks for everyone's patience here.

Leaving this issue open so we benefit from further input from @Project Update Bot

Ah shoot.

8.x-1.5rc1 isn't compatible with Drupal 9 eh? Because we're using the new FileExists class.

Boo. I'll cut a 8.x-2.0 asap.

You don't need a new major to drop D9 support. But if you decide to do that anyway you might like to take the chance to move to semver and cut 2.0.0

If you want D9 users to be happy ideally you should release 8.x-1.6 that rolls back the breaking change and restore it in 8.x-1.7 with a constraint on D10+. That will give the smoothest update path for all users.

It's not compatible with Drupal 10.2 either, let's get a simple BC layer in.

Merged that BC layer in too.

Leaving this issue open so we benefit from further input from @Project Update Bot

Cut a full release: https://www.drupal.org/project/views_data_export/releases/8.x-1.5 →