Account created on 28 May 2015, almost 10 years ago
#

Merge Requests

Recent comments

πŸ‡¦πŸ‡ΊAustralia mcaddz

The original purpose was to hide Readspeaker from screen readers which setting tabindex=-1 won't do if using screen reader navigation (opposed to keyboard tabbing).

We landed on leaving it as is and letting screen reader users choose to ignore so as not to interfere with keyboard users.

Might be able to set this as 'won't fix' or 'works as designed'?

πŸ‡¦πŸ‡ΊAustralia mcaddz

Attaching patch for composer.patches.json file.

πŸ‡¦πŸ‡ΊAustralia mcaddz

@queenvictoria yes absolutely :)

You could either push to 4026 or create a new 11.x issue fork. Will need tests though.

πŸ‡¦πŸ‡ΊAustralia mcaddz

@queenvictoria it doesn't look like there's any commits in MR 4026 yet.

You might need to rebase your changes against core 9.5.x and upload a patch file here to add to composer.patches.json.

πŸ‡¦πŸ‡ΊAustralia mcaddz

My understanding is we should probably have a config setting that allows the creation of new revisions by default so the user doesn't need to check the checkbox each time.

This patch should demonstrate which borrows from #3261439.

Includes a moderation control handler that forces revisions if content moderation is used.

πŸ‡¦πŸ‡ΊAustralia mcaddz

Adding patch for 11.x.

  • Adds new 'view all taxonomy revisions' permission.
  • Handles 'revert' operation in access control handler.
  • De-pluralises existing permissions that didn't sound right.
πŸ‡¦πŸ‡ΊAustralia mcaddz

mcaddz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia mcaddz

@isalmanhaider no this just relates to the core path_alias module.

πŸ‡¦πŸ‡ΊAustralia mcaddz

Here's the MR in #2 in patch format for use in composer.patches.

πŸ‡¦πŸ‡ΊAustralia mcaddz

MR 15 is working for me on a test site. All looking good.

@ressa I've added a test for this functionality in MR 17. If you or someone else can review we can mark as RTBC?

πŸ‡¦πŸ‡ΊAustralia mcaddz

This has been resolved in the February RS release. Marking as closed.

πŸ‡¦πŸ‡ΊAustralia mcaddz

mcaddz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia mcaddz

RS have advised this should be resolved in the upcoming February release. Date TBC

Production build 0.71.5 2024