Contrib.social

AccessBy* tests use incorrect menu section ids

Open on Drupal.org →
Created on 28 March 2023, over 1 year ago

Problem/Motivation

When reviewing ✨ Display section name on access scheme forms Fixed we discovered a weird bug with the tests where the menu's mid was being used as the section id rather than the actual menu link's id (which is a combination of the menu name and UUID.

The tests just work because the page simply allows it. It doesn't load the menu link at all and simply adds the user/role to an invalid section id happily.

In fact you can put complete garbage in the url and it accepts it! e.g /admin/config/workflow/workbench_access/test/sections/asdasdasd/users works and will associate users and roles with that section id.

We should potentially look at ironing that out properly (which will kinda be done in 3346223 anyway with the new page title callback).

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024