Update script and listen button URL's

Thanks @JoshaHubbers and @bskibinski for getting this moving! I see that @enyug created a patch about the same in ✨ Allow the cdn in listen button link cms manageable Closed: duplicate . So with a basis in that great work I have created a MR for 2.x which updates the script and adds a region token. Feel free to review.

Should it be for 1.x in stead, or perhaps that can be done separately?

Thank you @ressa. We still use the 1.x version because that is the stable version. If this is also fixed in the 2.x version in issue #3326461, I would propose to stick to the 1.x change in this ticket and handle the 2.x changes in the other?

I reviewed the mr. It looks good. Added some small text improvements. And changed the CDN to a select because that is much more userfriendly in this option in my opinion.

Have not tested it in a real live site yet.

Thanks for the improvement @JoshaHubbers. I agree it's better as a dropdown, and it works well for me, tested locally.

Perhaps @bskibinski or someone else can review our collaborative MR?

MR 15 is working for me on a test site. All looking good.

@ressa I've added a test for this functionality in MR 17. If you or someone else can review we can mark as RTBC?

Looking good, nice work on the tests. Just a couple of small changes flagged.

Also in the future @mcaddz - we generally would just use a single MR to contribute to. You can click the Get Push Access button to get access to the fork and then push to the existing branch.

Thanks @mcaddz, but after changes to the code, someone else needs to review them :)

MR 17 is looking good, we can enable automated tests after this is merged :)

sunlix → closed merge request !15

Thanks,

renamed the config key for more clarification.
Added update_hook to initialize the new config key. So no warnings during reading non existend config key from config object should happen. (mostly before first saving the settings form after upgrade)

Thanks @sunlix! Any chance we could get an RC cut for the 2.x branch?

Adding parent issue, it looks like a new release is coming soon :)

Automatically closed - issue fixed for 2 weeks with no activity.