- Issue created by @kim.pepper
- First commit to issue fork.
- Merge request !105653494126 - Moved the file_get_content_headers() to File Entity โ (Open) created by Unnamed author
- ๐ฎ๐ณIndia ramprassad
@Kim, Sure I will update my changes for the MR in sometime and provide an update
- ๐ฎ๐ณIndia ramprassad
@Kim, I have updated the MR with the changes and created a change record for this change https://www.drupal.org/node/3494172 โ . All tests pass.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Left some comments.
- ๐บ๐ธUnited States nicxvan
If you added the needs tests tag to test the deprecation we don't need tests for that.
https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... โ
If it's for something else let me know.
- ๐ฎ๐ณIndia rohan_singh India
+1, I agree with @kimpepper.
Renaming the function name to getDownloadHeaders() sounds better and justifies the functionality implemented.Moving this to needs work.
- ๐ฎ๐ณIndia ramprassad
@Kim, I have changed the method name to getDownloadHeaders().
Moving this to review, please check. - ๐บ๐ธUnited States smustgrave
Small comment on MR
CR needs to be updated for 11.2 alsoMay count as an API change? If yes that section should be updated
Thanks
- ๐ฎ๐ณIndia ramprassad
@kim,@smustgrave: The merge conflicts from the 11.x rebase on this MR has been resolved and I fixed few CI issues related to the 11.x changes in this MR. I had updated the CR related to this change as well. Please check
- ๐บ๐ธUnited States smustgrave
Need rebase.
But typehint can be added to the hook so we donโt need to add to the baseline
- ๐ฎ๐ณIndia ramprassad
@smustgrave, I have made the necessary changes, please check.