🇮🇳India @rohan_singh

@ajay-mallah, As I remember, we had fixed this one during security advisory.

Marking it as closed.

Hi,
I took the latest pull and changes look fine to me.
The issue has been fixed.

Moving it to RTBC.

Hi @phenaproxima,

Getting the same issue. Attaching the screenshot for reference.

Tried running,
rm -rf web/modules/contrib/automatic_updates/package_manager
and installing again.

Getting a different error this time,

Error: Call to a member function getPath() on null in drupal_cms_installer_theme_registry_alter()

Hi,
I have been using this module on one of my sites. Initially, when I first installed the module, it was a bit confusing, and I had to thoroughly review the code to understand its terminologies. After switching to this branch on a fresh Drupal site, I checked the form at /admin/config/people/user-expire, and the fields now seem more intuitive.

Moving it to RTBC.

penyaskito → credited rohan_singh → .

Hi,
I have tested the MR and it looks good to me.
I agree with @pameeela, 'Edit Layout' link should use sentence case.
I am attaching the screenshot for reference.

Hi,
I have raised an MR for the correct branch and hidden the existing MR.

Kindly review.

rohan_singh → changed the visibility of the branch 3496032- to hidden.

Hi,
First and foremost, Issue is raised against 8.1.20
But the MR raised here is against 9.x

Moving back to needs work.

Hi,
I am still not sure what changes are done here, because I can only see a space had been removed.
This won't solve this above stated issue.

Moving this to needs work.

Hi,
Can you please help me with the steps to reproduce this issue?
As per the configuration, the paths key is defined as a sequence, which should return an array.

mapping:
    paths:
      type: sequence
      label: 'Anonymous login page paths.'
      sequence:
        type: string
        label: 'Path'

Thanks!

Hi @phenaproxima,
Thanks for the help.

I have created a separate test file named ContentEditingTest under drupal_cms_starter.
And It passes the pipeline.

Please review.

Hi @phenapromixa, I have modified the test to match your suggestions.
I see the pipeline is still not green, but I cannot see any errors in my local. Can you please check and let me know what is the issue here?

Hi,
I have updated the test coverage as per the requirement.
Kindly review.

Hi @vishal.kadam

First of all, Thank You for the review.
I have pushed the requested changes.

Kindly review.

rohan_singh → changed the visibility of the branch 3485552-captchas-everywhere to hidden.

rohan_singh → created an issue.

Hi @anna d,

Everything looks good overall, but there’s a cspell issue reported in the pipeline.
Since it’s not significant enough to create a separate issue, it would be better to address it here.

Moving to Needs Work.

+1, I agree with @kimpepper.
Renaming the function name to getDownloadHeaders() sounds better and justifies the functionality implemented.

Moving this to needs work.

Thanks for the review @phenaproxima.
I have made the suggested changes.

Kindly review.
Thanks,

I'll look into this.

Hi,
I have disabled the main navigation from the Blog content type and raised an MR.

Please review.
Thanks,

rohan_singh → made their first commit to this issue’s fork.

Hi,

I required the D11 version of this module for one of my projects and have raised an MR for it.
I have tested the changes by exporting nodes categorized by bundle name and importing them using a JSON script.

Please review

Thanks,

rohan_singh → made their first commit to this issue’s fork.

Also, after exploring the issue further, I figured out that this error pops up only during the initial setup.
Clearing the cache and reloading the site fixes the issue.

rohan_singh → created an issue.

Hi,
I have raised an MR to fix the same.

Please review.
Thanks.

Hi, I reviewed the patch provided in #3.
While the issue required updating the variables names, I noticed that the title and action items block are missing after applying the patch.
I've attached screenshots for reference.

Moving it to needs work.

Hi @dinarcon, thank you for the review. I have made the necessary changes needed.

Hi @dinarcon, I have raised an MR. Do let me know if I can help in any other way.
Please review.

Thanks
Rohan Singh

Hi @ahmed.raza, I was able to reproduce the issue and created an MR for the same.
Please review.

Thanks,
Rohan Singh

I'll work on this.

i'll look into this.

Hi, I'm still unsure how to apply this patch. I think there should be separate patches for different recipes.
However, when I tried to apply the patch's changes on my local machine, they did not work.
Attaching a screenshot for more reference.

For more reference on the changes to be made - we should follow https://www.drupal.org/project/drupal_cms/issues/3488706 📌 Switch the node body field back to a text_with_summary field, and hide the summary everywhere it appears Active

Moving to need work.

Hi @dxvargas, I successfully reproduced the listed issues. I have raised a merge request (MR) incorporating the suggested contexts. While this resolves the destination path issue, I noticed that the 'block/ban' link is still present.

I'll look into this.

Hi, I am facing the same issue with using select2 1.15 with bef 7.0.2 on drupal 10.3.6

However when applying the MR on my drupal site.
I am facing an issue.

[ErrorException]                                               
  foreach() argument must be of type array|object, string given 

Hi, I have tested the MR !10. After applying the merge request, the issue no longer occurs. Everything is working as expected.

Thank you!

Hi @trackleft2, I have raised an MR.
Please review.

Thanks
Rohan Singh

I am working on this.

I @izus, please review.

Thanks
Rohan Singh

Hi @matason,
I have created an MR for fixing the issue.
Please review.

Thanks,
Rohan Singh

Hi @cleavinjosh, I have applied the provided MR as a patch and it applied cleanly with no errors. I can confirm that the phpcs issues have been resolved successfully however I am getting some console errors and due to these errors, the module is not working as expected. I am attaching the screenshots below.

rohan_singh → created an issue.

@akalam and @tonibarbera, I have raised a PR for the ECA 2.x support. Kindly review and merge this.

Rohan_Singh → made their first commit to this issue’s fork.

@cburschka @AstonVictor I have created a merge request for removing the state from the channels listing field. Please review.

Rohan_Singh → created an issue.

Hi, I have given a merge request for this issue. Kindly review and merge this.

Rohan_Singh → created an issue.

@anybody @joseph.olstad @mandclu @dragonwize, This issue has been active for a while now. Can anyone of you kindly look into this?

Rohan_Singh → changed the visibility of the branch 3414294-Submitting-form-throws-error to hidden.

Kindly review this MR.

Rohan_Singh → made their first commit to this issue’s fork.

As per the documentation
https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-or-... →

When we are upgrading only the core modules, with using
composer update "drupal/core-*" drush/drush --with-all-dependencies --dry-run

I am getting psr/log issues.
- Root composer.json requires drupal/core-recommended 10.0.11 -> satisfiable by drupal/core-recommended[10.0.11].
- drupal/core-recommended 10.0.11 requires psr/log ~3.0.0 -> found psr/log[3.0.0] but these were not loaded, likely because it conflicts with another require.

Hi @WalkingDexter, I have added a patch to add the message after the module redirects to the requested page. Do let me know if I can help in any other way.

Please review this merge request.

Rohan_Singh → made their first commit to this issue’s fork.

Along with a some similarities in both the modules, there are difference also.Both the modules have separate use cases. I have tried to list down some of the major difference:-

1)In country state and city field module we get the option of more countries(250) whereas in the address module we only have the dataset of 200 countries.

2)The functionality of address module is different(if compared to country,states and city fields). there if we add the address field type while creating a content type, We are asked to insert the information of user(Which is useful if we use it in an E-commerce Platform)(We have the option to make the fields optional) whereas in the country, states and city field module, there is no role of the user information.

3)Address module has an feature to work with the postal codes. It gives you option to include and exclude postal codes(which can be very useful for some cases).

4)In this module the administrator can define the name of state and city anything as that depends upon the administrator.but in the address module one gets everything predefined.

5)When creating a new content of Address field type using address module, after choosing the country there is no drop down for the list of cities. It might not provide a good user experience in some cases.