- Issue created by @hetal.solanki
- 🇮🇳India hetal.solanki
Hetal.Solanki → changed the visibility of the branch 3460744- to hidden.
- Issue was unassigned.
- Status changed to Needs review
9 months ago 7:37am 11 July 2024 - Status changed to Needs work
9 months ago 7:48am 11 July 2024 - 🇮🇳India dev2.addweb
The patch is not applied successfully. I have installed the [ 1.0.1 ] version.
- Status changed to Needs review
9 months ago 8:20am 11 July 2024 - 🇵ðŸ‡Philippines cleavinjosh
Hi,
I provide a patch that fixes some of the phpcs issues. These are the remaining issues.
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraph_locator FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/paragraph_locator/README.md ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------ 6 | WARNING | Line exceeds 80 characters; contains 292 characters 10 | WARNING | Line exceeds 80 characters; contains 155 characters 11 | WARNING | Line exceeds 80 characters; contains 151 characters 12 | WARNING | Line exceeds 80 characters; contains 186 characters 13 | WARNING | Line exceeds 80 characters; contains 189 characters 39 | WARNING | Line exceeds 80 characters; contains 85 characters ------------------------------------------------------------------------------------------------ Time: 133ms; Memory: 10MB
Please review.
Thank you.
- Status changed to RTBC
9 months ago 8:03am 18 July 2024 - 🇮🇳India bhaveshdas
I have tested Phpcs issues MR 1 and it is working properly with no errors found.
I will move it forward to RTBC.Thankyou!
- Status changed to Needs work
7 months ago 5:58am 9 September 2024 - 🇮🇳India diwakar07
Thanks for the work on this.
Please resolve merge conflicts.
- Status changed to Needs review
7 months ago 4:40am 10 September 2024 - 🇵ðŸ‡Philippines cleavinjosh
Hi @diwakar07,
Please review MR!1. Thank you.
- 🇮🇳India rohan_singh India
Hi @cleavinjosh, I have applied the provided MR as a patch and it applied cleanly with no errors. I can confirm that the phpcs issues have been resolved successfully however I am getting some console errors and due to these errors, the module is not working as expected. I am attaching the screenshots below.
- 🇮🇳India kulpratap2002
@rohan_singh I tried to solve the errors that are present in the console but the error is due to the capital 'TRUE' & 'FALSE' in js file, if we write true and false instead of TRUE and FALSE the error goes away, but if we write 'true' and 'false' it is showing phpcs error and it is giving console error, and there is one more issue is that it is not deleting the paragraph because there is one function is missing ( paragraphParent() ) in the ParagraphLocator.php.