🇮🇳India @Diwakar07

Hi,
Created an MR to log the view export events based on the value of a key set in settings.php file.

For enabling the logging of the view export event, add $settings['data_export_logging'] = TRUE; in your settings.php file.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Diwakar07 → made their first commit to this issue’s fork.

Hi,

Created an MR for running gitlab ci tests for the module.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
I have fixed the remaining cspell warnings.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,

I reviewed MR !7.
It successfully fixes the phpstan errors, the gitlab ci pipeline passes.
The changes are following the dependency injection.
Looks good to me.

Moving to RTBC.

Hi,

I reviewed MR !13.
PHP_CodeSniffer job is passed/green in the Gitlab CI reports.
Looks good to me.

Moving to RTBC.

Hi @kalpanajaiswal,

I have reviewed the MR !9.
The Readme file is not following the readme template standards for contributed modules.
Can we try and follow the README.md → standards ?

Moving to NW.

Hi @acbramley,

The gitlab ci file looks good to me.
We can have separate tickets to fix the issues in the pipeline.

Moving to RTBC.

Hi,

I have created an MR for fixing the cspell issues.
Please review.

Diwakar07 → created an issue.

Hi @joegraduate,

I reviewed the MR !8. It successfully fixes the phpstan issues in the pipeline.
Looks good to me.

Moving to RTBC.

Hi @Arijit Acharya,
I reviewed the MR !12.

The file follows the README.md template standards and adds a README.md file for the module replacing the README.txt.
Looks good to me.
Moving to RTBC.

All the tests in the pipeline are green.
Looks good to me.

Moving to RTBC.

Hi @charlliequadros,

I reviewed the MR !15.
Looks good to me, It adds a help page for the module.
Just a small typo in the help page description, please update theme\'s configuration to theme's configuration
Attached is the SS for reference.

Moving to NW.

Hi @joegraduate,

I reviewed the MR, looks good to me.
We can have separate issues for fixing the tests.

Moving to RTBC.

Hi @Arijit Acharya,
I have reviewed MR !12 and here are some feedback.

The Project introduction section is missing a link to the project page and the issue queue of the module.
Please refer to Readme template → and update the Project name and introduction section.
The Table of contents section is not aligned according to the README file contents.
The Maintainers section is missing from file, but added in Table of contents

Moving to NW.

Hi,
Created an MR to add the gitlab ci file.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
Created an MR to fix the cspell issues.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi @batigolix,
Thanks for the update.
But I still do not see any credit towards my name for this issue.

Hi, @batigolix
Thanks for the update and for closing this issue.
However, I noticed that there was no credit given for resolving this issue.
Is there something we are missing?

Hi,
I have updated the MR accordingly. Please review.

Hi @kenyoOwen,
According to the Readme template → ,

Links should have a meaningful link text, for example:
[Drupal](https://www.drupal.org/) (i.e. not just the URL)

Moving to Needs review.

Hi,
The cspell errors are fixed by the MR.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Moving to Needs review, since phpcs, eslint, and cspell have been fixed in the MR.
Please review.

Hi,
I have updated the MR according to the review.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
CSPELL job is passed with no warnings.
Please review.

Hi,
I have updated the readme file according to Readme template → .
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
Enabled Gitlab CI tests for the module.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
Created an MR for fixing this issue.
Please review..

Hi @kenyoOwen,
I have updated the same.
Please review.

Hi @szt,
I was able to reproduce the issue.
Adding the steps for the same:
1. Install, enable the module.
2. Go to admin/config/people/accounts page.
3. Check/Enable the Require email verification when a visitor creates an account option.
4. Update the Minimum password length field as required.
5. Save the configuration, it gives an error: password_length' is not a supported key
Attached is the screenshot for the same.

Moving to NW.

Hi @szt,
I am unable to reproduce the error.
Steps followed:
1. Installed, enabled the module.
2. Updated the minimum password length to 5 characters from the admin/config/people/accounts page.
3. Tried creating a new account.
4. Worked as designated.

Attaching screenshot for the same.

Please let me know if there is any other configuration step that I'm missing.

Hi @Rajeshreeputra, Taran2L
I have updated the list of ignored words and removed the some words(the ones that were used in README and for providing examples of configuring the module) that does make any change to the working of the module.
I think rest of the words are required to be ignored.
Please review.

Hi, all the Gitlab checks are green now.
Please review.

cspell job is still failing.
Please check: https://git.drupalcode.org/project/reroute_email/-/jobs/1664623

Diwakar07 → made their first commit to this issue’s fork.

Hi @ThuleNB,
I am not able to reproduce the error.
Followed the steps, still able to create a new user account after changing the register button text.

Hi,
I have updated the MR based on the changes suggested.
Please review.

Hi @arnoldbird, @Graber
I have updated the configuration section for the README.md file based on the feedbacks.
Please review.

Hi @kenyoOwen,
There was an issue with the encoding of the README.txt file.
Deleted the README.txt file and created a new README.md file. Now the MR looks good.
Please review.

Hi @kenyoOwen,
Thanks for the feedback.
I have updated the MR accordingly. Please review.

Hi @tim-diels ,
I have created an MR for fixing the cspell issues.
Please review.

Hi @eelkeblok,
Created an MR for cspell issues. cspell check is passing now.
Can you please elaborate what needs to be done next here ?

Diwakar07 → made their first commit to this issue’s fork.

Hi @thejimbirch,
I have updated the MR, fixing the phpcs issues.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi @apaderno,
I have updated the MR based on the suggestion.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi kenyoOwen,
I have updated the README.md according to the changes suggested.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi, I have created an MR for the missing README.md file.
Updated the README file based on the suggestion by @kenyoOwen.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Thanks for the feedback @thejimbirch.
I have added the words that were failing as exceptions to the ci yml file.
Please review.

I have fixed the issues as stated above by @kenyoOwen .
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Added missing t() function and tested the file through phpcs.
Please review the MR.

Diwakar07 → made their first commit to this issue’s fork.

Fixed the same and created a MR.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

I have fixed the naming convention and updated the class description.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

I have fixed the errors and warnings reported by phpcs.
Created an MR for the same.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
I have updated the Comment Notify interface page accordingly.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi, Thanks for the suggestions.
I have updated the help page accordingly. Adding the screenshots for the updated help page.
Please review.

Hi, I have updated the Readme.MD file according to latest Drupal standards.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

I have fixed the errors reported by phpcs.
Please review.
Attached is the screenshot of the file extensions checked by phpcs.

Diwakar07 → made their first commit to this issue’s fork.