🇮🇳India @diwakar07

The MR !26 looks good.
@atul_ghate Can you please resolve the merge conflicts?
Also kindly update the commit message to use the correct issue ID.

Thanks.

Thanks @timohuisman,
The MR !3 looks good to me.

Moving to RTBC!
Thanks.

Hi @timohuisman,

I reviewed MR !3. The gitlab CI file looks good but the CI tests are not running.
Please updated the file name to .gitlab-ci.yml for the CI tests to run.

Moving to NW.
Thanks.

Thanks for the work on this.
Merged.

diwakar07 → made their first commit to this issue’s fork.

Thanks for the work on this.
Merged.

diwakar07 → made their first commit to this issue’s fork.

Hi,
Made the changes to hide the message, when "Admins cannot set a password when creating or editing an account." is selected.
Please review.

Thanks & regards.

Hi,
I was able to reproduce the above mentioned bug.
I agree that hiding the message will eliminate the chances of confusion, when 'Admins cannot set a password when creating or editing an account.' is selected, as there is no option add a password when this option is selected.

Hi @joshi.rohit100,
I tried to reproduce the issue.
So, whenever adding a "<" without the respective ">", maxlength counter tried to add a closing tag(), but was skipping to close the previously opened "<" tag.
Updated the JS to add the ">" in case there is an open "<".
Now the counter looks good to me.
HTML tags are not considered as characters.

Please review.

walkingdexter → credited diwakar07 → .

Thanks for the work on this.

Please resolve merge conflicts.

Looks, Good.

Thanks, merged.

Hi,
I reviewed MR !191.
It fixes the issue and the changes look good to me.

Moving to RTBC!

Thanks,
Diwakar.

Hi,
I have reviewed MR !3.

It successfully adds an option to configure the OTP length and OTP resend duration through the config form.

Looks good to me.
Moving to RTBC!

Thanks.

@Sahana _N
Please add a row in the ServiceEndpointListBuilder.php to render the description message in the table of all service endpoints.

Thanks.

Hi,

I have reviewed MR !15.
It successfully adds a description textarea for the service endpoint, but it misses the description message in the Table of all Service Endpoints.

Attached is the SS for reference.

Hi,

Reviewed MR !17.
It successfully adds a configure link to the module Extend Page.
Attached is the SS for reference.

Looks good to me.
Moving to RTBC!

The gitlab pipeline is green.
The changes in MR !5 fixes the phpstan error.

Looks good to me.
Moving to RTBC!

Thanks.

Able to reproduce the issue in Drupal 10.3.0.
I agree with #10.

Hooks like hook_views_post_execute() or hook_views_pre_render() tend to update the #items_per_page key of the view but still renders the default pager value set in the view, rather than using the number set in custom code.
When using hook_views_query_alter(), the pager successfully gets updated.

Thanks.

Hi,
Added a column in the db to store the user delete action type.
Please review.

Thanks.

Hi,

I have reviewed MR !24, the gitlab file added follows the Gitlab template standards.
We can have separate tickets to fix the phpcs, cspell, etc. warnings.

This looks good to me.
Moving to RTBC!

Thanks.

Hi,

I reviewed MR !118 on drupal 10.3.0 and paragraphs 1.17, it successfully fixes the issue.
It adds an option in the paragraph type edit form to Enable/Disable

Save paragraph instances, even when fields are empty

, by default it is enabled.

On disabling this option, I was able to save the node by adding a blank paragraph type, and no label was rendered for the blank paragraph type added on node.
Attached are the SS for references.

This looks good to me.
Moving to RTBC!

Thanks.

Hi,
Created an MR to update the gitlab ci testing.
Followed the gitlab ci standards from Gitlab Template

Please review.
Thanks.

Diwakar07 → made their first commit to this issue’s fork.

Hi,

Reviewed the patch.
It applies successfully solving the issue mentioned.
Adds a title to the user login form.
Looks good to me.
Moving to RTBC!

Thanks.

Hi,
Reviewed MR !8.

The gitlab ci file added follows the proposed standards. We can have separate tickets for fixing the phpcs and cspell warnings.
Looks good to me.
Moving to RTBC.

Thanks.

Please review.

Hi @eelkeblok,

Configured the cspell job to break when it does not pass.
Please review.

Diwakar07 → created an issue.

Hi,

Created MR !18 that fixes the cspell issues.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Diwakar07 → made their first commit to this issue’s fork.

Hi @batigolix,

I understood the fact that you missed the crediting step.
I later got to learn that it is up to the maintainer to decide whether to credit people or not for working on an issue.

Appreciate the time you spent going back and crediting people for their work on this issue.
Hope my work on this issue was helpful, and I did not trouble much with the credit comments.

Received the credit for the issue.

Thanks,
Diwakar.

Hi,

I reviewed MR !91.
It successfully adds a new permission Edit entity sitemap settings and allows the user roles with this permission to configure sitemap settings for the specific entity on the Node itself.

But even after allowing a node to be indexed, we still need to rebuild and generate the updated sitemap from the admin interface for the changes to take affect.
If you are okay with this dependency, then this solution should be good otherwise we should stick to the base permission provided as default by the module itself.

Attached are the SS for reference.

Updated accordingly.

Thanks,
Diwakar.

Thanks for the review @Anybody.
Fixed the remaining issues, and updated the MR based on comments.

Thanks,
Diwakar.

@Anybody
Not an issue, for not being credited for the same.

I have committed the changes in the issue fork.
Please let me know if you want me create an MR for this or let it be ?

Thanks,
Diwakar.

Diwakar07 → made their first commit to this issue’s fork.

Hi @joegraduate,
Reviewed MR !10. Changes looks good to me. Fixes the ci pipeline errors.

It aligns with the latest changes in the ConfigStorageTestBase::testInvalidStorage() function in core 10.3.x.
Moving to RTBC!

Hi,
Created an MR to log the view export events based on the value of a key set in settings.php file.

For enabling the logging of the view export event, add $settings['data_export_logging'] = TRUE; in your settings.php file.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Diwakar07 → made their first commit to this issue’s fork.

Hi,

Created an MR for running gitlab ci tests for the module.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
I have fixed the remaining cspell warnings.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,

I reviewed MR !7.
It successfully fixes the phpstan errors, the gitlab ci pipeline passes.
The changes are following the dependency injection.
Looks good to me.

Moving to RTBC.

Hi,

I reviewed MR !13.
PHP_CodeSniffer job is passed/green in the Gitlab CI reports.
Looks good to me.

Moving to RTBC.

Hi @kalpanajaiswal,

I have reviewed the MR !9.
The Readme file is not following the readme template standards for contributed modules.
Can we try and follow the README.md → standards ?

Moving to NW.

Hi @acbramley,

The gitlab ci file looks good to me.
We can have separate tickets to fix the issues in the pipeline.

Moving to RTBC.

Hi,

I have created an MR for fixing the cspell issues.
Please review.

Diwakar07 → created an issue.

Hi @joegraduate,

I reviewed the MR !8. It successfully fixes the phpstan issues in the pipeline.
Looks good to me.

Moving to RTBC.

Hi @Arijit Acharya,
I reviewed the MR !12.

The file follows the README.md template standards and adds a README.md file for the module replacing the README.txt.
Looks good to me.
Moving to RTBC.

All the tests in the pipeline are green.
Looks good to me.

Moving to RTBC.

Hi @charlliequadros,

I reviewed the MR !15.
Looks good to me, It adds a help page for the module.
Just a small typo in the help page description, please update theme\'s configuration to theme's configuration
Attached is the SS for reference.

Moving to NW.

Hi @joegraduate,

I reviewed the MR, looks good to me.
We can have separate issues for fixing the tests.

Moving to RTBC.

Hi @Arijit Acharya,
I have reviewed MR !12 and here are some feedback.

The Project introduction section is missing a link to the project page and the issue queue of the module.
Please refer to Readme template → and update the Project name and introduction section.
The Table of contents section is not aligned according to the README file contents.
The Maintainers section is missing from file, but added in Table of contents

Moving to NW.

Hi,
Created an MR to add the gitlab ci file.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
Created an MR to fix the cspell issues.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi @batigolix,
Thanks for the update.
But I still do not see any credit towards my name for this issue.

Hi, @batigolix
Thanks for the update and for closing this issue.
However, I noticed that there was no credit given for resolving this issue.
Is there something we are missing?

Hi,
I have updated the MR accordingly. Please review.

Hi @kenyoOwen,
According to the Readme template → ,

Links should have a meaningful link text, for example:
[Drupal](https://www.drupal.org/) (i.e. not just the URL)

Moving to Needs review.

Hi,
The cspell errors are fixed by the MR.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Moving to Needs review, since phpcs, eslint, and cspell have been fixed in the MR.
Please review.

Hi,
I have updated the MR according to the review.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
CSPELL job is passed with no warnings.
Please review.

Hi,
I have updated the readme file according to Readme template → .
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
Enabled Gitlab CI tests for the module.
Please review.

Diwakar07 → made their first commit to this issue’s fork.

Hi,
Created an MR for fixing this issue.
Please review..

Hi @kenyoOwen,
I have updated the same.
Please review.

Hi @szt,
I was able to reproduce the issue.
Adding the steps for the same:
1. Install, enable the module.
2. Go to admin/config/people/accounts page.
3. Check/Enable the Require email verification when a visitor creates an account option.
4. Update the Minimum password length field as required.
5. Save the configuration, it gives an error: password_length' is not a supported key
Attached is the screenshot for the same.

Moving to NW.

Hi @szt,
I am unable to reproduce the error.
Steps followed:
1. Installed, enabled the module.
2. Updated the minimum password length to 5 characters from the admin/config/people/accounts page.
3. Tried creating a new account.
4. Worked as designated.

Attaching screenshot for the same.

Please let me know if there is any other configuration step that I'm missing.

Hi @Rajeshreeputra, Taran2L
I have updated the list of ignored words and removed the some words(the ones that were used in README and for providing examples of configuring the module) that does make any change to the working of the module.
I think rest of the words are required to be ignored.
Please review.