- Issue created by @andreastkdf
- Merge request !92#3441488: add new Edit entity sitemap settings permission → (Closed) created by andreastkdf
- last update
12 months ago 32 pass - Status changed to Needs review
12 months ago 10:45am 17 April 2024 - last update
12 months ago 32 pass - last update
12 months ago 5 pass, 1 fail - last update
9 months ago 32 pass - 🇮🇳India diwakar07
Hi,
I reviewed MR !91.
It successfully adds a new permissionEdit entity sitemap settings
and allows the user roles with this permission to configure sitemap settings for the specific entity on the Node itself.But even after allowing a node to be indexed, we still need to rebuild and generate the updated sitemap from the admin interface for the changes to take affect.
If you are okay with this dependency, then this solution should be good otherwise we should stick to the base permission provided as default by the module itself.Attached are the SS for reference.
- Status changed to RTBC
9 months ago 9:01am 2 July 2024 - Assigned to gbyte
- Status changed to Needs review
7 months ago 4:35pm 13 September 2024 - 🇷🇺Russia walkingdexter
I'm not sure this change is necessary. A similar result can be obtained by overriding the
simple_sitemap.form_helper
service in your custom module. But let's take a second opinion. - 🇫🇮Finland Alexander Tallqvist
I've also tested this solution - working as expected (and IMO the right approach).
- 🇷🇺Russia walkingdexter
Oops, just realized that we already have an issue for this.