- Issue created by @pameeela
- Merge request !315Issue #3493948: Set the email provided by user to site email. → (Merged) created by diwakar07
- 🇮🇳India diwakar07
Hi,
Created an MR to update the site email to the email provided by the user during site setup.Please review.
- 🇺🇸United States phenaproxima Massachusetts
That looks legitimate but I think you might need to update some test coverage... (I suspect that the tests in project_template are failing because they are testing the site email).
- 🇮🇳India shalini_jha
I Have checked the pipeline failure & updated the existing code for mail test. now pipeline is green and other feedback is addressed. so moving this NR. Kindly review.
- 🇺🇸United States phenaproxima Massachusetts
Looks pretty good to me, just a few points of cleanup.
- 🇮🇳India shalini_jha
I Have addressed all the mentioned feedback, and moving this for your review.
- 🇺🇸United States phenaproxima Massachusetts
I think that looks great. I made some very, very minor changes and will commit when tests pass.
-
phenaproxima →
committed 1abe8be9 on 1.x authored by
diwakar07 →
Issue #3493948 by shalini_jha, diwakar07, phenaproxima: Set the site...
-
phenaproxima →
committed 1abe8be9 on 1.x authored by
diwakar07 →
-
phenaproxima →
committed 8106a6c9 on 1.0.x authored by
diwakar07 →
Issue #3493948 by shalini_jha, diwakar07, phenaproxima: Set the site...
-
phenaproxima →
committed 8106a6c9 on 1.0.x authored by
diwakar07 →