Problem since rc11 with Action buttons

Did you check if

a) This problem exists on the latest dev release
b) This MR fixes it? 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review

Thanks

Hello,

Thanks for your reply.

Indeed, the problem exists on the latest dev release, and MR #3463796 does not fix it.

Can you check if the latest changes form 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review do address this issue?

Hello, I apply a patch with the latest changes and it's the same, sorry.

I'm having the same issue: updating past RC10 makes submit buttons on node edit forms disappear. Upon closer inspection, I noticed that at the end of GinContentFormHelper->formAlter(), $form['actions] is still populated, but in node-edit-form.html.twig, form.actions is NULL.
I didn't experience this issue with other projects I updated to this version, so I'm fairly certain it's some weird interaction with another module.
I'm just going to pin it to RC10 for this project for now, I'll try to find some more time to look into what's going on.

@seutje please check the linked issue and MR I mentioned above

This is a possible solution: https://www.drupal.org/project/gin/issues/3488499 🐛 drupal_static data will not change each time you set it which breaks integrations like Simple Multistep Active

I was able to reproduce this and fixed it as part of 📌 Improve sticky actions implementation Active . Please test MR!536 and let us know if that fixes the issue for you as well.

Note: you don't need to create a patch for testing this. You can either check out the branch of that MR or you use https://git.drupalcode.org/project/gin/-/merge_requests/536.diff as your patch. This is the best way for testing, as long as you don't do that in production, as that patch can change over time, until it will be finally merged.

Hi,
I was able to reproduce the issue.
Applied the MR !536.
The MR successfully fixes the issue. It adds a "Save" button on the Step 2 of the form replacing the incorrect "Next" button.

Although I noticed that the "Next" button in the Step 1 of node add form is shown inside the more actions dropdown, but the "Save" button is shown by default as a normal button. This felt inconsistent to me while adding content.
If we are okay with the button positions, this seems to be good.

Attached are the SS for reference.
Moving to RTBC for now.

Thanks for your feedback and tests. Yes, the next button is not treated as a primary button. I would defer that to the simple_multistep module to mark such buttons as primary if they want them to show as such.

I'm marking this as fixed and grant issue credits, as the fix will soon be committed from the related issue then.

Thanks everyone for your help.

Automatically closed - issue fixed for 2 weeks with no activity.