Improve sticky actions implementation

This issue is dealing with problems with the action buttons as well

https://www.drupal.org/project/gin/issues/3488499 🐛 drupal_static data will not change each time you set it which breaks integrations like Simple Multistep Active

please add more details so i can understand clearly and update the step to reproduce (if any).

We're aiming to address all the related issues in this single MR with the objective to get them all tested and fixed by this single MR. This makes it easier to test for all the reported issues with the action buttons in context of each other. That should avoid new regressions.

Hi,

We tested it on our Drupal 10.3, on any entity form we get the following error:

It fails on media library modal, and entity browser-

  }, Drupal.ginStickyFormActions = {
    init: function(context) {
      const newParent = document.querySelector(".gin-sticky-form-actions");
      newParent && (context.classList?.contains("gin--has-sticky-form-actions") && context.getAttribute("id") && this.updateFormId(newParent, form),

@eduardo

We tested it on our Drupal 10.3, on any entity form we get the following error:

Thanks for testing. I've pushed a fix for the JS error, can you have another look? Thank you!

We tested the edit node form and the entity modals and seem to work.
We will update the changes and wait for CI results.
Thank you!!

After running the entire behat suite, the tests are stable with the Gin version dev and the patch from the merge request, we recovered the step And I press the "Save" button that failed on version rc14, so from our side, the change seems stable.

Can this be RTBC?

RTBC!

RTBC +1!

Hi,
Reviewed the sticky actions implementation and it looks great and consistent for entity add/edit forms as well as config forms, it adds the action buttons in the sticky header successfully.
Added some SS for reference.

I have reviewed 3 blocker issues and moved them accordingly, So far the MR looks good to me.
Issues reviewed:
https://www.drupal.org/project/gin/issues/3468961 🐛 Problem since rc11 with Action buttons Active
https://www.drupal.org/project/gin/issues/3488499 🐛 drupal_static data will not change each time you set it which breaks integrations like Simple Multistep Active
https://www.drupal.org/project/gin/issues/3486966 🐛 gin_form_after_build does not transfer #access to sticky actions menu Active

RTBC +1
Thanks.

RTBC +1

Adding another related issue.

Thanks everyone 🤝🙇