- Issue created by @poker10
- Merge request !333Issue #3494066: Added simple xml sitemap default for events. → (Merged) created by diwakar07
- 🇮🇳India diwakar07
Hi,
Created an MR to add Simple XML Sitemap defaults for Event content type.
It successfully adds 'Events' to be included in/admin/config/search/simplesitemap/entities
.Please review.
- 🇺🇸United States phenaproxima Massachusetts
This appears to be failing tests for legitimate reasons: https://git.drupalcode.org/issue/drupal_cms-3494066/-/jobs/3740413#L100
- 🇺🇸United States phenaproxima Massachusetts
Assigning to Jim for input.
The sitemap is also part of our SEO offerings, rather than any one content type, so switching track.
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
While this is an SEO feature, ultimately, it needs to end up in the Events recipe.
- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
Reviewed. Looks okay from a code perspective, but needs a couple of changes. This will also need a change record; see https://git.drupalcode.org/project/drupal_cms/-/wikis/Committer-Info/Cha... for a template of what that should look like/instructions. You can add a change record at https://www.drupal.org/node/add/changenotice?field_project=3466967&field... → .
- 🇺🇸United States phenaproxima Massachusetts
Looks good to me. Assigning to SEO lead @thejimbirch for sign-off/RTBC.
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Looks good, thank you for the contribution!
Marking as RTBC.
- 🇺🇸United States phenaproxima Massachusetts
Actually, one piece of feedback didn't get resolved here. From #12:
Additionally, any composer.json file that lists the Events recipe as a dependency will need to have its version bumped. In this case, I think that's only project_template/composer.json. So in that file, you'll need to change this line:
"drupal/drupal_cms_events": "^1"
to this:
"drupal/drupal_cms_events": "^1.0.3"
-
phenaproxima →
committed 8331cb7e on 1.x authored by
diwakar07 →
Issue #3494066 by diwakar07, prabha1997, phenaproxima, thejimbirch,...
-
phenaproxima →
committed 8331cb7e on 1.x authored by
diwakar07 →
-
phenaproxima →
committed 118d6aa6 on 1.0.x authored by
diwakar07 →
Issue #3494066 by diwakar07, prabha1997, phenaproxima, thejimbirch,...
-
phenaproxima →
committed 118d6aa6 on 1.0.x authored by
diwakar07 →
- 🇺🇸United States phenaproxima Massachusetts
Merged into 1.x and ported to 1.0.x. Thanks all!
-
phenaproxima →
committed c547c564 on 1.0.x
Revert "Issue #3494066 by diwakar07, prabha1997, phenaproxima,...
-
phenaproxima →
committed c547c564 on 1.0.x
-
phenaproxima →
committed cc19386c on 1.x
Revert "Issue #3494066 by diwakar07, prabha1997, phenaproxima,...
-
phenaproxima →
committed cc19386c on 1.x
- 🇺🇸United States phenaproxima Massachusetts
After some discussion with @thejimbirch, I have reverted this and am closing it as a duplicate, in favor of the lighter and more complete approach outlined in #3494070-8: Add Simple XML Sitemap defaults for content types, menu and vocabulary → .
I will transfer credit to that issue.