Cape Cod, Massachusetts
Account created on 7 March 2013, over 12 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch created an issue.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Suggestions added, all threads resolved.

I added the null possibility to the change record, and am moving this back to RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

This is to update the documentation, not a duplicate.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks for fixing that. Since it is a bug, it doesn't need a change record. I will add an issue to update our documentation when this lands.

Marking as RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

PHPstan doesn't like this:

 ------ ---------------------------------------------------------------------- 
  Line   core/modules/layout_builder/src/Plugin/ConfigAction/AddComponent.php  
 ------ ---------------------------------------------------------------------- 
  96     Undefined variable: $value                                            
         🪪 variable.undefined                                                 
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 1 error    
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Looks great, Love the additional test and the comment updates.

I added a draft change record and am moving to RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I added a merge request that calls out to a forked repo of the the e0ipso/schema-forms which has the update dependency justinrainbow/json-schema: ^5.2 || ^6.3.

I was able to test this by adding the MR branch as a repository.

composer config repositories.sdc_display '{"type": "package", "package": {"name": "drupal/sdc_display", "version": "2.0.0-beta4", "type": "drupal-module", "source": {"url":
  "https://git.drupalcode.org/issue/sdc_display-3540006.git", "type": "git", "reference": "3540006-e0ipsoschema-forms-requires-an"}, "require": {"php": ">=8.1", "kanopi/schema-forms": "^v2.5.2",
  "drupal/cl_editorial": "^2.0@rc || ^3.0@rc"}}}'

Which gave me the following (Note the repo must be before the normal Drupal one):

    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "drupal/sdc_display",
                "version": "2.0.0-beta4",
                "type": "drupal-module",
                "source": {
                    "url": "https://git.drupalcode.org/issue/sdc_display-3540006.git",
                    "type": "git",
                    "reference": "3540006-e0ipsoschema-forms-requires-an"
                },
                "require": {
                    "php": ">=8.1",
                    "kanopi/schema-forms": "^v2.5.2",
                    "drupal/cl_editorial": "^2.0@rc || ^3.0@rc"
                }
            }
        },
        ...

The actual module needs to be tested to make sure everything still works as expected.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

ok, thank makes sense. I was thinking improvements to the config checkpoint system would be good to call out, but agree this is more of a bug than an improvement. Removing.

🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks @breidert ! We have this in the SEO Tools recipe already in Drupal CMS from the Real Time SEO for Drupal module. That module analyzes the content of the page and runs it through the yoast,js library. It would be great if we could use that for additional SEO analysis to keep the data architecture what we already have.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

The changes you've made so far look great.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks for the ideas Marcus!!!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Marcus created Create Plugin Action for Recipes to check for installed default provider Active as an idea for this. It won't solve core's issue, but wanted to add it here so folks are aware/

🇺🇸United States thejimbirch Cape Cod, Massachusetts

MR added that removes the extra line.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch created an issue.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

This fixed the phpstan errors. The remaining phpcs error in the mkdocs yaml is unrelated.

Moving to RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

OH, nevermind, there is an issue for that at 🐛 Schema mismatch on Settings form Active .

Moving this to RTBC as having this file in the module from the get go will stop people from copying it into their recipes, and allow for Config Actions to be done on it immediately.

Thanks!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

@breidert the linked presentation is not open to the public and requires requesting access. Consider changing that?

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch created an issue.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

We're going to park this for @alexpott to review.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Updated issue summary.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

We got @berdir's blessing in this slack thread.

The original command change record has been updated to reflect these additions.

Marking as RTBC. Go team default content!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I added the followup.

Exporting Content should allow for excluding fields Active

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Great comments in the code, all threads resolved, doesn't need a change record per #5.

Moving to RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I created a MR with the change. Added Needs tests tag is someone wants to update/add a test for this.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Could you include/update a test for the various values it could be?

🇺🇸United States thejimbirch Cape Cod, Massachusetts

MR added that

1. Removes the config folder
2. Removes the empty parameter
3. Removes the key module from the recipe as we don't require the key module. (Unrelated, but we discussed)

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch created an issue.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Composer platform dependencies allow dependencies to be run as virtual packages. Since these packages don't exist, they can't be unpacked.

The fix in the unpack command uses Composer’s method of checking for platform requirements, and skips them if they are platform requirements. A test was also added replicating the bug.

Since this is a bug, we'd love it if this could also be back ported to 11.2.

Marking as RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Looks lovely! And awesome new functionality in Project Browser! Thanks!

🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Project browser reads the extra info here:

https://git.drupalcode.org/project/project_browser/-/blob/2.1.x/src/Acti...

Drupal CMS issue to add tasks

https://www.drupal.org/project/drupal_cms/issues/3513758 Add follow-up tasks to recipes that can use them Active

Change record where is was added.
https://www.drupal.org/node/3504056

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I assume multiple commands will add a layer of complexity and make it harder to maintain the code in the long run. Like if/when we add export all entities of a bundle, would you have to add that option to both commands? IMHO, I feel like the single command with options would be the easiest to grok for recipe authors.

The examples should be like this since it currently requires that you give it a single entity ID.

# Export a node to a directory
drupal content:export node 4 --dir=...

# Export a node and its dependencies to a directory
drupal content:export node 4 --dir=... --with-dependencies

# Possible future state: Export all tags terms to a directory
drupal content:export taxonomy_term --bundle=tags --dir=...

# Possible future state: Export all tags terms and their dependencies to a directory
drupal content:export taxonomy_term --bundle=tags --dir=... --with-dependencies
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Merge request added that updates the options to standard and hd, and sets the default as standard.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Great job! Merging and will cut a new release.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I think you uploaded the wrong screenshot.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I reviewed and made a minor suggestion. Leaving as needs review for someone more technical than I to review.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Excellent comments throughout the tests. Very clear and concise. Moving to RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Yes, that issue fixed the underlying problem.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to the Default content system.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks for the explanation, I will try to be more cognizant of that in the future.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving it back because the test coverage would need to go into core.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to the recipes initiative project where the documentation lives.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

This was a new site spinup on 11.2 for an internal demo. It's been buggy, so it could be something unrelated.

But my unusual thing here is that I only have Gin as the front end and admin theme.

Steps to replicate

drush si minimal -y
composer require drupal/gin drupal/drupal_cms_ai
drush uli
Visit /admin/appearance
Set Gin as the default theme
Set Default theme as the Administration theme
Save
drush recipe ../recipes/drupal_cms_ai
🇺🇸United States thejimbirch Cape Cod, Massachusetts

If I manually create the block and export the config, it looks like this. Most of the additional settings are the default values.

langcode: en
status: true
dependencies:
  module:
    - ai_chatbot
  theme:
    - gin
id: ai_chatbot
theme: gin
region: content
weight: 0
provider: null
plugin: ai_deepchat_block
settings:
  id: ai_deepchat_block
  label: 'Drupal Agent Chatbot'
  label_display: visible
  provider: ai_chatbot
  ai_assistant: drupal_agent_assistant
  bot_name: 'Drupal Agent'
  bot_image: /core/misc/druplicon.png
  use_username: 1
  default_username: User
  use_avatar: 1
  default_avatar: /core/misc/favicon.ico
  first_message: 'Hello! How can I assist you today?'
  stream: 0
  toggle_state: remember
  width: 400px
  height: 500px
  placement: bottom-right
  show_structured_results: false
  show_copy_icon: true
  collapse_minimal: false
  style_file: 'module:ai_chatbot:bard.yml'
  verbose_mode: false
visibility: {  }
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Is the block is created using the placeBlockInAdminTheme config action?

    block.block.ai_chatbot:
      placeBlockInAdminTheme:
        region:
          gin: content
          claro: content
        default_region: content
        plugin: ai_deepchat_block
        settings:
          id: ai_deepchat_block
          label: 'Drupal Agent Chatbot'
          label_display: '0'
          provider: ai_chatbot
          ai_assistant: drupal_agent_assistant
          bot_name: 'Drupal Agent'
          stream: 0
          default_avatar: /core/misc/druplicon.png
          first_message: 'Hello! How can I assist you today?'
          show_structured_results: 1

ai_chatbot is a submodule of the ai module. It has no config entities, nor does the ai module.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch created an issue.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Not if we add DrupaCon Europe 2026, and North America 2027 nodes when they are announced.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

How about we set a precedent to have default content for any upcoming DrupalCons? That is assuming the event recipe is staying in Drupal CMS.

DrupalCon Vienna 2025
14 October 2025 - 17 October 2025

DrupalCon Chicago 2026
23 March 2026 - 26 March 2026

DrupalCon Nara 2025
17 - 19 November 2025

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I am terrible at CSS today, and need to have this looking ok for a demo, so I made MR-2 that has a badge styling in the bottom right.

Also uploading patch of the MR

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks for fixing my copy pasta error!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Simple config files are always imported.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Good to know. I just updated it to only import the two menus.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I don't believe so. The commit contains an update hook that adds the menu if the user does not have it.

https://git.drupalcode.org/project/drupal/-/commit/f77a485d9141dcaf9c7bd...

/**
 * Creates the Navigation user links menu.
 */
function navigation_post_update_navigation_user_links_menu(array &$sandbox): void {
  $menu_storage = \Drupal::entityTypeManager()->getStorage('menu');

  // Do not create the new menu if already exists.
  if ($menu_storage->load('navigation-user-links')) {
    return;
  }

  $menu_storage
    ->create([
      'id' => 'navigation-user-links',
      'label' => 'Navigation user links',
      'description' => 'User links to be used in Navigation',
      'dependencies' => [
        'enforced' => [
          'module' => [
            'navigation',
          ],
        ],
      ],
      'locked' => TRUE,
    ])->save();
}
🇺🇸United States thejimbirch Cape Cod, Massachusetts

MR added that imports all the config from the Navigation module. Since the Navigation module is under active development, and Christina is the UX lead for both the module and Drupal CMS, I think it is safe to assume that any config entities they add are meant for Drupal CMS also.

If I am wrong about this, we can list the two menu configs individually.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I believe I addressed the points in the MR

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch made their first commit to this issue’s fork.

Production build 0.71.5 2024