Cape Cod, Massachusetts
Account created on 7 March 2013, about 12 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Core's standard recipes have references to the Contact module in addition to the standard profile.

I updated the issue summary. Did the list of tasks come from a template? If so, we should update that also as recipes probably did not exist at the time that list of things to do was generated.

🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Excellent, thanks! I confirm the doc is now publicly available.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

The use of the "rights" meta tag came from the Drupal 8 SEO Book's recommendations.

Since Google does not say they support it, lets remove it rather than hard coding it. As a note, Drupal.org doesn't even have a copyright in their footer. General consensus is that copyright is assumed just by publishing websites.

Moving to Needs Work, and will update MR to remove the tags.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I don't love it either, but it will make Drupal CMS cacheable until an upstream solution is finished.

I believe the date token comes from the Token module.
https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc...

But, I am not 100% sure. I didn't think core would be able to create tokens as it does not require the token module.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

MR added that replaces the uncacheable token with the current year.

Steps to validate

  • Install Drupal CMS. Verify x-drupal-dynamic-cache is a HIT for non-logged in users.
  • Login and apply the SEO Tools recipe.
  • Verify x-drupal-dynamic-cache is UNCACHEABLE for non-logged in users.
  • Checkout this issue's branch.
  • Reinstall Drupal CMS using ddev rebuild
  • Login and apply the SEO Tools recipe.
  • Verify x-drupal-dynamic-cache is a HIT for non-logged in users.
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Draft change record for the action exists: https://www.drupal.org/node/3519491

Can you add a little more detail with what your want with "the other to mention the publicizing of setSection."? I can try to add it.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Great addition. Thanks for the contribution!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch made their first commit to this issue’s fork.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to Drupal CMS project and assigning to Documentation track.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Adding tag so I can update the config action documentation when this lands.

Also asked Artem to review in the Drupal Slack.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Added a static copy of the patch from the merge request.

🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks so much for this. Look forward to using this in an upcoming project.

Updated the title for clarity.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

ok, the CI needed some updating behind the scenes to get the job to run. Which it is now, all green and you can preview the docs build here:

https://project.pages.drupalcode.org/-/distributions_recipes/-/jobs/4909...

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch changed the visibility of the branch 3409318-mkdocs to hidden.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch changed the visibility of the branch 3409318-gitlab-config to hidden.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch changed the visibility of the branch 3409318-3rd-time-charm to hidden.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Nope. Swing and a miss.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Merged that. Lets see if that works.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

There have been more changes since my lasy post that need to be documented.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Updated the change record to add that you can’t change those two keys.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Recipes added an "Extra" section in core. https://www.drupal.org/node/3504056

The idea is that modules, like Project Browser could consume information from recipes like display a message, or redirect to a page.

I don't know if any additional work has been done on Project browser yet, but this was added specifically for this use case.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thank you all for your contributions!

@kattia's first commit on Drupal.org

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I added link to Recipe Presentations and added a link to Martin's user profile.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks so much for the contribution, and great to see you!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks so much for your contribution!

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Looks great, but needs a merge request.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch changed the visibility of the branch 3505369-document-the-new to hidden.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Needs a Merge request and should be added to the table of contents also.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to Drupal core, and postponing on the Drupal Marketplace work.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to Drupal core. Merge request will need to be moved also.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to Drupal core.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving to Drupal core into the Recipes system component.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

That would be a great place to start, but I hope we can review all the issues.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

The documentation page linked above can be edited by anyone with a Drupal.org profile. Once you've added a recipe, or many recipes, post a comment here so we can give issue credit.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Hmmm, not working and I don't know why. Need to pause on this for now.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Discussed at DrupalCon to use the name setEntityProperties and use the simpleConfigUpdate style. set and setMultiple will remain, but the new action will be able to handle all the syntax.

config:
  action:
    node.type.article:
      setEntityProperties:
      # Can work on singular
      foo: bar
      # multiple
      cat: dog
      mouse: bird
      # and nested properties.
      nested.thing: yes
🇺🇸United States thejimbirch Cape Cod, Massachusetts

This looks good to me today and all comments resolved. Marking as RTBC.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Thanks for that, brain slip. GitLab.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I have no strong opinions either way, as both recipes are always applied, but revisions on content types is only one use. Another is in the config sync screen.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Closing this as Won't do.

But please share your recipe when you create it.

https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib...

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Since we have revisions for content types turned on, IMHO, we should have the diff module to compare revisions.

Assigning to Pam for approval.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Moving back to Needs work as the PHP tests are failing.

🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts

thejimbirch created an issue.

🇺🇸United States thejimbirch Cape Cod, Massachusetts

I ran into the same issue, with images vanishing when I dragged them to a new position in the editor.

We weren't using linked images, but I had the same experience.

Unchecking "Force pasting as plain text" just fixed it for me.

🇺🇸United States thejimbirch Cape Cod, Massachusetts
🇺🇸United States thejimbirch Cape Cod, Massachusetts

Screenshot added to change record.

Production build 0.71.5 2024