block_theme_initialize should not create blocks during config sync

$ drush cim (9.2.x|✚6…) +------------+----------------+-----------+ | Collection | Config | Operation | +------------+----------------+-----------+ | | core.extension | Update | +------------+----------------+-----------+ Import the listed configuration changes? (yes/no) [yes]: > y [notice] Synchronized extensions: install claro. [notice] Synchronized configuration: delete block.block.claro_tools. [notice] Synchronized configuration: delete block.block.claro_main_menu. [notice] Synchronized configuration: delete block.block.claro_footer. [notice] Synchronized configuration: delete block.block.claro_account_menu. [notice] Synchronized configuration: delete block.block.claro_branding. [notice] Synchronized configuration: delete block.block.claro_breadcrumbs. [notice] Synchronized configuration: delete block.block.claro_content. [notice] Synchronized configuration: delete block.block.claro_messages. [notice] Synchronized configuration: delete block.block.claro_powered. [notice] Synchronized configuration: delete block.block.claro_search. [notice] Synchronized configuration: delete block.block.claro_help. [notice] Synchronized configuration: delete claro.settings. [notice] Synchronized configuration: delete block.block.claro_local_actions. [notice] Synchronized configuration: delete block.block.claro_local_tasks. [notice] Synchronized configuration: delete block.block.claro_page_title. [notice] Finalizing configuration synchronization. [success] The configuration was imported successfully.

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →

🇪🇸Spain rcodina Barcelona

I ended up here because I'm doing a migration from core 9.5.11 to 10.1.5. On 9.5.11 we had Adminimal theme as admin theme and now we are enabling and configuring the Claro theme. The enabled Claro blocks are all set in yml config files. The problem is that when I import the configuration using customer's environment database the following error shows up:

In EntityStorageBase.php line 519:                                                                                              
                                                                                                                                  
    'block' entity with ID 'claro_footer' already exists.

Using patch on #6 it avoids the import error. However, the blocks we have set in yml files doesn't get imported. Moreover, If do a "drush cex", it deletes the claro blocks I had defined on those files:

 [notice] Differences of the active config to the export directory:

+------------+-----------------------------------------+-----------+
| Collection | Config                                  | Operation |
+------------+-----------------------------------------+-----------+
|            | block.block.claro_breadcrumbs           | Delete    |
|            | block.block.claro_content               | Delete    |
|            | block.block.claro_messages              | Delete    |
|            | block.block.claro_local_actions         | Delete    |
|            | block.block.claro_page_title            | Delete    |
|            | block.block.claro_primary_local_tasks   | Delete    |
|            | block.block.claro_secondary_local_tasks | Delete    |
+------------+-----------------------------------------+-----------+

Why they get deleted?

First commit to issue fork.
Comment 22 days ago →
🇺🇸United States thejimbirch Cape Cod, Massachusetts
Merge request !11926Do not call block_theme_initialize() during config sync → (Open) created by thejimbirch
Pipeline finished with Success
22 days ago
Total: 418s
#480259
Comment 22 days ago →
🇺🇸United States thejimbirch Cape Cod, Massachusetts
Comment 9 days ago →
🇺🇸United States thejimbirch Cape Cod, Massachusetts
Pipeline finished with Failed
about 6 hours ago
Total: 487s
#498093
Pipeline finished with Failed
about 5 hours ago
Total: 197s
#498116
Pipeline finished with Failed
about 5 hours ago
Total: 240s
#498123
Pipeline finished with Failed
about 5 hours ago
Total: 115s
#498134
Pipeline finished with Failed
about 5 hours ago
Total: 449s
#498157
Pipeline finished with Success
about 4 hours ago
Total: 559s
#498205
Comment about 4 hours ago →
🇺🇸United States thejimbirch Cape Cod, Massachusetts
Added tests and got everything to green. I used AI to help me put this together as I am still pretty green to writing tests.

The 3 tests are:

testNoBlocksCreatedDuringConfigSync
Verifies that block_themes_installed() does not create blocks during a config sync.

testBlockHooksModulesInstalledDuringSync
Confirms BlockHooks::modulesInstalled() avoids block creation during config sync.

testBlockHooksModulesInstalledWithoutSync
Ensures BlockHooks::modulesInstalled() does create blocks when not syncing.

block_theme_initialize should not create blocks during config sync

Problem/Motivation

Proposed resolution

Merge Requests

!11926block_theme_initialize should not create blocks during config sync
Open

Comments & Activities

block_theme_initialize should not create blocks during config sync

Problem/Motivation

Proposed resolution

Merge Requests

!11926block_theme_initialize should not create blocks during config syncOpen

Comments & Activities

!11926block_theme_initialize should not create blocks during config sync
Open