Please, review.
I've tested it and it doesn't work yet. We will need tests too.
Just check out description and added categories "Access control" and "Administration tools".
I've tested the patch and it works like a charm.
@pearls Please, test the patch in 🐛 Child field resets when multi-value parent field updated Needs work . It is a code which is already on Business Rules 3.0.0-beta1.
Gitlab CI is now enabled.
@pcambra I finally done all work in 📌 Automated Drupal 11 compatibility fixes for dependent_fields Needs review
rcodina → changed the visibility of the branch project-update-bot-only to hidden.
Only error left on gitlab pipeline is about QuickEdit which is no longer on core. We should consider remove any reference to it.
In my case this error blocks the deploy pipeline when installing new modules. I agree it's a server miss configuration, but it's not enough reason to block the deployment. So, apart from improving the error message, we should keep changes from current patch.
@anybody Just taged version 4.1.1.
Thanks to all.
@anybody Yes, let's open a follow up issue for the tests for this issue. In ✨ Add a new configurable email notification system Needs work I have done a JS test.
@anybody @grevil Fixed bug while testing. Please, review.
Just updated the MR on the linked issue.
I reproduce the error in Drupal 10.2.6 and 10.3.6 with Views Infinite Scroll 2.0.3. The patch of the MR doesn't fix the issue.
Similar, but use the MR I have created at 💬 Feeds integration for Drupal 8+ Closed: outdated as a starting point.
@anybody @grevil Changed selector with a custom class. Please, review.
Nice work. Thanks!
Nice work. Thanks!
Done!
A Feeds integration has to be implemented. It should be easy. Check out the D7 integration:
💬 Feeds integration for Drupal 8+ Closed: outdated
rcodina → created an issue.
MR patch works like a charm.
The missing code was from 🐛 Multi-valued dependent child fields are not saved Fixed
@gobind singh Could you please check out the patch of the MR?
To maintainers of the module: there are no tests and GitlabCI is not enabled. Wouldn't be better to do both in a new issue? We could rescue dependant tests from Business Rules as a starting point.
@kpaxman You are right.
I thinks this feature is implemented on https://www.drupal.org/project/user_expire → Maybe this issue it's just about linking to this User Expire module in the project's page.
Included in new 4.1.0 release.
Included in new 4.1.0 release.
Setting issue credits.
I'm trying to migrate from Business Rules (which is getting deprecated) module and I face the same problem. But in my case the parent field has only one value and the child can have many. The problem occurs when you edit an entity with a parent and multiple childs selected. If you switch to a parent with only one child and you select it, everything is fine. But If you switch again to a parent with multiple child values, the child field can only have one value and, when you try to save, it show an error that the field is mandatory and then the child field can have multiple values again.
@gobind singh Can you try Business Rules if it works for you? This would give more information about a possible solution.
Maybe we can compare both codes (BusinessRulesViewsSelectionand ViewsSelection) to try to figure out what's going on.
@kuzyawkk @anybody @rishabjasrotia Please, review.
@kuzyawkk You don't have to apologize. Just do it when you can. And if you can't, just leave the issue unassigned.
On the other hand, as written in the issue description, we are adding another field in the role form (just under the current "Default duration for the role" field).
@anybody With the suggested text, I think it's better to turn it FALSE by default for existing installs. Thanks all!
@elvin - albania drupal developer If you want to use it now you can patch the module via composer patching. It's fully working and it's multilingual. As you can see in the description and recent commits/messages, a lot of work has been done since your previous comment.
@anybody I think the new option "Expand role expiration fields by default" should be FALSE by default because it's much better. However, I agree for current module users we need an update hook to set it TRUE. You agree?
@anybody Such a great idea! Could you please review it? Once done, I think it should be collapsed bu default!
@anybody I think both can live together. This issue it's already implemented, we should not force users to install modules if not necessary.
I agree, this should be a submodule.
Thanks all!
Look fine. Let's go.
Finally, I fixed my problem with 🐛 Sort out and fix language fallback inconsistencies Needs work
Patch on #58 works like a charm on Drupal 10.3.5. In my case the problem was paragraph related: we have a paragraph published in Catalan and unpublished in English . However, before applying patch, it was still showing publicly in English.
rcodina → made their first commit to this issue’s fork.
Merged 2.x to fix conflicts of the MR.
The patch #18 works like a charm. But the MR patch doesn't apply.
Patch on #4 works like a charm.
With Drupal 10.2.3, Menu Link Attributes 1.5.0 and Superfish 1.7.0 my superfish menu is printing the classes without applying any patch.