- heddn Nicaragua
Actual functionality here works very well. No concerns with that. My nits are mainly about making this a better solution. The main one being around naming, which I recognize is a hard thing. Bumping back to NW.
-
+++ b/modules/role_expire_notification/config/schema/role_expire_notification.schema.yml @@ -0,0 +1,32 @@ + role_expire_notification_points:
Calling this a notification point doesn't make as much sense as calling it a notification method. Let's rename this here and elsewhere.
-
+++ b/modules/role_expire_notification/role_expire_notification.info.yml @@ -0,0 +1,8 @@ +core_version_requirement: ^8.8 || ^9
Let's change this to also include Drupal 10.
-
- Status changed to Needs review
over 1 year ago 4:07pm 27 March 2023 - heddn Nicaragua
Here's a fix for #15, along with a test of the new module. It also fixes several D10 incompatible issues. Mainly event dispatcher stuffs. It would be nice to have tests setup again as automated tests aren't executing right now.
- heddn Nicaragua
Re-rolled for 2.x. It was a trivial re-roll and the diff stats are identical.
- last update
over 1 year ago Composer require failure - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 13 pass - 🇳🇬Nigeria chike Nigeria
@heddn none of your patches applies on Drupal 9. I am using Drupal 9.5.10.
- 🇪🇸Spain rcodina Barcelona
@heddn @chike The patch cleanly applies to 3.x but this patch has to split:
1. Test fixes: See 🐛 Fix failing tests Fixed
2. New feature without test fixesOnce ready, this feature will be only committed to 3.x branch.
- Status changed to Needs work
over 1 year ago 5:46pm 23 August 2023 - Status changed to Needs review
over 1 year ago 5:53pm 23 August 2023 - last update
over 1 year ago 13 pass - 🇪🇸Spain rcodina Barcelona
Removed changes that overlap with 🐛 Fix failing tests Fixed
- 🇦🇱Albania elvin - albania drupal developer
any movement on this? it would be great to have this feature enabled or this module integrated with ECA for more power handling
- 🇪🇸Spain rcodina Barcelona
Once drupal 11 version is released (new 4.x branch), a new MR should be created from current patch.
- Status changed to Needs work
5 months ago 6:31pm 26 July 2024 - Merge request !14Issue #3036511: Add a new configurable email notification system → (Open) created by rcodina
- 🇪🇸Spain rcodina Barcelona
Added latest patch to a new issue fork and created a MR which targets 4.x branch.
- 🇩🇪Germany Anybody Porta Westfalica
✨ Make Rules integration a sub-module, provide ECA integration Active would also be a good and more flexible alternative maybe?
- 🇪🇸Spain rcodina Barcelona
@anybody I think both can live together. This issue it's already implemented, we should not force users to install modules if not necessary.
- 🇦🇱Albania elvin - albania drupal developer
any movement on this? Would really be helpful to have email notifications
- 🇪🇸Spain rcodina Barcelona
@elvin - albania drupal developer If you want to use it now you can patch the module via composer patching. It's fully working and it's multilingual. As you can see in the description and recent commits/messages, a lot of work has been done since your previous comment.
- 🇦🇱Albania elvin - albania drupal developer
Thank you! Testing it right now and will report on anything i may find!
- 🇦🇱Albania elvin - albania drupal developer
Thank you! Testing it right now and will report on anything i may find!